[GitHub] [arrow] bkietz commented on a change in pull request #11887: fixes for msvc environment

[GitBox <gi...@apache.org>]

bkietz commented on a change in pull request #11887:
URL: https://github.com/apache/arrow/pull/11887#discussion_r764304427



##########
File path: cpp/src/arrow/util/macros.h
##########
@@ -97,6 +97,17 @@
 
 #endif  // ifndef NULLPTR
 
+// ----------------------------------------------------------------------
+// microsoft source-code annotation language
+
+#ifndef _In_z_
+#define _In_z_
+#endif
+
+#ifndef _Out_writes_opt_
+#define _Out_writes_opt_(size)

Review comment:
       Unless these macros can be introduced in a cross platform way I don't think we should add them to arrow.

##########
File path: cpp/src/arrow/type.h
##########
@@ -714,9 +714,11 @@ class ARROW_EXPORT FixedSizeBinaryType : public FixedWidthType, public Parametri
 /// \brief Base type class for (fixed-size) decimal data
 class ARROW_EXPORT DecimalType : public FixedSizeBinaryType {
  public:
-  explicit DecimalType(Type::type type_id, int32_t byte_width, int32_t precision,
+  explicit DecimalType(Type::type override_type_id, int32_t byte_width, int32_t precision,

Review comment:
       Is this a reserved word or macro or something in some MSVC environment? If so, we should also add a lint pass which checks for that identifier




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org