You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2023/02/22 19:29:58 UTC
[hadoop] branch trunk updated: HADOOP-18582. Addendum: Skip unnecessary cleanup logic in DistCp. (#5409)
This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new e8a6b2c2c4e HADOOP-18582. Addendum: Skip unnecessary cleanup logic in DistCp. (#5409)
e8a6b2c2c4e is described below
commit e8a6b2c2c4e30773541a7d74d3a05c9babf92bce
Author: Ayush Saxena <ay...@apache.org>
AuthorDate: Thu Feb 23 00:59:41 2023 +0530
HADOOP-18582. Addendum: Skip unnecessary cleanup logic in DistCp. (#5409)
Followup to the original HADOOP-18582.
Temporary path cleanup is re-enabled for -append jobs
as these will create temporary files when creating or overwriting files.
Contributed by Ayush Saxena
---
.../java/org/apache/hadoop/tools/mapred/CopyCommitter.java | 5 +----
.../org/apache/hadoop/tools/mapred/TestCopyCommitter.java | 12 +++++-------
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyCommitter.java b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyCommitter.java
index 4ba05794a09..14eb8cfb8a6 100644
--- a/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyCommitter.java
+++ b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyCommitter.java
@@ -156,10 +156,7 @@ public class CopyCommitter extends FileOutputCommitter {
final boolean directWrite = conf.getBoolean(
DistCpOptionSwitch.DIRECT_WRITE.getConfigLabel(), false);
- final boolean append = conf.getBoolean(
- DistCpOptionSwitch.APPEND.getConfigLabel(), false);
- final boolean useTempTarget = !append && !directWrite;
- if (!useTempTarget) {
+ if (directWrite) {
return;
}
diff --git a/hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java b/hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java
index f2dd246db5a..6a537dc6e7d 100644
--- a/hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java
+++ b/hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java
@@ -586,13 +586,11 @@ public class TestCopyCommitter {
@Test
public void testCommitWithCleanupTempFiles() throws IOException {
- testCommitWithCleanup(true, false);
- testCommitWithCleanup(false, true);
- testCommitWithCleanup(true, true);
- testCommitWithCleanup(false, false);
+ testCommitWithCleanup(true);
+ testCommitWithCleanup(false);
}
- private void testCommitWithCleanup(boolean append, boolean directWrite)throws IOException {
+ private void testCommitWithCleanup(boolean directWrite) throws IOException {
TaskAttemptContext taskAttemptContext = getTaskAttemptContext(config);
JobID jobID = taskAttemptContext.getTaskAttemptID().getJobID();
JobContext jobContext = new JobContextImpl(
@@ -611,7 +609,7 @@ public class TestCopyCommitter {
DistCpOptions options = new DistCpOptions.Builder(
Collections.singletonList(new Path(sourceBase)),
new Path("/out"))
- .withAppend(append)
+ .withAppend(true)
.withSyncFolder(true)
.withDirectWrite(directWrite)
.build();
@@ -631,7 +629,7 @@ public class TestCopyCommitter {
null, taskAttemptContext);
committer.commitJob(jobContext);
- if (append || directWrite) {
+ if (directWrite) {
ContractTestUtils.assertPathExists(fs, "Temp files should not be cleanup with append or direct option",
tempFilePath);
} else {
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org