[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1947: Revamp Github Action settings for CI

[GitBox <gi...@apache.org>]

ulysses-you commented on a change in pull request #1947:
URL: https://github.com/apache/incubator-kyuubi/pull/1947#discussion_r811518542



##########
File path: .github/workflows/master.yml
##########
@@ -53,36 +63,21 @@ jobs:
         with:
           distribution: zulu
           java-version: ${{ matrix.java }}
-      - uses: actions/cache@v2
-        with:
-          path: ~/.m2/repository/com
-          key: ${{ runner.os }}-maven-com-${{ hashFiles('**/pom.xml') }}
-          restore-keys: |
-            ${{ runner.os }}-maven-com-
-      - uses: actions/cache@v2
-        with:
-          path: ~/.m2/repository/org
-          key: ${{ runner.os }}-maven-org-${{ hashFiles('**/pom.xml') }}
-          restore-keys: |
-            ${{ runner.os }}-maven-org-
-      - uses: actions/cache@v2
-        with:
-          path: ~/.m2/repository/net
-          key: ${{ runner.os }}-maven-net-${{ hashFiles('**/pom.xml') }}
-          restore-keys: |
-            ${{ runner.os }}-maven-net-
-      - uses: actions/cache@v2
-        with:
-          path: ~/.m2/repository/io
-          key: ${{ runner.os }}-maven-io-${{ hashFiles('**/pom.xml') }}
-          restore-keys: |
-            ${{ runner.os }}-maven-io-
-      - name: Build with Maven
+          cache: 'maven'

Review comment:
       this is a good code improvement ! more details [action docs](https://github.com/actions/setup-java#caching-packages-dependencies)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org