You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org> on 2017/08/22 22:51:00 UTC

[jira] [Commented] (RATIS-110) Add a static valueOf method to ClientId and RaftGroupId

    [ https://issues.apache.org/jira/browse/RATIS-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137548#comment-16137548 ] 

Tsz Wo Nicholas Sze commented on RATIS-110:
-------------------------------------------

We should also
- change the public constructors to private, and
- rename the createId() method to randomId().

> Add a static valueOf method to ClientId and RaftGroupId
> -------------------------------------------------------
>
>                 Key: RATIS-110
>                 URL: https://issues.apache.org/jira/browse/RATIS-110
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Priority: Minor
>
> Currently, we directly use a constructor to create ClientId / RaftGroupId.  It is better to use valueOf instead of a constructor since the return value can possibly be cached in the future.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)