You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/12 09:11:54 UTC

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1570: [SCB-1472] Allow users to disable the param validation by configuration

liubao68 commented on issue #1570: [SCB-1472] Allow users to disable the param validation by configuration
URL: https://github.com/apache/servicecomb-java-chassis/pull/1570#issuecomment-585105835
 
 
   There are some questions and problems with PR:
   
   1. when disable validation, why not exclude 
   ```
       <dependency>
         <groupId>org.apache.servicecomb</groupId>
         <artifactId>swagger-invocation-validator</artifactId>
       </dependency>
   ```
   , is this feature for debug use?
   
   2. your code is a bit complication. See IsolationDiscoveryFilter for an example how to read dynamic property more efficient.  Docs are [here](http://localhost:8000/config/general-config/)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services