You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2024/01/19 17:00:42 UTC
[PR] [MINOR][DOCS] Remove mention of Jenkins from "Building Spark" docs [spark]
nchammas opened a new pull request, #44804:
URL: https://github.com/apache/spark/pull/44804
### What changes were proposed in this pull request?
- Remove mention of Jenkins from the "Building Spark" docs as we do not use Jenkins anymore.
- Add syntax highlighting to some of the code blocks.
- Adjust the headings of some sections that were set too deep.
### Why are the changes needed?
This makes the guide a bit more up-to-date and easier to read.
### Does this PR introduce _any_ user-facing change?
Yes, it changes the public documentation on building Spark.
### How was this patch tested?
I manually built the docs and reviewed the results.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Adjust formatting of "Building Spark" docs [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #44804:
URL: https://github.com/apache/spark/pull/44804#issuecomment-1902758408
+1, LGTM. Merging to master.
Thank you, @nchammas and @bjornjorgensen for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Adjust formatting of "Building Spark" docs [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #44804: [MINOR][DOCS] Adjust formatting of "Building Spark" docs
URL: https://github.com/apache/spark/pull/44804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Remove mention of Jenkins from "Building Spark" docs [spark]
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #44804:
URL: https://github.com/apache/spark/pull/44804#issuecomment-1900987231
"Remove mention of Jenkins from the "Building Spark" docs as we do not use Jenkins anymore."
have a look at https://github.com/apache/spark/pull/40178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Remove mention of Jenkins from "Building Spark" docs [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #44804:
URL: https://github.com/apache/spark/pull/44804#issuecomment-1901035166
Oh, interesting. Thanks for the reference. As we have both been confused by this same issue, perhaps I should update that text to reference the Jenkins infrastructure that Scaleway is maintaining for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org