You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gossip.apache.org by chandresh pancholi <ch...@gmail.com> on 2016/09/10 19:28:09 UTC
PR raised for GOSSIP-19 and GOSSIP-23
Hi,
I have raised PR for GOSSIP-19 and GOSSIP-23. Both are Web UI improvements.
Please review and merge with "site-src" branch.
Thanks
--
Chandresh Pancholi
Senior Software Engineer
Flipkart.com
Email-id:chandresh.pancholi@flipkart.com
Contact:08951803660
Re: PR raised for GOSSIP-19 and GOSSIP-23
Posted by chandresh pancholi <ch...@gmail.com>.
I exactly don't remember though. I tried with bundle install and it failed
on nokogiri. Once i installed it manually it worked fine.
If i see this again i will take screenshot and share.
Now i am raising a PR for asf-site branch. Please review and merge.
Thanks
On Thu, Sep 15, 2016 at 2:33 AM, Josh Elser <jo...@gmail.com> wrote:
>
>
> chandresh pancholi wrote:
>
>> Answer inline
>>
>> Q. How to deploy latest web changes on production?
>>
>
> The generated website is placed in the asf-site branch. You could use two
> pull requests to manage this. The updated jekyll website in a PR to
> site-src and the generated website from your jekyll changes in a PR to
> asf-site.
>
> ASF infrastructure will automatically publish any changes to asf-site to
> the public website.
>
> On Wed, Sep 14, 2016 at 7:08 PM, Edward Capriolo<ed...@gmail.com>
>> wrote:
>>
>> Question. Pardon my ignorance on this topic.
>>>
>>> 1) Did you figure out how to build the gem project
>>>
>>> Initially bundle install will work. if it didn't then manually installed
>> required gem. I faced some problem with nokogiri 1.6.8 version. i
>> installed
>> it manunally.
>>
>
> Was this problems you ran into while building nokogiri? The `bundle
> install` should have automatically done everything for you, but there are
> some native extensions to nokogiri that I would guess you could have run
> into... Just curious if it's something wrong with our bundler configuration.
>
>
> 2) It looks like we have to commit the generated artifacts. Did your patch
>>> make changes to the generated artifacts or only the source ones?
>>>
>>> i didn't make any changes.existing source will work.
>>
>> On Wed, Sep 14, 2016 at 9:21 AM, chandresh pancholi<
>>> chandreshpancholi007@gmail.com> wrote:
>>>
>>> Hi,
>>>>
>>>> Please review the PR and provide your feedback.
>>>>
>>>> Thanks
>>>>
>>>> On Sun, Sep 11, 2016 at 12:58 AM, chandresh pancholi<
>>>> chandreshpancholi007@gmail.com> wrote:
>>>>
>>>> Hi,
>>>>>
>>>>> I have raised PR for GOSSIP-19 and GOSSIP-23. Both are Web UI
>>>>> improvements. Please review and merge with "site-src" branch.
>>>>>
>>>>> Thanks
>>>>>
>>>>> --
>>>>> Chandresh Pancholi
>>>>> Senior Software Engineer
>>>>> Flipkart.com
>>>>> Email-id:chandresh.pancholi@flipkart.com
>>>>> Contact:08951803660
>>>>>
>>>>>
>>>>
>>>> --
>>>> Chandresh Pancholi
>>>> Senior Software Engineer
>>>> Flipkart.com
>>>> Email-id:chandresh.pancholi@flipkart.com
>>>> Contact:08951803660
>>>>
>>>>
>>
>>
>>
--
Chandresh Pancholi
Senior Software Engineer
Flipkart.com
Email-id:chandresh.pancholi@flipkart.com
Contact:08951803660
Re: PR raised for GOSSIP-19 and GOSSIP-23
Posted by Josh Elser <jo...@gmail.com>.
chandresh pancholi wrote:
> Answer inline
>
> Q. How to deploy latest web changes on production?
The generated website is placed in the asf-site branch. You could use
two pull requests to manage this. The updated jekyll website in a PR to
site-src and the generated website from your jekyll changes in a PR to
asf-site.
ASF infrastructure will automatically publish any changes to asf-site to
the public website.
> On Wed, Sep 14, 2016 at 7:08 PM, Edward Capriolo<ed...@gmail.com>
> wrote:
>
>> Question. Pardon my ignorance on this topic.
>>
>> 1) Did you figure out how to build the gem project
>>
> Initially bundle install will work. if it didn't then manually installed
> required gem. I faced some problem with nokogiri 1.6.8 version. i installed
> it manunally.
Was this problems you ran into while building nokogiri? The `bundle
install` should have automatically done everything for you, but there
are some native extensions to nokogiri that I would guess you could have
run into... Just curious if it's something wrong with our bundler
configuration.
>> 2) It looks like we have to commit the generated artifacts. Did your patch
>> make changes to the generated artifacts or only the source ones?
>>
> i didn't make any changes.existing source will work.
>
>> On Wed, Sep 14, 2016 at 9:21 AM, chandresh pancholi<
>> chandreshpancholi007@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> Please review the PR and provide your feedback.
>>>
>>> Thanks
>>>
>>> On Sun, Sep 11, 2016 at 12:58 AM, chandresh pancholi<
>>> chandreshpancholi007@gmail.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> I have raised PR for GOSSIP-19 and GOSSIP-23. Both are Web UI
>>>> improvements. Please review and merge with "site-src" branch.
>>>>
>>>> Thanks
>>>>
>>>> --
>>>> Chandresh Pancholi
>>>> Senior Software Engineer
>>>> Flipkart.com
>>>> Email-id:chandresh.pancholi@flipkart.com
>>>> Contact:08951803660
>>>>
>>>
>>>
>>> --
>>> Chandresh Pancholi
>>> Senior Software Engineer
>>> Flipkart.com
>>> Email-id:chandresh.pancholi@flipkart.com
>>> Contact:08951803660
>>>
>
>
>
Re: PR raised for GOSSIP-19 and GOSSIP-23
Posted by chandresh pancholi <ch...@gmail.com>.
Answer inline
Q. How to deploy latest web changes on production?
On Wed, Sep 14, 2016 at 7:08 PM, Edward Capriolo <ed...@gmail.com>
wrote:
> Question. Pardon my ignorance on this topic.
>
> 1) Did you figure out how to build the gem project
>
Initially bundle install will work. if it didn't then manually installed
required gem. I faced some problem with nokogiri 1.6.8 version. i installed
it manunally.
> 2) It looks like we have to commit the generated artifacts. Did your patch
> make changes to the generated artifacts or only the source ones?
>
i didn't make any changes.existing source will work.
>
> On Wed, Sep 14, 2016 at 9:21 AM, chandresh pancholi <
> chandreshpancholi007@gmail.com> wrote:
>
> > Hi,
> >
> > Please review the PR and provide your feedback.
> >
> > Thanks
> >
> > On Sun, Sep 11, 2016 at 12:58 AM, chandresh pancholi <
> > chandreshpancholi007@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > I have raised PR for GOSSIP-19 and GOSSIP-23. Both are Web UI
> > > improvements. Please review and merge with "site-src" branch.
> > >
> > > Thanks
> > >
> > > --
> > > Chandresh Pancholi
> > > Senior Software Engineer
> > > Flipkart.com
> > > Email-id:chandresh.pancholi@flipkart.com
> > > Contact:08951803660
> > >
> >
> >
> >
> > --
> > Chandresh Pancholi
> > Senior Software Engineer
> > Flipkart.com
> > Email-id:chandresh.pancholi@flipkart.com
> > Contact:08951803660
> >
>
--
Chandresh Pancholi
Senior Software Engineer
Flipkart.com
Email-id:chandresh.pancholi@flipkart.com
Contact:08951803660
Re: PR raised for GOSSIP-19 and GOSSIP-23
Posted by Edward Capriolo <ed...@gmail.com>.
Question. Pardon my ignorance on this topic.
1) Did you figure out how to build the gem project
2) It looks like we have to commit the generated artifacts. Did your patch
make changes to the generated artifacts or only the source ones?
On Wed, Sep 14, 2016 at 9:21 AM, chandresh pancholi <
chandreshpancholi007@gmail.com> wrote:
> Hi,
>
> Please review the PR and provide your feedback.
>
> Thanks
>
> On Sun, Sep 11, 2016 at 12:58 AM, chandresh pancholi <
> chandreshpancholi007@gmail.com> wrote:
>
> > Hi,
> >
> > I have raised PR for GOSSIP-19 and GOSSIP-23. Both are Web UI
> > improvements. Please review and merge with "site-src" branch.
> >
> > Thanks
> >
> > --
> > Chandresh Pancholi
> > Senior Software Engineer
> > Flipkart.com
> > Email-id:chandresh.pancholi@flipkart.com
> > Contact:08951803660
> >
>
>
>
> --
> Chandresh Pancholi
> Senior Software Engineer
> Flipkart.com
> Email-id:chandresh.pancholi@flipkart.com
> Contact:08951803660
>
Re: PR raised for GOSSIP-19 and GOSSIP-23
Posted by chandresh pancholi <ch...@gmail.com>.
Hi,
Please review the PR and provide your feedback.
Thanks
On Sun, Sep 11, 2016 at 12:58 AM, chandresh pancholi <
chandreshpancholi007@gmail.com> wrote:
> Hi,
>
> I have raised PR for GOSSIP-19 and GOSSIP-23. Both are Web UI
> improvements. Please review and merge with "site-src" branch.
>
> Thanks
>
> --
> Chandresh Pancholi
> Senior Software Engineer
> Flipkart.com
> Email-id:chandresh.pancholi@flipkart.com
> Contact:08951803660
>
--
Chandresh Pancholi
Senior Software Engineer
Flipkart.com
Email-id:chandresh.pancholi@flipkart.com
Contact:08951803660