You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/22 15:27:41 UTC
[GitHub] [hive] belugabehr opened a new pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
belugabehr opened a new pull request #2002:
URL: https://github.com/apache/hive/pull/2002
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #2002:
URL: https://github.com/apache/hive/pull/2002#discussion_r637943868
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/TruncDateFromTimestamp.java
##########
@@ -147,18 +148,29 @@ protected void truncDate(ColumnVector inV, BytesColumnVector outV, int i) {
}
protected void processDate(BytesColumnVector outV, int i, Date date) {
- if ("MONTH".equals(fmt) || "MON".equals(fmt) || "MM".equals(fmt)) {
+ switch (fmt) {
+ case "YEAR":
+ case "YYYY":
+ case "YY":
+ date.setMonth(1);
Review comment:
Hey @belugabehr -- it was actually the fall through that confused me, I see what you are doing now
In the original code it was part of an else if statement taking care of both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #2002:
URL: https://github.com/apache/hive/pull/2002#discussion_r637813089
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/TruncDateFromTimestamp.java
##########
@@ -147,18 +148,29 @@ protected void truncDate(ColumnVector inV, BytesColumnVector outV, int i) {
}
protected void processDate(BytesColumnVector outV, int i, Date date) {
- if ("MONTH".equals(fmt) || "MON".equals(fmt) || "MM".equals(fmt)) {
+ switch (fmt) {
+ case "YEAR":
+ case "YYYY":
+ case "YY":
+ date.setMonth(1);
Review comment:
date.setMonth(1) might be missing here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #2002:
URL: https://github.com/apache/hive/pull/2002#discussion_r637943868
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/TruncDateFromTimestamp.java
##########
@@ -147,18 +148,29 @@ protected void truncDate(ColumnVector inV, BytesColumnVector outV, int i) {
}
protected void processDate(BytesColumnVector outV, int i, Date date) {
- if ("MONTH".equals(fmt) || "MON".equals(fmt) || "MM".equals(fmt)) {
+ switch (fmt) {
+ case "YEAR":
+ case "YYYY":
+ case "YY":
+ date.setMonth(1);
Review comment:
Hey @belugabehr -- it was actually the fall through that confused me, I see what you are doing now
In the original call it was part of an else if statement taking care of both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2002:
URL: https://github.com/apache/hive/pull/2002#issuecomment-784617451
@miklosgergely Minor improvement if you have any PR review cycles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2002:
URL: https://github.com/apache/hive/pull/2002#issuecomment-846606241
@miklosgergely :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr merged pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
Posted by GitBox <gi...@apache.org>.
belugabehr merged pull request #2002:
URL: https://github.com/apache/hive/pull/2002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #2002:
URL: https://github.com/apache/hive/pull/2002#discussion_r637943868
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/TruncDateFromTimestamp.java
##########
@@ -147,18 +148,29 @@ protected void truncDate(ColumnVector inV, BytesColumnVector outV, int i) {
}
protected void processDate(BytesColumnVector outV, int i, Date date) {
- if ("MONTH".equals(fmt) || "MON".equals(fmt) || "MM".equals(fmt)) {
+ switch (fmt) {
+ case "YEAR":
+ case "YYYY":
+ case "YY":
+ date.setMonth(1);
Review comment:
Hey @belugabehr -- it was actually the fall through that confused me, I see what you are doing now
In the [original code it was part of an else if statement taking care of both](https://github.com/apache/hive/pull/2002/files#diff-9a5478214c2ce29fdb4ea633ae8c9adc6a163b44fc987458686fc82cd02d3e22L160).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2002:
URL: https://github.com/apache/hive/pull/2002#issuecomment-846656268
@pgaref If you are available for a quick review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on a change in pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #2002:
URL: https://github.com/apache/hive/pull/2002#discussion_r637940606
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/TruncDateFromTimestamp.java
##########
@@ -147,18 +148,29 @@ protected void truncDate(ColumnVector inV, BytesColumnVector outV, int i) {
}
protected void processDate(BytesColumnVector outV, int i, Date date) {
- if ("MONTH".equals(fmt) || "MON".equals(fmt) || "MM".equals(fmt)) {
+ switch (fmt) {
+ case "YEAR":
+ case "YYYY":
+ case "YY":
+ date.setMonth(1);
Review comment:
@pgaref Thanks so much for taking a look. I'm not sure however what your comment means.
The year stuff get `Month=1` and `dayOfMonth=1`. The Month stuff gets only `dayOfMonth=1`.
This switch statement "falls through" to cover both outcomes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr closed pull request #2002: HIVE-24810: Use JDK 8 String Switch in TruncDateFromTimestamp
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #2002:
URL: https://github.com/apache/hive/pull/2002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org