You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/04/08 16:05:28 UTC
[GitHub] [incubator-apisix] leonardjin opened a new issue #1431: bug:
leonardjin opened a new issue #1431: bug:
URL: https://github.com/apache/incubator-apisix/issues/1431
prometheus impact the performance too much
is there space to optimize the plugins?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1431: bug:
URL: https://github.com/apache/incubator-apisix/issues/1431#issuecomment-611265176
please prove more information, for example, your route rules. one more thing, please confirm you are using standard `prometheus` plugin of Apache APISIX.
I have tested the prometheus plugin before, and the performance drop after activation is about 15%.
If you want to get better performance, this library may be useful: https://github.com/Kong/lua-resty-counter .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis edited a comment on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #1431: bug:
URL: https://github.com/apache/incubator-apisix/issues/1431#issuecomment-611265176
please prove more information, for example, your route rules.
I have tested the prometheus plugin before, and the performance drop after activation is about 15%.
I guess you do not use standard prometheus plugin in APISIX, please confirms this.
If you want to get better performance, this library may be useful: https://github.com/Kong/lua-resty-counter .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1431: bug:
URL: https://github.com/apache/incubator-apisix/issues/1431#issuecomment-611269713
> I guess you do not use standard prometheus plugin in APISIX, please confirms this.
Looking at the call stack of the flame graph, it appears that the plug-in for Apache APISIX is indeed being used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] Miss-you commented on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
Miss-you commented on issue #1431: bug:
URL: https://github.com/apache/incubator-apisix/issues/1431#issuecomment-611283665
dependencies = {
"lua-resty-template = 1.9",
"lua-resty-etcd = 0.9",
"lua-resty-balancer = 0.02rc5",
"lua-resty-ngxvar = 0.5",
"lua-resty-jit-uuid = 0.0.7",
"lua-resty-healthcheck-iresty = 2.0",
"lua-resty-jwt = 0.2.0",
"lua-resty-cookie = 0.1.0",
"lua-resty-session = 2.24",
"opentracing-openresty = 0.1",
"lua-resty-radixtree = 1.8",
"lua-protobuf = 0.3.1",
"lua-resty-openidc = 1.7.2-1",
"luafilesystem = 1.7.0-2",
"lua-tinyyaml = 0.1",
"lua-resty-prometheus = 1.0",
"jsonschema = 0.8",
"lua-resty-ipmatcher = 0.6",
"lua-resty-kafka = 0.07",
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1431: bug:
URL: https://github.com/apache/incubator-apisix/issues/1431#issuecomment-611265427
@leonardjin please set a good title, I think you just need help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [apisix] membphis commented on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1431:
URL: https://github.com/apache/apisix/issues/1431#issuecomment-667787360
fixed with new version of `nginx-lua-prometheus`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis edited a comment on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #1431: bug:
URL: https://github.com/apache/incubator-apisix/issues/1431#issuecomment-611284640
How many worker processes have you enabled? I guess 48 worker processes.
If this is the case, you can try to reduce the number of workers and make a comparison.
If you can be sure that the performance of multi-core prometheus is poor, it is a good way to improve it with resty-counter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1431: bug:
URL: https://github.com/apache/incubator-apisix/issues/1431#issuecomment-611270333
> please prove more information, for example, your route rules.
>
> I have tested the prometheus plugin before, and the performance drop after activation is about 15%.
> I guess you do not use standard prometheus plugin in APISIX, please confirms this.
>
> If you want to get better performance, this library may be useful: https://github.com/Kong/lua-resty-counter .
I don't think this will solve the problem. If the flame graph had been displayed more completely, we would have been able to find the bottleneck. We can't just shoot with our eyes closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1431: bug:
URL: https://github.com/apache/incubator-apisix/issues/1431#issuecomment-611269409
The top of the flame diagram is garbled, is the full debug symbol not installed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1431: bug:
URL: https://github.com/apache/incubator-apisix/issues/1431#issuecomment-611284640
how
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [apisix] membphis closed issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
membphis closed issue #1431:
URL: https://github.com/apache/apisix/issues/1431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on issue #1431: bug:
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1431:
URL: https://github.com/apache/incubator-apisix/issues/1431#issuecomment-616267044
@Miss-you @leonardjin any news? it seems that the `nginx-lua-prometheus` will release a new version soon, it has better performance.
https://github.com/knyar/nginx-lua-prometheus/commits/master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org