[GitHub] [cloudstack] wido commented on a diff in pull request #7746: make control.cidr and control.gateway dynamic

["wido (via GitHub)" <gi...@apache.org>]

wido commented on code in PR #7746:
URL: https://github.com/apache/cloudstack/pull/7746#discussion_r1308479382


##########
engine/components-api/src/main/java/com/cloud/configuration/ConfigurationManager.java:
##########
@@ -54,10 +55,40 @@
  */
 public interface ConfigurationManager {
 
-    public static final String MESSAGE_CREATE_POD_IP_RANGE_EVENT = "Message.CreatePodIpRange.Event";
-    public static final String MESSAGE_DELETE_POD_IP_RANGE_EVENT = "Message.DeletePodIpRange.Event";
-    public static final String MESSAGE_CREATE_VLAN_IP_RANGE_EVENT = "Message.CreateVlanIpRange.Event";
-    public static final String MESSAGE_DELETE_VLAN_IP_RANGE_EVENT = "Message.DeleteVlanIpRange.Event";
+    String MESSAGE_CREATE_POD_IP_RANGE_EVENT = "Message.CreatePodIpRange.Event";
+    String MESSAGE_DELETE_POD_IP_RANGE_EVENT = "Message.DeletePodIpRange.Event";
+    String MESSAGE_CREATE_VLAN_IP_RANGE_EVENT = "Message.CreateVlanIpRange.Event";
+    String MESSAGE_DELETE_VLAN_IP_RANGE_EVENT = "Message.DeleteVlanIpRange.Event";
+
+    ConfigKey<Boolean> SystemVMUseLocalStorage = new ConfigKey<>(
+            Boolean.class,
+            "system.vm.use.local.storage",
+            "Advanced",
+            "false",
+            "Indicates whether to use local storage pools or shared storage pools for system VMs.",
+            false,
+            ConfigKey.Scope.Zone,
+            null);
+
+    ConfigKey<String> ControlCidr = new ConfigKey<>(
+            String.class,
+            "control.cidr",
+            "Advanced",
+            "169.254.0.0/16",

Review Comment:
   Almost @DaanHoogland , but also in:
   
   - NetUtils.java
   - AgentProperties.java
   - configuration/Config.java
   
   If we change it to a /20 in those files we should be good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org