You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "jerry-024 (via GitHub)" <gi...@apache.org> on 2025/04/22 03:04:17 UTC
[PR] [core] fix refresh token [paimon]
jerry-024 opened a new pull request, #5504:
URL: https://github.com/apache/paimon/pull/5504
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
fix refresh token: add log and expire token when in 1 hour.
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] fix refresh token [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #5504:
URL: https://github.com/apache/paimon/pull/5504#discussion_r2053275037
##########
paimon-core/src/main/java/org/apache/paimon/rest/RESTTokenFileIO.java:
##########
@@ -186,10 +191,11 @@ private void tryToRefreshToken() {
}
private boolean shouldRefresh() {
- return token == null || System.currentTimeMillis() > token.expireAtMillis();
+ return token == null || token.expireAtMillis() - System.currentTimeMillis() < 3600_000L;
}
private void refreshToken() {
+ LOG.info("begin refresh token for identifier [{}]", identifier);
Review Comment:
log expire time after refreshing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] fix refresh token to earlier refresh and log refresh [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #5504:
URL: https://github.com/apache/paimon/pull/5504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org