[jira] [Commented] (THRIFT-4561) Python: cleanup socket timeout settings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455684#comment-16455684 ] 

ASF GitHub Bot commented on THRIFT-4561:
----------------------------------------

sokac opened a new pull request #1550: THRIFT-4561: Remove python socket timeout
URL: https://github.com/apache/thrift/pull/1550
 
 
   Client: py
   
   Timeout is already set in HttpClient. The reason for removal is issue
   with gunicorn and gevent as described here
   https://github.com/benoitc/gunicorn/pull/1616
   
   Tested locally, works as expected

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Python: cleanup socket timeout settings
> ---------------------------------------
>
>                 Key: THRIFT-4561
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4561
>             Project: Thrift
>          Issue Type: Task
>          Components: Python - Library
>            Reporter: Josip Sokcevic
>            Priority: Trivial
>
> Setting default socket timeout can lead to side effects with latest version of gunicorn:
> [https://github.com/benoitc/gunicorn/issues/880]
> [https://github.com/benoitc/gunicorn/pull/1616]
> Since timeout is set in HttpClient, there's no longer need to set socket default timeout



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)