You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/16 07:24:48 UTC

[GitHub] [cloudstack] DaanHoogland commented on pull request #4714: Cleaning up code and enhancing a few IP management logs

DaanHoogland commented on pull request #4714:
URL: https://github.com/apache/cloudstack/pull/4714#issuecomment-881236226


   @GabrielBrascher I have no opinion to speak of ;
   
   > Additionally, method `com.cloud.network.NetworkModelImpl.areServicesEnabledInZone` does not use list `checkedProvider`; the respective list should either be removed or populated.
   > 
   > I have chosen to add provider names at `checkedProvider`, instead of removing it; however, I would appreciate any opinion/suggestion.
   
   However, can you provide insight into your testing, i'm trusting the smoke tests a bit only. Any other testing needed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org