[GitHub] DaveDeCaprio opened a new pull request #23833: [SPARK-26917][SQL] Cache lock recache by condition

[GitBox <gi...@apache.org>]

DaveDeCaprio opened a new pull request #23833: [SPARK-26917][SQL] Cache lock recache by condition
URL: https://github.com/apache/spark/pull/23833
 
 
   ## What changes were proposed in this pull request?
   
   Related to SPARK-26617 and SPARK-26548.  There was a new location we found where we were still seeing the locks.  We traced it to the recacheByCondition function.  In this PR I have changed that function so that the writeLock is not held while the condition is being evaluated.
   
   @cloud-fan & @gatorsmile This is a further tweak to the other cache PRs we have done (which have helped us tremendously).
   
   ## How was this patch tested?
   
   Has been tested on a live system where the blocking was causing major issues and it is working well.
   CacheManager has no explicit unit test but is used in many places internally as part of the SharedState.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org