[GitHub] [superset] zhaoyongjie edited a comment on pull request #17341: feat(viz): export csv with verbose_name

[GitBox <gi...@apache.org>]

zhaoyongjie edited a comment on pull request #17341:
URL: https://github.com/apache/superset/pull/17341#issuecomment-986557698


   > > > Please refer to PR #17657 .This PR, my rebase failed. @zhaoyongjie @villebro
   > > 
   > > 
   > > I think you don't need to a lot of changes to this PR. please double check.
   > > <img alt="image" width="427" src="https://user-images.githubusercontent.com/2016594/144810885-130fe903-22fa-48ec-8ec0-dffacc6b3521.png">
   > 
   > I thought the wrong way at the time, which caused patch-3 to fail to rebase, which resulted in so many changes.
   
   Yep, there are a couple of changes recently in the codebase. The `get_data` method has moved into `query_context_processor.py`. I think you can cherry-pick original change into that.
   
   If you have any questions, please ping me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org