You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/14 11:38:33 UTC
[GitHub] [rocketmq-client-go] tt-live opened a new pull request #755: fix goroutine leaked
tt-live opened a new pull request #755:
URL: https://github.com/apache/rocketmq-client-go/pull/755
## What is the purpose of the change
fix the problem that chan is not closed when the queue is closed
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #755: [ISSUE #754] Fix goroutine leaked
Posted by GitBox <gi...@apache.org>.
wenfengwang commented on pull request #755:
URL: https://github.com/apache/rocketmq-client-go/pull/755#issuecomment-995396270
@tt-live Could you tell me which issue you fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] tt-live commented on pull request #755: [ISSUE #741] Fix goroutine leaked
Posted by GitBox <gi...@apache.org>.
tt-live commented on pull request #755:
URL: https://github.com/apache/rocketmq-client-go/pull/755#issuecomment-1032394307
@wenfengwang Hi when will this version be merged ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #755: fix goroutine leaked
Posted by GitBox <gi...@apache.org>.
wenfengwang commented on pull request #755:
URL: https://github.com/apache/rocketmq-client-go/pull/755#issuecomment-994343627
@tt-live Hi, The CI failed because of format, could you fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #755: [ISSUE #741] Fix goroutine leaked
Posted by GitBox <gi...@apache.org>.
wenfengwang commented on pull request #755:
URL: https://github.com/apache/rocketmq-client-go/pull/755#issuecomment-995398036
Aha, I just find issue #741 that this PR fixes to, if it is not, please tell me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org