You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by an...@apache.org on 2005/04/13 09:55:11 UTC

svn commit: r161163 - lenya/branches/BRANCH_1_2_X/src/java/org/apache/lenya/cms/cocoon/generation/SiteTreeGenerator.java

Author: andreas
Date: Wed Apr 13 00:55:09 2005
New Revision: 161163

URL: http://svn.apache.org/viewcvs?view=rev&rev=161163
Log:
SiteTreeGenerator: use XML namespace for xml:lang attribute, this fixes the display of non-default languages. Thanks to Josias Thoeny.

Modified:
    lenya/branches/BRANCH_1_2_X/src/java/org/apache/lenya/cms/cocoon/generation/SiteTreeGenerator.java

Modified: lenya/branches/BRANCH_1_2_X/src/java/org/apache/lenya/cms/cocoon/generation/SiteTreeGenerator.java
URL: http://svn.apache.org/viewcvs/lenya/branches/BRANCH_1_2_X/src/java/org/apache/lenya/cms/cocoon/generation/SiteTreeGenerator.java?view=diff&r1=161162&r2=161163
==============================================================================
--- lenya/branches/BRANCH_1_2_X/src/java/org/apache/lenya/cms/cocoon/generation/SiteTreeGenerator.java (original)
+++ lenya/branches/BRANCH_1_2_X/src/java/org/apache/lenya/cms/cocoon/generation/SiteTreeGenerator.java Wed Apr 13 00:55:09 2005
@@ -43,6 +43,7 @@
 import org.apache.log4j.Logger;
 import org.xml.sax.SAXException;
 import org.xml.sax.helpers.AttributesImpl;
+import org.xml.sax.helpers.NamespaceSupport;
 
 public class SiteTreeGenerator extends ServiceableGenerator
     implements Parameterizable, CacheableProcessingComponent
@@ -160,7 +161,7 @@
     
     private void generateLabels(Label label) throws SAXException {
         atts.clear();
-        atts.addAttribute("", LANG_ATTRIBUTE, Q_LANG_ATTRIBUTE, CDATA, label.getLanguage());
+        atts.addAttribute(NamespaceSupport.XMLNS, LANG_ATTRIBUTE, Q_LANG_ATTRIBUTE, CDATA, label.getLanguage());
 
         this.contentHandler.startElement(SiteTree.NAMESPACE_URI, LABEL_ELEMENT, LABEL_ELEMENT, atts);
         char[] labelA = label.getLabel().toCharArray();



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org

Re: svn commit: r161163 - lenya/branches/BRANCH_1_2_X/src/java/org/apache/lenya/cms/cocoon/generation/SiteTreeGenerator.java

Posted by Andreas Hartmann <an...@apache.org>.
Felix Röthenbacher wrote:
> andreas@apache.org wrote:
> 
>> Author: andreas
>> Date: Wed Apr 13 00:55:09 2005
>> New Revision: 161163
>>
>> URL: http://svn.apache.org/viewcvs?view=rev&rev=161163
>> Log:
>> SiteTreeGenerator: use XML namespace for xml:lang attribute, this 
>> fixes the display of non-default languages. Thanks to Josias Thoeny.
>>
> 
> Thanks for fixing that. Then you may also want to remove the TODO on
> line 72 because it is properly handled now.

Done.

-- Andreas


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org

Re: svn commit: r161163 - lenya/branches/BRANCH_1_2_X/src/java/org/apache/lenya/cms/cocoon/generation/SiteTreeGenerator.java

Posted by Felix Röthenbacher <fe...@wyona.com>.
andreas@apache.org wrote:
> Author: andreas
> Date: Wed Apr 13 00:55:09 2005
> New Revision: 161163
> 
> URL: http://svn.apache.org/viewcvs?view=rev&rev=161163
> Log:
> SiteTreeGenerator: use XML namespace for xml:lang attribute, this fixes the display of non-default languages. Thanks to Josias Thoeny.
> 

Thanks for fixing that. Then you may also want to remove the TODO on
line 72 because it is properly handled now.

Thanks

Felix

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org