You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lianetm (via GitHub)" <gi...@apache.org> on 2026/03/20 14:00:00 UTC
[PR] MINOR: mark flaky test [kafka]
lianetm opened a new pull request, #21836:
URL: https://github.com/apache/kafka/pull/21836
Pretty flaky on trunk lately, showing up on unrelated client PRs
Tracked to fix with https://issues.apache.org/jira/browse/KAFKA-20345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: mark flaky test [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #21836:
URL: https://github.com/apache/kafka/pull/21836#issuecomment-4131214308
Fixes #21770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: mark flaky test [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 closed pull request #21836: MINOR: mark flaky test
URL: https://github.com/apache/kafka/pull/21836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: mark flaky test [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #21836:
URL: https://github.com/apache/kafka/pull/21836#issuecomment-4098158057
cc. @squah-confluent just for awareness (or in case you may have thoughts to share on the jira on how to fix). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: mark flaky test [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #21836:
URL: https://github.com/apache/kafka/pull/21836#issuecomment-4102344570
The root cause is that the completion of the `Runnable` does not mean `recordBackgroundProcessingTime` has finished. We should add `verify(metrics, timeout(5000)).recordBackgroundProcessingTime` to ensure the metric is actually recorded
```java
// Task 1 takes 100 ms.
mockTime.sleep(100);
task1Unblocked.countDown();
task1.get(5, TimeUnit.SECONDS);
verify(metrics, timeout(5000)).recordBackgroundProcessingTime(100);
// Task 3 starts.
task3Started.await();
// Task 2 takes 500 ms.
mockTime.sleep(400);
task2Unblocked.countDown();
task2.get(5, TimeUnit.SECONDS);
verify(metrics, timeout(5000)).recordBackgroundProcessingTime(500);
// Task 3 takes 500 ms.
mockTime.sleep(100);
task3Unblocked.countDown();
task3.get(5, TimeUnit.SECONDS);
verify(metrics, timeout(5000).times(2)).recordBackgroundProcessingTime(500);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org