You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by "Nicko Cadell (JIRA)" <ji...@apache.org> on 2005/04/03 19:54:16 UTC

[jira] Created: (LOG4NET-21) RemotingAppender failes once NDC becomes empty

RemotingAppender failes once NDC becomes empty
----------------------------------------------

         Key: LOG4NET-21
         URL: http://issues.apache.org/jira/browse/LOG4NET-21
     Project: Log4net
        Type: Bug
  Components: Core  
    Versions: 1.2.9    
    Reporter: Nicko Cadell
 Assigned to: Nicko Cadell 
    Priority: Critical


If an NDC, or any form of Context.Stack, is set on the current thread and then becomes empty the RemotingAppender will fail. This is caused by the LoggingEvent Properties failing to serialise due to an unexpected null value in the properties map.

The issue is caused by the GetObjectData method of log4net.Util.ReadOnlyPropertiesDictionary not coping with null values.

Issue reported by Sam Smoot.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[jira] Updated: (LOG4NET-21) RemotingAppender fails once NDC becomes empty

Posted by "Nicko Cadell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LOG4NET-21?page=all ]

Nicko Cadell updated LOG4NET-21:
--------------------------------

        Summary: RemotingAppender fails once NDC becomes empty  (was: RemotingAppender failes once NDC becomes empty)
    Description: 
If an NDC, or any form of Context.Stack, is set on the current thread and then becomes empty the RemotingAppender will fail. This is caused by the LoggingEvent Properties failing to serialise due to an unexpected null value in the properties map.

The issue is caused by the GetObjectData method of log4net.Util.ReadOnlyPropertiesDictionary not coping with null values.

Issue reported by Sam Smoot.

  was:
If an NDC, or any form of Context.Stack, is set on the current thread and then becomes empty the RemotingAppender will fail. This is caused by the LoggingEvent Properties failing to serialise due to an unexpected null value in the properties map.

The issue is caused by the GetObjectData method of log4net.Util.ReadOnlyPropertiesDictionary not coping with null values.

Issue reported by Sam Smoot.

    Environment: 

> RemotingAppender fails once NDC becomes empty
> ---------------------------------------------
>
>          Key: LOG4NET-21
>          URL: http://issues.apache.org/jira/browse/LOG4NET-21
>      Project: Log4net
>         Type: Bug
>   Components: Core
>     Versions: 1.2.9
>     Reporter: Nicko Cadell
>     Assignee: Nicko Cadell
>     Priority: Critical
>      Fix For: 1.2.10

>
> If an NDC, or any form of Context.Stack, is set on the current thread and then becomes empty the RemotingAppender will fail. This is caused by the LoggingEvent Properties failing to serialise due to an unexpected null value in the properties map.
> The issue is caused by the GetObjectData method of log4net.Util.ReadOnlyPropertiesDictionary not coping with null values.
> Issue reported by Sam Smoot.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Resolved: (LOG4NET-21) RemotingAppender failes once NDC becomes empty

Posted by "Nicko Cadell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LOG4NET-21?page=history ]
     
Nicko Cadell resolved LOG4NET-21:
---------------------------------

     Resolution: Fixed
    Fix Version: 1.2.10

Fixed by not serialising key-value pairs from the LoggingEvent Properties if the key or value is null.

> RemotingAppender failes once NDC becomes empty
> ----------------------------------------------
>
>          Key: LOG4NET-21
>          URL: http://issues.apache.org/jira/browse/LOG4NET-21
>      Project: Log4net
>         Type: Bug
>   Components: Core
>     Versions: 1.2.9
>     Reporter: Nicko Cadell
>     Assignee: Nicko Cadell
>     Priority: Critical
>      Fix For: 1.2.10

>
> If an NDC, or any form of Context.Stack, is set on the current thread and then becomes empty the RemotingAppender will fail. This is caused by the LoggingEvent Properties failing to serialise due to an unexpected null value in the properties map.
> The issue is caused by the GetObjectData method of log4net.Util.ReadOnlyPropertiesDictionary not coping with null values.
> Issue reported by Sam Smoot.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[jira] Commented: (LOG4NET-21) RemotingAppender failes once NDC becomes empty

Posted by "Nicko Cadell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LOG4NET-21?page=comments#action_62050 ]
     
Nicko Cadell commented on LOG4NET-21:
-------------------------------------

The ReadOnlyPropertiesDictionary should not serialise key-value pairs with a null key or value.

Null values properties should be stripped from the LoggingEvent composite properties (after allowing for overriding).

> RemotingAppender failes once NDC becomes empty
> ----------------------------------------------
>
>          Key: LOG4NET-21
>          URL: http://issues.apache.org/jira/browse/LOG4NET-21
>      Project: Log4net
>         Type: Bug
>   Components: Core
>     Versions: 1.2.9
>     Reporter: Nicko Cadell
>     Assignee: Nicko Cadell
>     Priority: Critical

>
> If an NDC, or any form of Context.Stack, is set on the current thread and then becomes empty the RemotingAppender will fail. This is caused by the LoggingEvent Properties failing to serialise due to an unexpected null value in the properties map.
> The issue is caused by the GetObjectData method of log4net.Util.ReadOnlyPropertiesDictionary not coping with null values.
> Issue reported by Sam Smoot.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira