You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Michael Dürig <md...@apache.org> on 2015/11/24 10:05:25 UTC
Re: svn commit: r1715773 [1/2] - in /jackrabbit/oak/trunk: oak-core/
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/
oak-core/src/main/java/org/apache/jackrabbit/oak/spi/whiteboard/
oak-core/src/main/java/org/apache/jackrabbit/oak/stats/ o...
Hi,
On 23.11.15 12:44 , chetanm@apache.org wrote:
> public AtomicLong getCounter(Type type) {
> - return repoStats.getCounter(type);
> + throw new UnsupportedOperationException();
> }
I'd rather remove the method and break backward compatibility at compile
time instead of runtime.
Michael
Re: svn commit: r1715773 [1/2] - in /jackrabbit/oak/trunk: oak-core/
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/
oak-core/src/main/java/org/apache/jackrabbit/oak/spi/whiteboard/
oak-core/src/main/java/org/apache/jackrabbit/oak/stats/ o...
Posted by Chetan Mehrotra <ch...@gmail.com>.
Removed the method with 1716101
Chetan Mehrotra
On Tue, Nov 24, 2015 at 2:45 PM, Michael Dürig <md...@apache.org> wrote:
>
>
> On 24.11.15 10:09 , Chetan Mehrotra wrote:
>>
>> On Tue, Nov 24, 2015 at 2:35 PM, Michael Dürig <md...@apache.org> wrote:
>>>
>>> I'd rather remove the method and break backward compatibility at compile
>>> time instead of runtime.
>>
>>
>> Can do that but then would need to bump the major version of the stats
>> package. Would that be fine?
>
>
> I'd say yes, even when leaving the method in. While the signature stays
> backward compatible, the semantic is quite different.
>
>>
>> I missed marking this one as deprecated so would that needs to be done.
>
>
> @deprecate would be an alternative. But then I'd just log a warning should
> the method be called instead of throwing.
>
> Michael
Re: svn commit: r1715773 [1/2] - in /jackrabbit/oak/trunk: oak-core/
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/
oak-core/src/main/java/org/apache/jackrabbit/oak/spi/whiteboard/
oak-core/src/main/java/org/apache/jackrabbit/oak/stats/ o...
Posted by Michael Dürig <md...@apache.org>.
On 24.11.15 10:09 , Chetan Mehrotra wrote:
> On Tue, Nov 24, 2015 at 2:35 PM, Michael Dürig <md...@apache.org> wrote:
>> I'd rather remove the method and break backward compatibility at compile
>> time instead of runtime.
>
> Can do that but then would need to bump the major version of the stats
> package. Would that be fine?
I'd say yes, even when leaving the method in. While the signature stays
backward compatible, the semantic is quite different.
>
> I missed marking this one as deprecated so would that needs to be done.
@deprecate would be an alternative. But then I'd just log a warning
should the method be called instead of throwing.
Michael
Re: svn commit: r1715773 [1/2] - in /jackrabbit/oak/trunk: oak-core/
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/metric/
oak-core/src/main/java/org/apache/jackrabbit/oak/spi/whiteboard/
oak-core/src/main/java/org/apache/jackrabbit/oak/stats/ o...
Posted by Chetan Mehrotra <ch...@gmail.com>.
On Tue, Nov 24, 2015 at 2:35 PM, Michael Dürig <md...@apache.org> wrote:
> I'd rather remove the method and break backward compatibility at compile
> time instead of runtime.
Can do that but then would need to bump the major version of the stats
package. Would that be fine?
I missed marking this one as deprecated so would that needs to be done.
Chetan Mehrotra