You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/06 03:47:21 UTC
[GitHub] [maven-dependency-plugin] antoniolucasnobar opened a new pull request, #258: [MDEP-568] fix APIs method names and other requests from elharo in #135
antoniolucasnobar opened a new pull request, #258:
URL: https://github.com/apache/maven-dependency-plugin/pull/258
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] antoniolucasnobar commented on pull request #258: [MDEP-568] fix APIs method names and other requests from elharo in #135
Posted by GitBox <gi...@apache.org>.
antoniolucasnobar commented on PR #258:
URL: https://github.com/apache/maven-dependency-plugin/pull/258#issuecomment-1304775657
@slachiewicz do you really want me to do a rebase? After what @pzygielo said?
@pzygielo do you want me to create two PRs? one only with my commits and one with merge with master? Is that it?
In the merge I had to resolve simple conflicts in one file.
Thanks in advance for your help and guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] antoniolucasnobar commented on pull request #258: [MDEP-568] fix APIs method names and other requests from elharo in #135
Posted by GitBox <gi...@apache.org>.
antoniolucasnobar commented on PR #258:
URL: https://github.com/apache/maven-dependency-plugin/pull/258#issuecomment-1305713272
@slachiewicz I pushed only my commits to this branch, but I do not see how can I reopen this PR. Can you please tell me how can I reopen this PR or else what should I do?
Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] antoniolucasnobar commented on pull request #258: [MDEP-568] fix APIs method names and other requests from elharo in #135
Posted by GitBox <gi...@apache.org>.
antoniolucasnobar commented on PR #258:
URL: https://github.com/apache/maven-dependency-plugin/pull/258#issuecomment-1305750839
I rebased my branch with master. But I still can not reopen this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slachiewicz commented on pull request #258: [MDEP-568] fix APIs method names and other requests from elharo in #135
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #258:
URL: https://github.com/apache/maven-dependency-plugin/pull/258#issuecomment-1304752908
Please rebase on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] pzygielo commented on pull request #258: [MDEP-568] fix APIs method names and other requests from elharo in #135
Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #258:
URL: https://github.com/apache/maven-dependency-plugin/pull/258#issuecomment-1304754356
> Please rebase on master
Not sure how this would help, as this PR aims to merge all 100+ commits present in master to `MDEP-568_go-offline_filter` branch that is waaay behind master.
I think that 3a06622 (merge master) should rather be dropped. It would leave this PR with only ~6 new commits to target base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] antoniolucasnobar closed pull request #258: [MDEP-568] fix APIs method names and other requests from elharo in #135
Posted by GitBox <gi...@apache.org>.
antoniolucasnobar closed pull request #258: [MDEP-568] fix APIs method names and other requests from elharo in #135
URL: https://github.com/apache/maven-dependency-plugin/pull/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org