You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2020/06/10 10:50:30 UTC

[incubator-echarts] branch label-enhancement updated: fix(sunburst): fix sunburst animation

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch label-enhancement
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/label-enhancement by this push:
     new 9185991  fix(sunburst): fix sunburst animation
9185991 is described below

commit 918599159ff7e5e5ce6d6e9d86cba9e0f875c44f
Author: pissang <bm...@gmail.com>
AuthorDate: Wed Jun 10 18:49:48 2020 +0800

    fix(sunburst): fix sunburst animation
---
 src/chart/sunburst/SunburstPiece.ts | 12 +++++++-----
 src/component/helper/roamHelper.ts  |  4 ++--
 test/pie-label.html                 |  1 -
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/chart/sunburst/SunburstPiece.ts b/src/chart/sunburst/SunburstPiece.ts
index 0334111..b2c0a14 100644
--- a/src/chart/sunburst/SunburstPiece.ts
+++ b/src/chart/sunburst/SunburstPiece.ts
@@ -130,12 +130,14 @@ class SunburstPiece extends graphic.Sector {
                 node.dataIndex
             );
         }
+        else {
+            // Disable animation for gradient since no interpolation method
+            // is supported for gradient
+            graphic.updateProps(sector, {
+                shape: sectorShape
+            }, seriesModel);
+        }
 
-        // Disable animation for gradient since no interpolation method
-        // is supported for gradient
-        graphic.updateProps(sector, {
-            shape: sectorShape
-        }, seriesModel);
         sector.useStyle(normalStyle);
 
         this._updateLabel(seriesModel);
diff --git a/src/component/helper/roamHelper.ts b/src/component/helper/roamHelper.ts
index 810138f..27b2332 100644
--- a/src/component/helper/roamHelper.ts
+++ b/src/component/helper/roamHelper.ts
@@ -21,8 +21,8 @@ import Element from 'zrender/src/Element';
 
 interface ControllerHost {
     target: Element,
-    zoom: number
-    zoomLimit: {min: number, max: number}
+    zoom?: number
+    zoomLimit?: {min: number, max: number}
 }
 
 /**
diff --git a/test/pie-label.html b/test/pie-label.html
index ec6a077..0e8fa78 100644
--- a/test/pie-label.html
+++ b/test/pie-label.html
@@ -627,7 +627,6 @@ under the License.
                     },
                     series: [{
                         type: 'pie',
-                        radius: '50%',
                         data: data,
                         roseType: 'radius',
                         radius: ['30%', '70%'],


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org