You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by rb...@covalent.net on 2000/06/13 02:03:49 UTC
The new proxy code.
All of the new proxy code is broken, and will not compile cleanly. To
make it even worse, the code is undocumented, it doesn't use APR, and the
formatting is REALLY bad. There is pretty much no whitespace in between
functions, and no indenting. Now, I know we don't all like the style
guide, but at least it keeps the code readable.
Also, all of this code was dumped into CVS and it all defaults to on. I
am trying right now to make this all compile. Then I will try to fix the
formatting to fit the style guide. Finally, I also plan to make the
default for all of this to be off.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: The new proxy code.
Posted by Chuck Murcko <ch...@topsail.org>.
rbb@covalent.net wrote:
>
> All of the new proxy code is broken, and will not compile cleanly. To
> make it even worse, the code is undocumented, it doesn't use APR, and the
> formatting is REALLY bad. There is pretty much no whitespace in between
> functions, and no indenting. Now, I know we don't all like the style
> guide, but at least it keeps the code readable.
>
It's compiling cleanly here now, except for unused vars, which will go
away once I know they're not coming back into the code. I'll commit this
ASAP.
The idea is to convert it to APR, document and clean up. Things are
changing so fast in the Apache interfaces that I wanted to get it in and
working basically as is before doing that, since it'll be breaking
repeatedly as the rest of the code base changes.
The rest of the style cleanup will go in tonight, as well.
> Also, all of this code was dumped into CVS and it all defaults to on. I
> am trying right now to make this all compile. Then I will try to fix the
> formatting to fit the style guide. Finally, I also plan to make the
> default for all of this to be off.
>
Actually, I'm doing the same thing right now. I'm committing fix/cleanup
patches tonight which will fit the style guide and autoconf better.
--
Chuck
Chuck Murcko
Topsail Group
chuck@topsail.org