You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Kelvin Bell (JIRA)" <ji...@apache.org> on 2010/06/22 19:56:55 UTC

[jira] Created: (PIVOT-538) Table is uneditable when opened modally

Table is uneditable when opened modally
---------------------------------------

                 Key: PIVOT-538
                 URL: https://issues.apache.org/jira/browse/PIVOT-538
             Project: Pivot
          Issue Type: Bug
          Components: wtk
            Reporter: Kelvin Bell
             Fix For: 1.5.1


Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PIVOT-538) Table is uneditable when opened modally

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Brown resolved PIVOT-538.
------------------------------

    Resolution: Not A Problem

OK, great. Since you have it working now, I'm going to resolve this as not a problem.


> Table is uneditable when opened modally
> ---------------------------------------
>
>                 Key: PIVOT-538
>                 URL: https://issues.apache.org/jira/browse/PIVOT-538
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>            Reporter: Kelvin Bell
>             Fix For: 1.5.1
>
>         Attachments: pivotmodaltest.zip, Working-pivotmodaltest.zip
>
>
> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIVOT-538) Table is uneditable when opened modally

Posted by "Kelvin Bell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kelvin Bell updated PIVOT-538:
------------------------------

    Attachment: Working-pivotmodaltest.zip

Good stuff!!!  Thank you for the insight!

I posted a working program that enables the user to edit the table rows and use the buttons while the Dialog is modal.

> Table is uneditable when opened modally
> ---------------------------------------
>
>                 Key: PIVOT-538
>                 URL: https://issues.apache.org/jira/browse/PIVOT-538
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>            Reporter: Kelvin Bell
>             Fix For: 1.5.1
>
>         Attachments: pivotmodaltest.zip, Working-pivotmodaltest.zip
>
>
> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIVOT-538) Table is uneditable when opened modally

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881371#action_12881371 ] 

Greg Brown commented on PIVOT-538:
----------------------------------

Thanks for the additional information. Would it be possible to provide a complete (i.e. self-contained) example that we could use for testing purposes?


> Table is uneditable when opened modally
> ---------------------------------------
>
>                 Key: PIVOT-538
>                 URL: https://issues.apache.org/jira/browse/PIVOT-538
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>            Reporter: Kelvin Bell
>             Fix For: 1.5.1
>
>
> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (PIVOT-538) Table is uneditable when opened modally

Posted by "Kelvin Bell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882016#action_12882016 ] 

Kelvin Bell edited comment on PIVOT-538 at 6/23/10 10:59 PM:
-------------------------------------------------------------

Good stuff!!!  Thank you for the insight!

I posted working program files which enable the users to edit the table rows and use the buttons while the Dialog is modal.

      was (Author: junyabell):
    Good stuff!!!  Thank you for the insight!

I posted a working program that enables the user to edit the table rows and use the buttons while the Dialog is modal.
  
> Table is uneditable when opened modally
> ---------------------------------------
>
>                 Key: PIVOT-538
>                 URL: https://issues.apache.org/jira/browse/PIVOT-538
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>            Reporter: Kelvin Bell
>             Fix For: 1.5.1
>
>         Attachments: pivotmodaltest.zip, Working-pivotmodaltest.zip
>
>
> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIVOT-538) Table is uneditable when opened modally

Posted by "Kelvin Bell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kelvin Bell updated PIVOT-538:
------------------------------

    Attachment: pivotmodaltest.zip

I created the Java and WTKX files using NetBeans.

When you run the program, the BillingForm Frame should be run first (PatientDataTable is a Dialog).

When the BillingForm Frame opens, click on the "View or Update Patient Information" link button.  This button opens up the PatientDataTable Dialog.

Although the Table is set for row editing, the rows are not editable while the form is modal.  Even if I convert it to a Frame or Sheet, the Table is not editable while it is modal.  If I convert it to a Frame and open it as its own owner, then the table rows are editable.

Also, the "Done" link button on the PatientDataTable Dialog doesn't close the Dialog.  If I create the "Done" code in javascript in the wtkx file, it closes the program fine.  Or if I run the program as a Frame, then "Done" closes the program.  But the "Done" link button has no effect while the form is modal.

> Table is uneditable when opened modally
> ---------------------------------------
>
>                 Key: PIVOT-538
>                 URL: https://issues.apache.org/jira/browse/PIVOT-538
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>            Reporter: Kelvin Bell
>             Fix For: 1.5.1
>
>         Attachments: pivotmodaltest.zip
>
>
> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIVOT-538) Table is uneditable when opened modally

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Brown updated PIVOT-538:
-----------------------------

    Fix Version/s:     (was: 1.5.1)

> Table is uneditable when opened modally
> ---------------------------------------
>
>                 Key: PIVOT-538
>                 URL: https://issues.apache.org/jira/browse/PIVOT-538
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>            Reporter: Kelvin Bell
>         Attachments: pivotmodaltest.zip, Working-pivotmodaltest.zip
>
>
> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIVOT-538) Table is uneditable when opened modally

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881327#action_12881327 ] 

Greg Brown commented on PIVOT-538:
----------------------------------

Can you provide a code sample that can be used to reproduce this issue?


> Table is uneditable when opened modally
> ---------------------------------------
>
>                 Key: PIVOT-538
>                 URL: https://issues.apache.org/jira/browse/PIVOT-538
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>            Reporter: Kelvin Bell
>             Fix For: 1.5.1
>
>
> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIVOT-538) Table is uneditable when opened modally

Posted by "Kelvin Bell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881336#action_12881336 ] 

Kelvin Bell commented on PIVOT-538:
-----------------------------------

I'm working on an immunization/flu program.  Here is the part of the program that opens the Sheet with the table data, but the table is not editable.

public class ClinicDataForm implements Application {
    private Display display = null;
    private Frame frame = null;
    private Sheet sheet = null;
    private TableView tableNurseInformation = null;
    private LinkButton buttonImmWellInfo = null;

    @Override
    public void startup(final Display display, Map<String, String> properties) throws Exception {
        this.display = display;

        WTKXSerializer wtkxSerializer = new WTKXSerializer();
        WTKXSerializer wtkxSerializer2 = new WTKXSerializer();

        frame = (Frame)wtkxSerializer.readObject(ClinicDataForm.this, "clinicData.wtkx");
        sheet = (Sheet)wtkxSerializer2.readObject(ImmunizationAndWellnessTable.class, "immunizationAndWellnessTable.wtkx");
        frame.open(display);
        
        buttonImmWellInfo = (LinkButton)wtkxSerializer.get("buttonImmWellInfo");
        buttonImmWellInfo.getButtonPressListeners().add(new ButtonPressListener() {
            @Override
            public void buttonPressed(Button button) {
                try {
                    sheet.open(display);
                }
                catch (Exception ex) {
                    Logger.getLogger(ImmunizationAndWellnessTable.class.getName()).log(Level.SEVERE, null, ex);
                }
            }
        });
....

> Table is uneditable when opened modally
> ---------------------------------------
>
>                 Key: PIVOT-538
>                 URL: https://issues.apache.org/jira/browse/PIVOT-538
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>            Reporter: Kelvin Bell
>             Fix For: 1.5.1
>
>
> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIVOT-538) Table is uneditable when opened modally

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881720#action_12881720 ] 

Greg Brown commented on PIVOT-538:
----------------------------------

Part of the problem may be your use of multiple applications. The startup() method of PatientDataTable isn't being executed when you launch BillingForm, so the event listeners are not registered.

I would suggest some minor tweaks that may make it easier for you to organize and manage your code:

- Rename BillingForm to BillingFrame. Have it extend org.apache.pivot.wtk.Frame and implement org.apache.pivot.wtkx.Bindable. Don't implement Application. In Bindable#initialize(), you can load the dialog's WTKX file and save it as a member of BillingFrame. You can also wire up the event listener that opens the dialog here.

- Rename billing.wtkx to billing_frame.wtkx. Make the root element <myapp:BillingFrame> rather than <Frame>.

- Rename PatientDataTable to PatientDataDialog and have it extend Dialog and implement Bindable. Don't implement Application. In Bindable#initialize(), you can wire up the table editor and the event listener that closes the dialog.

- Rename patientDataTable.wtkx to patient_data_dialog.wtkx and make the root element <myapp:PatientDataDialog> rather than <Dialog>.

- Create a new BillingApplication class that implements Application. Keep the code there that loads and opens the billing frame, but remove the code that loads and opens the dialog, since that now lives in BillingFrame.

Once you have made these changes, I suspect that you will be able to close the dialog and invoke the editor. Let me know if you have any questions.



> Table is uneditable when opened modally
> ---------------------------------------
>
>                 Key: PIVOT-538
>                 URL: https://issues.apache.org/jira/browse/PIVOT-538
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>            Reporter: Kelvin Bell
>             Fix For: 1.5.1
>
>         Attachments: pivotmodaltest.zip
>
>
> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (PIVOT-538) Table is uneditable when opened modally

Posted by Greg Brown <gk...@mac.com>.
What happens when you run this example?

  http://pivot.apache.org/tutorials/windows.html

Can you close the dialog and the alert by pressing the Close or OK button?

Also, what Pivot version are you currently using? It isn't specified in the JIRA ticket.

Thanks,
Greg

On Jun 22, 2010, at 4:35 PM, Kelvin Bell (JIRA) wrote:

> 
>    [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881345#action_12881345 ] 
> 
> Kelvin Bell commented on PIVOT-538:
> -----------------------------------
> 
> While playing around with this more, the issue may not be limited to Tables being uneditable.  It appears that buttons (PushButtons and LinkButtons as I have tried) have no effect while the Frame is modal.  When the Frame is not opened modally, the buttons work as they should.
> 
>> Table is uneditable when opened modally
>> ---------------------------------------
>> 
>>                Key: PIVOT-538
>>                URL: https://issues.apache.org/jira/browse/PIVOT-538
>>            Project: Pivot
>>         Issue Type: Bug
>>         Components: wtk
>>           Reporter: Kelvin Bell
>>            Fix For: 1.5.1
>> 
>> 
>> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.
> 
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
> 


[jira] Commented: (PIVOT-538) Table is uneditable when opened modally

Posted by "Kelvin Bell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881345#action_12881345 ] 

Kelvin Bell commented on PIVOT-538:
-----------------------------------

While playing around with this more, the issue may not be limited to Tables being uneditable.  It appears that buttons (PushButtons and LinkButtons as I have tried) have no effect while the Frame is modal.  When the Frame is not opened modally, the buttons work as they should.

> Table is uneditable when opened modally
> ---------------------------------------
>
>                 Key: PIVOT-538
>                 URL: https://issues.apache.org/jira/browse/PIVOT-538
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>            Reporter: Kelvin Bell
>             Fix For: 1.5.1
>
>
> Tables that are in a modal Frame/Dialog/Sheet have rows which are not editable (TableViewRowEditor & setRowEditor become useless).  If the Frame (exact same code) is opened non-modally, then the tables are editable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.