You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/24 23:46:31 UTC

[GitHub] [spark] maropu commented on a change in pull request #28003: [SPARK-31234][SQL] ResetCommand should reset config to sc.conf only

maropu commented on a change in pull request #28003: [SPARK-31234][SQL] ResetCommand should reset config to sc.conf only
URL: https://github.com/apache/spark/pull/28003#discussion_r397528822
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala
 ##########
 @@ -170,7 +170,11 @@ object SetCommand {
 case object ResetCommand extends RunnableCommand with IgnoreCachedData {
 
   override def run(sparkSession: SparkSession): Seq[Row] = {
-    sparkSession.sessionState.conf.clear()
 
 Review comment:
   Could you update [the comment](https://github.com/apache/spark/pull/28003/files) for the new behaivour?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org