You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Stanton Sievers <si...@gmail.com> on 2013/03/12 02:13:33 UTC

Review Request: The Sample Archetype should have the most recent Shindig dependencies

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9859/
-----------------------------------------------------------

Review request for shindig.


Description
-------

>From JIRA:
The current sample-maven-archetype that is packaged with shindig includes a static string in the archetype pom to reference the shindig version to use.  This should be dynamic.


This addresses bug SHINDIG-1913.
    https://issues.apache.org/jira/browse/SHINDIG-1913


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/sample-maven-archetype/pom.xml 1455369 
  http://svn.apache.org/repos/asf/shindig/trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/pom.xml 1455370 

Diff: https://reviews.apache.org/r/9859/diff/


Testing
-------

Built the archetype and verified that the dependency versions matched the version of Shindig in my local maven repository.


Thanks,

Stanton Sievers

Re: Review Request: The Sample Archetype should have the most recent Shindig dependencies

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9859/#review17709
-----------------------------------------------------------

Ship it!


Ship It!

- Ryan Baxter


On March 12, 2013, 1:13 a.m., Stanton Sievers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9859/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 1:13 a.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> From JIRA:
> The current sample-maven-archetype that is packaged with shindig includes a static string in the archetype pom to reference the shindig version to use.  This should be dynamic.
> 
> 
> This addresses bug SHINDIG-1913.
>     https://issues.apache.org/jira/browse/SHINDIG-1913
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/sample-maven-archetype/pom.xml 1455369 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/pom.xml 1455370 
> 
> Diff: https://reviews.apache.org/r/9859/diff/
> 
> 
> Testing
> -------
> 
> Built the archetype and verified that the dependency versions matched the version of Shindig in my local maven repository.
> 
> 
> Thanks,
> 
> Stanton Sievers
> 
>

Re: Review Request: The Sample Archetype should have the most recent Shindig dependencies

Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9859/#review17710
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Franklin


On March 12, 2013, 1:13 a.m., Stanton Sievers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9859/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 1:13 a.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> From JIRA:
> The current sample-maven-archetype that is packaged with shindig includes a static string in the archetype pom to reference the shindig version to use.  This should be dynamic.
> 
> 
> This addresses bug SHINDIG-1913.
>     https://issues.apache.org/jira/browse/SHINDIG-1913
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/sample-maven-archetype/pom.xml 1455369 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/pom.xml 1455370 
> 
> Diff: https://reviews.apache.org/r/9859/diff/
> 
> 
> Testing
> -------
> 
> Built the archetype and verified that the dependency versions matched the version of Shindig in my local maven repository.
> 
> 
> Thanks,
> 
> Stanton Sievers
> 
>

Re: Review Request: The Sample Archetype should have the most recent Shindig dependencies

Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9859/#review17758
-----------------------------------------------------------

Ship it!


Committed revision 1455719

- Stanton Sievers


On March 12, 2013, 1:13 a.m., Stanton Sievers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9859/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 1:13 a.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> From JIRA:
> The current sample-maven-archetype that is packaged with shindig includes a static string in the archetype pom to reference the shindig version to use.  This should be dynamic.
> 
> 
> This addresses bug SHINDIG-1913.
>     https://issues.apache.org/jira/browse/SHINDIG-1913
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/sample-maven-archetype/pom.xml 1455369 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/pom.xml 1455370 
> 
> Diff: https://reviews.apache.org/r/9859/diff/
> 
> 
> Testing
> -------
> 
> Built the archetype and verified that the dependency versions matched the version of Shindig in my local maven repository.
> 
> 
> Thanks,
> 
> Stanton Sievers
> 
>