You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/07 07:51:37 UTC

[GitHub] [arrow] Jedi18 commented on a change in pull request #11858: ARROW-14737: [C++][Dataset] Support URI-decoding partition keys

Jedi18 commented on a change in pull request #11858:
URL: https://github.com/apache/arrow/pull/11858#discussion_r763717896



##########
File path: cpp/src/arrow/dataset/partition.h
##########
@@ -106,6 +106,8 @@ struct ARROW_DS_EXPORT KeyValuePartitioningOptions {
   /// After splitting a path into components, decode the path components
   /// before parsing according to this scheme.
   SegmentEncoding segment_encoding = SegmentEncoding::Uri;
+  // Should the key be decoded according to the scheme above too
+  bool decode_key = false;

Review comment:
       Should I default decode_key to true or remove it entirely so that the key is always decoded?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org