[GitHub] [incubator-pinot] chenboat edited a comment on pull request #6567: Enable adding new segments to a upsert-enabled realtime table

[GitBox <gi...@apache.org>]

chenboat edited a comment on pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#issuecomment-807806592


   > For the new integration test, it would be good if we push some events into kafka as well and make the commit threshold low so that we have CONSUMING, DONE, UPLOADED segments at the same time. Also, we can run the `RealtimeSegmentValidationManager` and see if it handles UPLOADED segments properly
   
   Added the Kafka data ingestion to the integration test. Also add more segments (now 2 realtime segments and 3 uploaded segments are involved in the tests). Discovered a bug in the previous version.
   
   Revised the integration test so that it runs the `RealtimeSegmentValidationManager` every 1 second and verifies the query results and idealstate are still valid. @Jackie-Jiang 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org