You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2018/08/08 17:58:59 UTC

[GitHub] carbondata pull request #2622: [HOTFIX] Fixed Query performance issue

GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/2622

    [HOTFIX] Fixed Query performance issue

    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata queryperf

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2622
    
----
commit 551fe868f941f1dffa50e6fe296cf2c491910b1a
Author: kumarvishal09 <ku...@...>
Date:   2018-08-08T17:55:41Z

    Fixed Query performance issue

----


---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6216/



---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7860/



---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6224/



---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6217/



---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7855/



---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6225/



---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6570/



---

[GitHub] carbondata pull request #2622: [HOTFIX] Fixed Query performance issue

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2622#discussion_r208861218
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -463,9 +463,10 @@ class CarbonScanRDD[T: ClassTag](
           model.setStatisticsRecorder(recorder)
     
           // TODO: rewrite this logic to call free memory in FailureListener on failures. On success,
    -      // no memory leak should be there, resources should be freed on success completion.
    -      val listeners = CarbonReflectionUtils.getField("onCompleteCallbacks", context)
    +      // TODO: no memory leak should be there, resources should be freed on success completion.
    +      val listeners = CarbonReflectionUtils.getField("onCompleteCallbacks", context).get(context)
    --- End diff --
    
    Move `get(context)` to method 


---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    retest this please


---

[GitHub] carbondata pull request #2622: [HOTFIX] Fixed Query performance issue

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2622#discussion_r208686198
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -463,9 +463,12 @@ class CarbonScanRDD[T: ClassTag](
           model.setStatisticsRecorder(recorder)
     
           // TODO: rewrite this logic to call free memory in FailureListener on failures. On success,
    -      // no memory leak should be there, resources should be freed on success completion.
    -      val listeners = CarbonReflectionUtils.getField("onCompleteCallbacks", context)
    +      // TODO: no memory leak should be there, resources should be freed on success completion.
    +      val onCompleteCallbacksField = context.getClass.getDeclaredField("onCompleteCallbacks")
    +      onCompleteCallbacksField.setAccessible(true)
    --- End diff --
    
    Can you move this code to getField method of CarbonReflectionUtil, other callers gets advantage



---

[GitHub] carbondata pull request #2622: [HOTFIX] Fixed Query performance issue

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2622#discussion_r208839710
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -463,9 +463,12 @@ class CarbonScanRDD[T: ClassTag](
           model.setStatisticsRecorder(recorder)
     
           // TODO: rewrite this logic to call free memory in FailureListener on failures. On success,
    -      // no memory leak should be there, resources should be freed on success completion.
    -      val listeners = CarbonReflectionUtils.getField("onCompleteCallbacks", context)
    +      // TODO: no memory leak should be there, resources should be freed on success completion.
    +      val onCompleteCallbacksField = context.getClass.getDeclaredField("onCompleteCallbacks")
    +      onCompleteCallbacksField.setAccessible(true)
    --- End diff --
    
    ok


---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    @ravipesala Please review


---

[GitHub] carbondata pull request #2622: [HOTFIX] Fixed Query performance issue

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2622#discussion_r208865599
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala ---
    @@ -463,9 +463,10 @@ class CarbonScanRDD[T: ClassTag](
           model.setStatisticsRecorder(recorder)
     
           // TODO: rewrite this logic to call free memory in FailureListener on failures. On success,
    -      // no memory leak should be there, resources should be freed on success completion.
    -      val listeners = CarbonReflectionUtils.getField("onCompleteCallbacks", context)
    +      // TODO: no memory leak should be there, resources should be freed on success completion.
    +      val listeners = CarbonReflectionUtils.getField("onCompleteCallbacks", context).get(context)
    --- End diff --
    
    ok


---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    LGTM


---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7845/



---

[GitHub] carbondata pull request #2622: [HOTFIX] Fixed Query performance issue

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2622


---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7856/



---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    LGTM


---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6585/



---

[GitHub] carbondata issue #2622: [HOTFIX] Fixed Query performance issue

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2622
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6581/



---