[GitHub] [incubator-doris] imay commented on a change in pull request #3232: Rewrite count distinct bitmap and hll in order by and having

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #3232: Rewrite count distinct bitmap and hll in order by and having
URL: https://github.com/apache/incubator-doris/pull/3232#discussion_r401361127
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
 ##########
 @@ -262,6 +262,11 @@ public boolean isCountDistinctBitmapOrHLL() {
             return false;
         }
 
+        // if expr isn't analyzed, the type is INVALID
+        if (!getChild(0).isAnalyzed) {
+            getChild(0).analyzeNoThrow(analyzer);
 
 Review comment:
   I'm not sure if it is OK to analyze it here.
   Is it possible to call this function after analyzed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org