You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/29 09:45:35 UTC
[GitHub] [spark] dchvn opened a new pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
dchvn opened a new pull request #34438:
URL: https://github.com/apache/spark/pull/34438
### What changes were proposed in this pull request?
Inline type hints for python/pyspark/util.py
### Why are the changes needed?
We can take advantage of static type checking within the functions by inlining the type hints.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34438:
URL: https://github.com/apache/spark/pull/34438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-954689918
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49216/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-954624716
**[Test build #144747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144747/testReport)** for PR 34438 at commit [`ab40c5a`](https://github.com/apache/spark/commit/ab40c5a7858a8d8274450dd97a3f3def45d7f3c3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-954612987
CC @HyukjinKwon @zero323 @ueshin FYI. Many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-954660067
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144747/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-960529746
Ping @HyukjinKwon @zero323 Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-954695000
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49216/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34438:
URL: https://github.com/apache/spark/pull/34438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-954655092
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49216/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34438:
URL: https://github.com/apache/spark/pull/34438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-954695000
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49216/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-954624716
**[Test build #144747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144747/testReport)** for PR 34438 at commit [`ab40c5a`](https://github.com/apache/spark/commit/ab40c5a7858a8d8274450dd97a3f3def45d7f3c3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-954660067
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144747/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34438: [SPARK-37157][PYTHON] Inline type hints for python/pyspark/util.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34438:
URL: https://github.com/apache/spark/pull/34438#issuecomment-954642312
**[Test build #144747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144747/testReport)** for PR 34438 at commit [`ab40c5a`](https://github.com/apache/spark/commit/ab40c5a7858a8d8274450dd97a3f3def45d7f3c3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org