You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2009/07/22 00:03:14 UTC

[jira] Created: (MAPREDUCE-782) Use PureJavaCrc32 in mapreduce spills

Use PureJavaCrc32 in mapreduce spills
-------------------------------------

                 Key: MAPREDUCE-782
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-782
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon
            Priority: Minor


HADOOP-6148 implemented a Pure Java implementation of CRC32 which performs better than the built-in one. This issue is to make use of it in the mapred package

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-782) Use PureJavaCrc32 in mapreduce spills

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated MAPREDUCE-782:
----------------------------------

    Attachment: mapreduce-782.txt

> Use PureJavaCrc32 in mapreduce spills
> -------------------------------------
>
>                 Key: MAPREDUCE-782
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-782
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: mapreduce-782.txt
>
>
> HADOOP-6148 implemented a Pure Java implementation of CRC32 which performs better than the built-in one. This issue is to make use of it in the mapred package

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-782) Use PureJavaCrc32 in mapreduce spills

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735354#action_12735354 ] 

Todd Lipcon commented on MAPREDUCE-782:
---------------------------------------

Failing tests are old and unrelated

No new tests are required for this as the implementation was thoroughly tested by the patch in Common, and the code paths in which it is used are covered by existing tests.

> Use PureJavaCrc32 in mapreduce spills
> -------------------------------------
>
>                 Key: MAPREDUCE-782
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-782
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: mapreduce-782.txt
>
>
> HADOOP-6148 implemented a Pure Java implementation of CRC32 which performs better than the built-in one. This issue is to make use of it in the mapred package

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-782) Use PureJavaCrc32 in mapreduce spills

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated MAPREDUCE-782:
----------------------------------

    Status: Patch Available  (was: Open)

> Use PureJavaCrc32 in mapreduce spills
> -------------------------------------
>
>                 Key: MAPREDUCE-782
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-782
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: mapreduce-782.txt
>
>
> HADOOP-6148 implemented a Pure Java implementation of CRC32 which performs better than the built-in one. This issue is to make use of it in the mapred package

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-782) Use PureJavaCrc32 in mapreduce spills

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated MAPREDUCE-782:
---------------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
           Status: Resolved  (was: Patch Available)

I have committed this.  Thanks, Todd!

> Use PureJavaCrc32 in mapreduce spills
> -------------------------------------
>
>                 Key: MAPREDUCE-782
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-782
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: mapreduce-782.txt
>
>
> HADOOP-6148 implemented a Pure Java implementation of CRC32 which performs better than the built-in one. This issue is to make use of it in the mapred package

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-782) Use PureJavaCrc32 in mapreduce spills

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated MAPREDUCE-782:
---------------------------------------------

    Hadoop Flags: [Reviewed]

+1 patch looks good.

> Use PureJavaCrc32 in mapreduce spills
> -------------------------------------
>
>                 Key: MAPREDUCE-782
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-782
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: mapreduce-782.txt
>
>
> HADOOP-6148 implemented a Pure Java implementation of CRC32 which performs better than the built-in one. This issue is to make use of it in the mapred package

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-782) Use PureJavaCrc32 in mapreduce spills

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736119#action_12736119 ] 

Hudson commented on MAPREDUCE-782:
----------------------------------

Integrated in Hadoop-Mapreduce-trunk #32 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/32/])
    . Use PureJavaCrc32 in SpillRecord.  Contributed by Todd Lipcon


> Use PureJavaCrc32 in mapreduce spills
> -------------------------------------
>
>                 Key: MAPREDUCE-782
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-782
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: mapreduce-782.txt
>
>
> HADOOP-6148 implemented a Pure Java implementation of CRC32 which performs better than the built-in one. This issue is to make use of it in the mapred package

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-782) Use PureJavaCrc32 in mapreduce spills

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735352#action_12735352 ] 

Hadoop QA commented on MAPREDUCE-782:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12414149/mapreduce-782.txt
  against trunk revision 797362.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/420/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/420/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/420/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/420/console

This message is automatically generated.

> Use PureJavaCrc32 in mapreduce spills
> -------------------------------------
>
>                 Key: MAPREDUCE-782
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-782
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: mapreduce-782.txt
>
>
> HADOOP-6148 implemented a Pure Java implementation of CRC32 which performs better than the built-in one. This issue is to make use of it in the mapred package

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.