[GitHub] [groovy] paulk-asert commented on a change in pull request #938: Update tests for GROOVY-9043, GROOVY-9093, GROOVY-9106, et al.

[GitBox <gi...@apache.org>]

paulk-asert commented on a change in pull request #938: Update tests for GROOVY-9043, GROOVY-9093, GROOVY-9106, et al.
URL: https://github.com/apache/groovy/pull/938#discussion_r288273784
 
 

 ##########
 File path: src/test/org/codehaus/groovy/transform/packageScope/PackageScopeTransformTest.groovy
 ##########
 @@ -18,20 +18,22 @@
  */
 package org.codehaus.groovy.transform.packageScope
 
+import groovy.transform.CompileStatic
+
 import java.lang.reflect.Modifier
 
-class PackageScopeTransformTest extends GroovyShellTestCase {
+@CompileStatic
+final class PackageScopeTransformTest extends GroovyShellTestCase {
     // GROOVY-9043
-    void testPackagePrivateAccessFromInnerClassCS() {
-        assertScript '''
+    void testStaticFieldAccessFromInnerClassCS() {
+        assertScript('''\
 
 Review comment:
   The most common style within many of our tests is to avoid unnecessary characters like the open bracket (when not needed) and the backslash in this case. It no doubt affects the line count by one but hasn't seemed to worry anyone to date. Are there additional reasons why your style is to put them in from an Eclipse point of view? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services