You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Henning Schmiedehausen (JIRA)" <ji...@codehaus.org> on 2007/01/28 16:41:44 UTC

[jira] Created: (MCHANGES-67) The changes plugin should not hard code the "team-list.html" file

The changes plugin should not hard code the "team-list.html" file 
------------------------------------------------------------------

                 Key: MCHANGES-67
                 URL: http://jira.codehaus.org/browse/MCHANGES-67
             Project: Maven 2.x Changes Plugin
          Issue Type: Bug
    Affects Versions: 2.0-beta-2, 2.0
            Reporter: Henning Schmiedehausen
         Attachments: changes5.patch

Projects that do not have a team-list file or use a different file will have a number of broken links on the changes-plugin report page.

The attached patch makes the URL of the team-list file configurable with the default being the "team-list.html" file. This can be changed by setting the 

<configuration>
  <teamlist>foo.html</teamlist>
</configuration>

parameter. When this parameter is set to empty (e.g.

<configuration>
  <teamlist/>
</configuration>

then no link is generated and just the names are reported.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MCHANGES-67) The changes plugin should not hard code the "team-list.html" file

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCHANGES-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MCHANGES-67.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4
         Assignee: Dennis Lundberg

Patch applied with modifications in [r1050310|http://svn.apache.org/viewvc?view=revision&revision=1050310].
New 2.4-SNAPSHOT deployed.
Thanks!

> The changes plugin should not hard code the "team-list.html" file 
> ------------------------------------------------------------------
>
>                 Key: MCHANGES-67
>                 URL: http://jira.codehaus.org/browse/MCHANGES-67
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Improvement
>          Components: changes.xml
>    Affects Versions: 2.0-beta-2, 2.0-beta-3
>            Reporter: Henning Schmiedehausen
>            Assignee: Dennis Lundberg
>             Fix For: 2.4
>
>         Attachments: changes5.patch, MCHANGES-67.patch
>
>
> Projects that do not have a team-list file or use a different file will have a number of broken links on the changes-plugin report page.
> The attached patch makes the URL of the team-list file configurable with the default being the "team-list.html" file. This can be changed by setting the 
> <configuration>
>   <teamlist>foo.html</teamlist>
> </configuration>
> parameter. When this parameter is set to empty (e.g.
> <configuration>
>   <teamlist/>
> </configuration>
> then no link is generated and just the names are reported.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MCHANGES-67) The changes plugin should not hard code the "team-list.html" file

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCHANGES-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MCHANGES-67:
------------------------------------

    Issue Type: Improvement  (was: Bug)

> The changes plugin should not hard code the "team-list.html" file 
> ------------------------------------------------------------------
>
>                 Key: MCHANGES-67
>                 URL: http://jira.codehaus.org/browse/MCHANGES-67
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Improvement
>          Components: changes-report
>    Affects Versions: 2.0-beta-2, 2.0-beta-3
>            Reporter: Henning Schmiedehausen
>         Attachments: changes5.patch
>
>
> Projects that do not have a team-list file or use a different file will have a number of broken links on the changes-plugin report page.
> The attached patch makes the URL of the team-list file configurable with the default being the "team-list.html" file. This can be changed by setting the 
> <configuration>
>   <teamlist>foo.html</teamlist>
> </configuration>
> parameter. When this parameter is set to empty (e.g.
> <configuration>
>   <teamlist/>
> </configuration>
> then no link is generated and just the names are reported.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MCHANGES-67) The changes plugin should not hard code the "team-list.html" file

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCHANGES-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MCHANGES-67:
------------------------------------

    Attachment: MCHANGES-67.patch

Here is an updated patch that can be applied to the current trunk.

Unfortunately it doesn't work as Henning wanted it to. It is not possible to set a parameter to empty. If the configuration element is empty, like this <teamlist></teamlist>, then the default-value kicks in. This means that you cannot use this patch to get rid of the links to team members.

> The changes plugin should not hard code the "team-list.html" file 
> ------------------------------------------------------------------
>
>                 Key: MCHANGES-67
>                 URL: http://jira.codehaus.org/browse/MCHANGES-67
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Improvement
>          Components: changes.xml
>    Affects Versions: 2.0-beta-2, 2.0-beta-3
>            Reporter: Henning Schmiedehausen
>         Attachments: changes5.patch, MCHANGES-67.patch
>
>
> Projects that do not have a team-list file or use a different file will have a number of broken links on the changes-plugin report page.
> The attached patch makes the URL of the team-list file configurable with the default being the "team-list.html" file. This can be changed by setting the 
> <configuration>
>   <teamlist>foo.html</teamlist>
> </configuration>
> parameter. When this parameter is set to empty (e.g.
> <configuration>
>   <teamlist/>
> </configuration>
> then no link is generated and just the names are reported.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCHANGES-67) The changes plugin should not hard code the "team-list.html" file

Posted by "Henning Schmiedehausen (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHANGES-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_91806 ] 

Henning Schmiedehausen commented on MCHANGES-67:
------------------------------------------------

Any news on this? I am using this patch in building a site where the team members are listed on a different page and it works well. 

> The changes plugin should not hard code the "team-list.html" file 
> ------------------------------------------------------------------
>
>                 Key: MCHANGES-67
>                 URL: http://jira.codehaus.org/browse/MCHANGES-67
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-2, 2.0-beta-3
>            Reporter: Henning Schmiedehausen
>         Attachments: changes5.patch
>
>
> Projects that do not have a team-list file or use a different file will have a number of broken links on the changes-plugin report page.
> The attached patch makes the URL of the team-list file configurable with the default being the "team-list.html" file. This can be changed by setting the 
> <configuration>
>   <teamlist>foo.html</teamlist>
> </configuration>
> parameter. When this parameter is set to empty (e.g.
> <configuration>
>   <teamlist/>
> </configuration>
> then no link is generated and just the names are reported.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCHANGES-67) The changes plugin should not hard code the "team-list.html" file

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHANGES-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=248955#action_248955 ] 

Dennis Lundberg commented on MCHANGES-67:
-----------------------------------------

Yep, better late than never.

I have recently realized that being able to *not* link to the team-list is a nice feature to have.

We could solve it by adding a special token "none". If you do this:
{code}
<configuration>
 <teamlist>none</teamlist>
</configuration>
{code}
no links would be generated.

Does that sound OK?

> The changes plugin should not hard code the "team-list.html" file 
> ------------------------------------------------------------------
>
>                 Key: MCHANGES-67
>                 URL: http://jira.codehaus.org/browse/MCHANGES-67
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Improvement
>          Components: changes.xml
>    Affects Versions: 2.0-beta-2, 2.0-beta-3
>            Reporter: Henning Schmiedehausen
>         Attachments: changes5.patch, MCHANGES-67.patch
>
>
> Projects that do not have a team-list file or use a different file will have a number of broken links on the changes-plugin report page.
> The attached patch makes the URL of the team-list file configurable with the default being the "team-list.html" file. This can be changed by setting the 
> <configuration>
>   <teamlist>foo.html</teamlist>
> </configuration>
> parameter. When this parameter is set to empty (e.g.
> <configuration>
>   <teamlist/>
> </configuration>
> then no link is generated and just the names are reported.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCHANGES-67) The changes plugin should not hard code the "team-list.html" file

Posted by "Henning Schmiedehausen (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHANGES-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=248952#action_248952 ] 

Henning Schmiedehausen commented on MCHANGES-67:
------------------------------------------------

wow, 3 1/2 years in and someone is already looking at the issue? 

> The changes plugin should not hard code the "team-list.html" file 
> ------------------------------------------------------------------
>
>                 Key: MCHANGES-67
>                 URL: http://jira.codehaus.org/browse/MCHANGES-67
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Improvement
>          Components: changes.xml
>    Affects Versions: 2.0-beta-2, 2.0-beta-3
>            Reporter: Henning Schmiedehausen
>         Attachments: changes5.patch, MCHANGES-67.patch
>
>
> Projects that do not have a team-list file or use a different file will have a number of broken links on the changes-plugin report page.
> The attached patch makes the URL of the team-list file configurable with the default being the "team-list.html" file. This can be changed by setting the 
> <configuration>
>   <teamlist>foo.html</teamlist>
> </configuration>
> parameter. When this parameter is set to empty (e.g.
> <configuration>
>   <teamlist/>
> </configuration>
> then no link is generated and just the names are reported.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MCHANGES-67) The changes plugin should not hard code the "team-list.html" file

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHANGES-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101646 ] 

Dennis Lundberg commented on MCHANGES-67:
-----------------------------------------

Henning, is there a standard Maven way to change the team-list file? I had a look at maven-project-info-reports-plugin and couldn't find a way to change it.

> The changes plugin should not hard code the "team-list.html" file 
> ------------------------------------------------------------------
>
>                 Key: MCHANGES-67
>                 URL: http://jira.codehaus.org/browse/MCHANGES-67
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Improvement
>          Components: changes-report
>    Affects Versions: 2.0-beta-2, 2.0-beta-3
>            Reporter: Henning Schmiedehausen
>         Attachments: changes5.patch
>
>
> Projects that do not have a team-list file or use a different file will have a number of broken links on the changes-plugin report page.
> The attached patch makes the URL of the team-list file configurable with the default being the "team-list.html" file. This can be changed by setting the 
> <configuration>
>   <teamlist>foo.html</teamlist>
> </configuration>
> parameter. When this parameter is set to empty (e.g.
> <configuration>
>   <teamlist/>
> </configuration>
> then no link is generated and just the names are reported.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MCHANGES-67) The changes plugin should not hard code the "team-list.html" file

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCHANGES-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MCHANGES-67:
------------------------------------

    Component/s: changes-report

> The changes plugin should not hard code the "team-list.html" file 
> ------------------------------------------------------------------
>
>                 Key: MCHANGES-67
>                 URL: http://jira.codehaus.org/browse/MCHANGES-67
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Bug
>          Components: changes-report
>    Affects Versions: 2.0-beta-2, 2.0-beta-3
>            Reporter: Henning Schmiedehausen
>         Attachments: changes5.patch
>
>
> Projects that do not have a team-list file or use a different file will have a number of broken links on the changes-plugin report page.
> The attached patch makes the URL of the team-list file configurable with the default being the "team-list.html" file. This can be changed by setting the 
> <configuration>
>   <teamlist>foo.html</teamlist>
> </configuration>
> parameter. When this parameter is set to empty (e.g.
> <configuration>
>   <teamlist/>
> </configuration>
> then no link is generated and just the names are reported.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira