You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Pavel Tupitsyn <pt...@apache.org> on 2020/08/01 07:32:58 UTC
Re: Add IgniteInvalidGridStateException instead of
IllegalStateException in KernalGateway
Sounds good to me.
We can include grid state as a property of that exception too.
On Fri, Jul 31, 2020 at 5:32 PM Guru Stron <gu...@gmail.com>
wrote:
> Dear Igniters,
>
> I'm working on a bug in .NET code that handles transaction states (jira
> ticket <https://issues.apache.org/jira/browse/IGNITE-13296>). And I need a
> way to handle stopped grid exception, so I think it will make sense to
> throw a specialized exception type in this case instead of a generic
> IllegalStateException
> <
> https://github.com/apache/ignite/blob/d486f24b1be3f08e8b1e5e9992c4c8718e169299/modules/core/src/main/java/org/apache/ignite/internal/GridKernalGatewayImpl.java#L95
> >
> .
>
> Any objections?
>
> Best regards!
>
Re: Add IgniteInvalidGridStateException instead of
IllegalStateException in KernalGateway
Posted by Guru Stron <gu...@gmail.com>.
Great find, Pavel!
Thank you, will go with it than.
On Mon, 31 Aug 2020 at 22:45, Pavel Tupitsyn <pt...@apache.org> wrote:
> Actually, we already have IgniteIllegalStateException,
> it exists exactly for situations like this.
>
> Let's just change GridKernalGatewayImpl to throw
> IgniteIllegalStateException
> instead of IllegalStateException and handle that in .NET
>
> On Sat, Aug 1, 2020 at 10:32 AM Pavel Tupitsyn <pt...@apache.org>
> wrote:
>
> > Sounds good to me.
> > We can include grid state as a property of that exception too.
> >
> > On Fri, Jul 31, 2020 at 5:32 PM Guru Stron <gu...@gmail.com>
> > wrote:
> >
> >> Dear Igniters,
> >>
> >> I'm working on a bug in .NET code that handles transaction states (jira
> >> ticket <https://issues.apache.org/jira/browse/IGNITE-13296>). And I
> need
> >> a
> >> way to handle stopped grid exception, so I think it will make sense to
> >> throw a specialized exception type in this case instead of a generic
> >> IllegalStateException
> >> <
> >>
> https://github.com/apache/ignite/blob/d486f24b1be3f08e8b1e5e9992c4c8718e169299/modules/core/src/main/java/org/apache/ignite/internal/GridKernalGatewayImpl.java#L95
> >> >
> >> .
> >>
> >> Any objections?
> >>
> >> Best regards!
> >>
> >
>
Re: Add IgniteInvalidGridStateException instead of
IllegalStateException in KernalGateway
Posted by Pavel Tupitsyn <pt...@apache.org>.
Actually, we already have IgniteIllegalStateException,
it exists exactly for situations like this.
Let's just change GridKernalGatewayImpl to throw IgniteIllegalStateException
instead of IllegalStateException and handle that in .NET
On Sat, Aug 1, 2020 at 10:32 AM Pavel Tupitsyn <pt...@apache.org> wrote:
> Sounds good to me.
> We can include grid state as a property of that exception too.
>
> On Fri, Jul 31, 2020 at 5:32 PM Guru Stron <gu...@gmail.com>
> wrote:
>
>> Dear Igniters,
>>
>> I'm working on a bug in .NET code that handles transaction states (jira
>> ticket <https://issues.apache.org/jira/browse/IGNITE-13296>). And I need
>> a
>> way to handle stopped grid exception, so I think it will make sense to
>> throw a specialized exception type in this case instead of a generic
>> IllegalStateException
>> <
>> https://github.com/apache/ignite/blob/d486f24b1be3f08e8b1e5e9992c4c8718e169299/modules/core/src/main/java/org/apache/ignite/internal/GridKernalGatewayImpl.java#L95
>> >
>> .
>>
>> Any objections?
>>
>> Best regards!
>>
>