Re: svn commit: r1039398 - in /subversion/trunk/subversion: include/svn_dirent_uri.h libsvn_delta/path_driver.c libsvn_subr/dirent_uri.c tests/libsvn_subr/dirent_uri-test.c

[Julian Foad <ju...@wandisco.com>]

Daniel Shahaf wrote:
> > Add some more svn_fspath__* APIs, with tests for some of them.  These tests
> > pass both with and without FSPATH_USE_URI defined.
> > 
> > * subversion/include/svn_dirent_uri.h,
> >   subversion/libsvn_subr/dirent_uri.c
> >   (svn_fspath__dirname, svn_fspath__split, svn_fspath__skip_ancestor,
> >    svn_fspath__is_ancestor, svn_fspath__get_longest_ancestor): New functions.
> > 
> > * subversion/libsvn_delta/path_driver.c
> >   (svn_fspath__get_longest_ancestor): Remove this temporary macro.
> > 
> > * subversion/tests/libsvn_subr/dirent_uri-test.c
> >   (test_fspath_basename): Rename and extend to become ...
> >   (test_fspath_dirname_basename_split): ... this new test.
> >   (test_fspath_get_longest_ancestor): New tests.
> >   (test_funcs): Add the new tests.
> > ### TODO: Tests.
> > 
> 
> What is that ### comment?  Is it the mailer saying you should have added
> a few more tests to this commit?

Heh!  I didn't intend to commit that, but it was me reminding myself
that I ought to write tests for the remaining functions: skip_ancestor
and is_ancestor.  In the end I decided I was OK with committing it
without (or before) writing tests for those.

Tests are important ... but somehow those are way down my priority list.

Thanks for noticing.  I've edited the log message to clarify.

- Julian