You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Carl Steinbach <ca...@cloudera.com> on 2012/04/11 02:42:55 UTC
Problems with Arc/Phabricator
Arc won't let me apply the patch for HIVE-2646. I've also noticed some
other problems (e.g. missing TEST PLAN in checkin comments), and was
wondering how we can get these problems resolved? Since most of this work
was done at Facebook, who is the designated point of contact for
Arc/Phabricator issues going forward?
Here's the error I get when applying HIVE-2646:
% arc patch D2133 --trace
Loading phutil library 'arc_jira_lib' from
'/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>>> [0] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
--show-cdup)
<<< [0] <exec> 13,599 us
>>> [1] <conduit> differential.getdiff()
<<< [1] <conduit> 608,237 us
>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git apply --index
--reject)
<<< [2] <exec> 13,178 us
Fatal error: Uncaught exception 'CommandException' with message 'Command
'(cd '/Users/carl/Work/repos/hive-test/'; git apply --index --reject)'
failed with error #128:
stdout:
stderr:
<stdin>:10: trailing whitespace.
<stdin>:111: trailing whitespace.
<fileset dir="${build.ivy.lib.dir}/default" includes="*.jar"
fatal: corrupt patch at line 609
' in /Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php:346
Stack trace:
#0
/Users/carl/.local/pkg/arcanist/src/workflow/patch/ArcanistPatchWorkflow.php(412):
ExecFuture->resolvex()
#1 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(266):
ArcanistPatchWorkflow->run()
#2 {main}
thrown in /Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php
on line 346
Thanks.
Carl
Re: Problems with Arc/Phabricator
Posted by John Sichi <js...@gmail.com>.
I'll take a look. We asked ASF infra to make the review board
instance read only to make sure the transition went through
completely, so it can't be used for new patches.
JVS
On Tue, Apr 10, 2012 at 6:27 PM, Kevin Wilfong <ke...@fb.com> wrote:
> +John Sichi as he did a lot of the work on getting Hive to use Phabricator.
>
> Is there anything preventing people from using Review Board for patches now,
> except maybe convention? As for applying patches, in either case, you can
> download the patch from the JIRA site.
>
> To be clear, I am not trying to aggressively force Phabricator on Hive,
> these are just suggestions.
>
> From: Carl Steinbach <ca...@cloudera.com>
> Date: Tue, 10 Apr 2012 18:10:44 -0700
> To: Microsoft Office User <ke...@fb.com>
> Cc: "dev@hive.apache.org" <de...@hive.apache.org>
> Subject: Re: Problems with Arc/Phabricator
>
> Ok, I'll submit an issue. But then what? Who is going to fix it? Perhaps in
> the meantime we should just switch back to using reviewboard while we wait
> for Arc and Phabricator to mature as open source projects.
>
>
> On Tue, Apr 10, 2012 at 5:58 PM, Kevin Wilfong <ke...@fb.com> wrote:
>>
>> There's a list of ways to report issues/get help on the side bar of this
>> site http://phabricator.org/
>>
>> It suggests #phabricator <irc://chat.freenode.net/phabricator> as the best
>> place to get help with issues.
>>
>> On 4/10/12 5:42 PM, "Carl Steinbach" <ca...@cloudera.com> wrote:
>>
>> >Arc won't let me apply the patch for HIVE-2646. I've also noticed some
>> >other problems (e.g. missing TEST PLAN in checkin comments), and was
>> >wondering how we can get these problems resolved? Since most of this work
>> >was done at Facebook, who is the designated point of contact for
>> >Arc/Phabricator issues going forward?
>> >
>> >
>> >Here's the error I get when applying HIVE-2646:
>> >
>> >% arc patch D2133 --trace
>> >Loading phutil library 'arc_jira_lib' from
>> >'/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>> >>>> [0] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>> >--show-cdup)
>> ><<< [0] <exec> 13,599 us
>> >>>> [1] <conduit> differential.getdiff()
>> ><<< [1] <conduit> 608,237 us
>> >>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git apply
>> >>>>--index
>> >--reject)
>> ><<< [2] <exec> 13,178 us
>> >
>> >Fatal error: Uncaught exception 'CommandException' with message 'Command
>> >'(cd '/Users/carl/Work/repos/hive-test/'; git apply --index --reject)'
>> >failed with error #128:
>> >stdout:
>> >
>> >stderr:
>> ><stdin>:10: trailing whitespace.
>> >
>> ><stdin>:111: trailing whitespace.
>> > <fileset dir="${build.ivy.lib.dir}/default" includes="*.jar"
>> >fatal: corrupt patch at line 609
>> >
>> >' in /Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php:346
>> >Stack trace:
>> >#0
>>
>> > >/Users/carl/.local/pkg/arcanist/src/workflow/patch/ArcanistPatchWorkflow.p
>> >hp(412):
>> >ExecFuture->resolvex()
>> >#1 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(266):
>> >ArcanistPatchWorkflow->run()
>> >#2 {main}
>> > thrown in
>> >/Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php
>> >on line 346
>> >
>> >
>> >Thanks.
>> >
>> >Carl
>>
>
Re: Problems with Arc/Phabricator
Posted by Edward Capriolo <ed...@gmail.com>.
I have arc working on linux. Fedora core 12 I think.
On Wed, Apr 11, 2012 at 8:45 PM, Ashutosh Chauhan
<as...@gmail.com> wrote:
> Is mac only supported OS ? Arc doesn't work for me on linux, which is
> unfortunate since thats where I do all my testing.
>
> Thanks,
> Ashutosh
> On Wed, Apr 11, 2012 at 17:37, John Sichi <js...@gmail.com> wrote:
>
>> CC'ing David Recordon, who can probably help with a point of contact
>> for coordinating future Phabricator upgrades.
>>
>> It looks like the test plan problem mentioned below (which affects
>> git, but not svn) was introduced when the reviews.facebook.net
>> Phabricator server was upgraded Feb 23. I've committed a change to
>> the arc-jira module which should deal with it:
>>
>>
>> https://github.com/facebook/arc-jira/commit/b62b5976ec9a974ed102c2f55b530edde48cfaa5
>>
>> So if you run ant arc-setup in your Hive sandbox, you should be good to go.
>>
>> JVS
>>
>> On Wed, Apr 11, 2012 at 3:37 PM, Carl Steinbach <ca...@cloudera.com> wrote:
>> > Hi John,
>> >
>> >>
>> >> Regarding the test plans: Carl, could you be more specific about what
>> >> is going wrong so I can attempt to reproduce the problem?
>> >
>> >
>> > At some point Arc started requiring that the commit message contain a
>> "Test
>> > Plan" string, or maybe this has always been a requirement and it was just
>> > automatically added before? Anyway, right now you have to manually add
>> this
>> > or you get the following error:
>> >
>> > % git log -1
>> > commit 2649ca167182bb02823b3fb00bbe7602f591717e
>> > Author: Carl Steinbach <ca...@cloudera.com>
>> > Date: Wed Apr 11 15:12:53 2012 -0700
>> >
>> > HIVE-2947. Test Phabricator
>> >
>> > % arc diff --trace --jira HIVE-2947
>> > Loading phutil library 'arc_jira_lib' from
>> > '/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>> >>>> [0] <conduit> conduit.connect()
>> > <<< [0] <conduit> 329,414 us
>> >>>> [1] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>> >>>> --show-cdup)
>> > <<< [1] <exec> 16,731 us
>> >>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git rev-parse
>> >>>> --verify HEAD^)
>> > <<< [2] <exec> 20,879 us
>> >>>> [3] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git log
>> >>>> --first-parent --format=medium 'HEAD^'..HEAD)
>> > <<< [3] <exec> 17,852 us
>> >>>> [4] <conduit> differential.parsecommitmessage()
>> > <<< [4] <conduit> 558,248 us
>> >
>> > Fatal error: Uncaught exception
>> > 'ArcanistDifferentialCommitMessageParserException' with message 'Invalid
>> or
>> > missing field 'Test Plan': You must provide a test plan.' in
>> >
>> /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php:88
>> > Stack trace:
>> > #0
>> >
>> /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(88):
>> >
>> ArcanistDifferentialCommitMessage->pullDataFromConduit(Object(ConduitClient))
>> > #1
>> >
>> /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(368):
>> > ArcJIRAConfiguration->willRunDiffWorkflow()
>> > #2 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(264):
>> > ArcJIRAConfiguration->willRunWorkflow('diff',
>> Object(ArcanistDiffWorkflow))
>> > #3 {main}
>> > thrown in
>> >
>> /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php
>> > on line 88
>> >
>> > Thanks.
>> >
>> > Carl
>> >
>>
Re: Problems with Arc/Phabricator
Posted by John Sichi <js...@gmail.com>.
arc works fine on Linux for me. What problem are you encountering?
JVS
On Wed, Apr 11, 2012 at 5:45 PM, Ashutosh Chauhan
<as...@gmail.com> wrote:
> Is mac only supported OS ? Arc doesn't work for me on linux, which is
> unfortunate since thats where I do all my testing.
>
> Thanks,
> Ashutosh
>
> On Wed, Apr 11, 2012 at 17:37, John Sichi <js...@gmail.com> wrote:
>>
>> CC'ing David Recordon, who can probably help with a point of contact
>> for coordinating future Phabricator upgrades.
>>
>> It looks like the test plan problem mentioned below (which affects
>> git, but not svn) was introduced when the reviews.facebook.net
>> Phabricator server was upgraded Feb 23. I've committed a change to
>> the arc-jira module which should deal with it:
>>
>>
>> https://github.com/facebook/arc-jira/commit/b62b5976ec9a974ed102c2f55b530edde48cfaa5
>>
>> So if you run ant arc-setup in your Hive sandbox, you should be good to
>> go.
>>
>> JVS
>>
>> On Wed, Apr 11, 2012 at 3:37 PM, Carl Steinbach <ca...@cloudera.com> wrote:
>> > Hi John,
>> >
>> >>
>> >> Regarding the test plans: Carl, could you be more specific about what
>> >> is going wrong so I can attempt to reproduce the problem?
>> >
>> >
>> > At some point Arc started requiring that the commit message contain a
>> > "Test
>> > Plan" string, or maybe this has always been a requirement and it was
>> > just
>> > automatically added before? Anyway, right now you have to manually add
>> > this
>> > or you get the following error:
>> >
>> > % git log -1
>> > commit 2649ca167182bb02823b3fb00bbe7602f591717e
>> > Author: Carl Steinbach <ca...@cloudera.com>
>> > Date: Wed Apr 11 15:12:53 2012 -0700
>> >
>> > HIVE-2947. Test Phabricator
>> >
>> > % arc diff --trace --jira HIVE-2947
>> > Loading phutil library 'arc_jira_lib' from
>> > '/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>> >>>> [0] <conduit> conduit.connect()
>> > <<< [0] <conduit> 329,414 us
>> >>>> [1] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>> >>>> --show-cdup)
>> > <<< [1] <exec> 16,731 us
>> >>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git rev-parse
>> >>>> --verify HEAD^)
>> > <<< [2] <exec> 20,879 us
>> >>>> [3] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git log
>> >>>> --first-parent --format=medium 'HEAD^'..HEAD)
>> > <<< [3] <exec> 17,852 us
>> >>>> [4] <conduit> differential.parsecommitmessage()
>> > <<< [4] <conduit> 558,248 us
>> >
>> > Fatal error: Uncaught exception
>> > 'ArcanistDifferentialCommitMessageParserException' with message 'Invalid
>> > or
>> > missing field 'Test Plan': You must provide a test plan.' in
>> >
>> > /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php:88
>> > Stack trace:
>> > #0
>> >
>> > /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(88):
>> >
>> > ArcanistDifferentialCommitMessage->pullDataFromConduit(Object(ConduitClient))
>> > #1
>> >
>> > /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(368):
>> > ArcJIRAConfiguration->willRunDiffWorkflow()
>> > #2 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(264):
>> > ArcJIRAConfiguration->willRunWorkflow('diff',
>> > Object(ArcanistDiffWorkflow))
>> > #3 {main}
>> > thrown in
>> >
>> > /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php
>> > on line 88
>> >
>> > Thanks.
>> >
>> > Carl
>> >
>
>
Re: Problems with Arc/Phabricator
Posted by Ashutosh Chauhan <as...@gmail.com>.
Is mac only supported OS ? Arc doesn't work for me on linux, which is
unfortunate since thats where I do all my testing.
Thanks,
Ashutosh
On Wed, Apr 11, 2012 at 17:37, John Sichi <js...@gmail.com> wrote:
> CC'ing David Recordon, who can probably help with a point of contact
> for coordinating future Phabricator upgrades.
>
> It looks like the test plan problem mentioned below (which affects
> git, but not svn) was introduced when the reviews.facebook.net
> Phabricator server was upgraded Feb 23. I've committed a change to
> the arc-jira module which should deal with it:
>
>
> https://github.com/facebook/arc-jira/commit/b62b5976ec9a974ed102c2f55b530edde48cfaa5
>
> So if you run ant arc-setup in your Hive sandbox, you should be good to go.
>
> JVS
>
> On Wed, Apr 11, 2012 at 3:37 PM, Carl Steinbach <ca...@cloudera.com> wrote:
> > Hi John,
> >
> >>
> >> Regarding the test plans: Carl, could you be more specific about what
> >> is going wrong so I can attempt to reproduce the problem?
> >
> >
> > At some point Arc started requiring that the commit message contain a
> "Test
> > Plan" string, or maybe this has always been a requirement and it was just
> > automatically added before? Anyway, right now you have to manually add
> this
> > or you get the following error:
> >
> > % git log -1
> > commit 2649ca167182bb02823b3fb00bbe7602f591717e
> > Author: Carl Steinbach <ca...@cloudera.com>
> > Date: Wed Apr 11 15:12:53 2012 -0700
> >
> > HIVE-2947. Test Phabricator
> >
> > % arc diff --trace --jira HIVE-2947
> > Loading phutil library 'arc_jira_lib' from
> > '/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
> >>>> [0] <conduit> conduit.connect()
> > <<< [0] <conduit> 329,414 us
> >>>> [1] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
> >>>> --show-cdup)
> > <<< [1] <exec> 16,731 us
> >>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git rev-parse
> >>>> --verify HEAD^)
> > <<< [2] <exec> 20,879 us
> >>>> [3] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git log
> >>>> --first-parent --format=medium 'HEAD^'..HEAD)
> > <<< [3] <exec> 17,852 us
> >>>> [4] <conduit> differential.parsecommitmessage()
> > <<< [4] <conduit> 558,248 us
> >
> > Fatal error: Uncaught exception
> > 'ArcanistDifferentialCommitMessageParserException' with message 'Invalid
> or
> > missing field 'Test Plan': You must provide a test plan.' in
> >
> /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php:88
> > Stack trace:
> > #0
> >
> /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(88):
> >
> ArcanistDifferentialCommitMessage->pullDataFromConduit(Object(ConduitClient))
> > #1
> >
> /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(368):
> > ArcJIRAConfiguration->willRunDiffWorkflow()
> > #2 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(264):
> > ArcJIRAConfiguration->willRunWorkflow('diff',
> Object(ArcanistDiffWorkflow))
> > #3 {main}
> > thrown in
> >
> /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php
> > on line 88
> >
> > Thanks.
> >
> > Carl
> >
>
Re: Problems with Arc/Phabricator
Posted by John Sichi <js...@gmail.com>.
Oops, actually adding dr@fb.com this time.
On Wed, Apr 11, 2012 at 5:37 PM, John Sichi <js...@gmail.com> wrote:
> CC'ing David Recordon, who can probably help with a point of contact
> for coordinating future Phabricator upgrades.
>
> It looks like the test plan problem mentioned below (which affects
> git, but not svn) was introduced when the reviews.facebook.net
> Phabricator server was upgraded Feb 23. I've committed a change to
> the arc-jira module which should deal with it:
>
> https://github.com/facebook/arc-jira/commit/b62b5976ec9a974ed102c2f55b530edde48cfaa5
>
> So if you run ant arc-setup in your Hive sandbox, you should be good to go.
>
> JVS
>
> On Wed, Apr 11, 2012 at 3:37 PM, Carl Steinbach <ca...@cloudera.com> wrote:
>> Hi John,
>>
>>>
>>> Regarding the test plans: Carl, could you be more specific about what
>>> is going wrong so I can attempt to reproduce the problem?
>>
>>
>> At some point Arc started requiring that the commit message contain a "Test
>> Plan" string, or maybe this has always been a requirement and it was just
>> automatically added before? Anyway, right now you have to manually add this
>> or you get the following error:
>>
>> % git log -1
>> commit 2649ca167182bb02823b3fb00bbe7602f591717e
>> Author: Carl Steinbach <ca...@cloudera.com>
>> Date: Wed Apr 11 15:12:53 2012 -0700
>>
>> HIVE-2947. Test Phabricator
>>
>> % arc diff --trace --jira HIVE-2947
>> Loading phutil library 'arc_jira_lib' from
>> '/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>>>>> [0] <conduit> conduit.connect()
>> <<< [0] <conduit> 329,414 us
>>>>> [1] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>>>>> --show-cdup)
>> <<< [1] <exec> 16,731 us
>>>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git rev-parse
>>>>> --verify HEAD^)
>> <<< [2] <exec> 20,879 us
>>>>> [3] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git log
>>>>> --first-parent --format=medium 'HEAD^'..HEAD)
>> <<< [3] <exec> 17,852 us
>>>>> [4] <conduit> differential.parsecommitmessage()
>> <<< [4] <conduit> 558,248 us
>>
>> Fatal error: Uncaught exception
>> 'ArcanistDifferentialCommitMessageParserException' with message 'Invalid or
>> missing field 'Test Plan': You must provide a test plan.' in
>> /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php:88
>> Stack trace:
>> #0
>> /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(88):
>> ArcanistDifferentialCommitMessage->pullDataFromConduit(Object(ConduitClient))
>> #1
>> /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(368):
>> ArcJIRAConfiguration->willRunDiffWorkflow()
>> #2 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(264):
>> ArcJIRAConfiguration->willRunWorkflow('diff', Object(ArcanistDiffWorkflow))
>> #3 {main}
>> thrown in
>> /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php
>> on line 88
>>
>> Thanks.
>>
>> Carl
>>
Re: Problems with Arc/Phabricator
Posted by John Sichi <js...@gmail.com>.
CC'ing David Recordon, who can probably help with a point of contact
for coordinating future Phabricator upgrades.
It looks like the test plan problem mentioned below (which affects
git, but not svn) was introduced when the reviews.facebook.net
Phabricator server was upgraded Feb 23. I've committed a change to
the arc-jira module which should deal with it:
https://github.com/facebook/arc-jira/commit/b62b5976ec9a974ed102c2f55b530edde48cfaa5
So if you run ant arc-setup in your Hive sandbox, you should be good to go.
JVS
On Wed, Apr 11, 2012 at 3:37 PM, Carl Steinbach <ca...@cloudera.com> wrote:
> Hi John,
>
>>
>> Regarding the test plans: Carl, could you be more specific about what
>> is going wrong so I can attempt to reproduce the problem?
>
>
> At some point Arc started requiring that the commit message contain a "Test
> Plan" string, or maybe this has always been a requirement and it was just
> automatically added before? Anyway, right now you have to manually add this
> or you get the following error:
>
> % git log -1
> commit 2649ca167182bb02823b3fb00bbe7602f591717e
> Author: Carl Steinbach <ca...@cloudera.com>
> Date: Wed Apr 11 15:12:53 2012 -0700
>
> HIVE-2947. Test Phabricator
>
> % arc diff --trace --jira HIVE-2947
> Loading phutil library 'arc_jira_lib' from
> '/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>>>> [0] <conduit> conduit.connect()
> <<< [0] <conduit> 329,414 us
>>>> [1] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>>>> --show-cdup)
> <<< [1] <exec> 16,731 us
>>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git rev-parse
>>>> --verify HEAD^)
> <<< [2] <exec> 20,879 us
>>>> [3] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git log
>>>> --first-parent --format=medium 'HEAD^'..HEAD)
> <<< [3] <exec> 17,852 us
>>>> [4] <conduit> differential.parsecommitmessage()
> <<< [4] <conduit> 558,248 us
>
> Fatal error: Uncaught exception
> 'ArcanistDifferentialCommitMessageParserException' with message 'Invalid or
> missing field 'Test Plan': You must provide a test plan.' in
> /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php:88
> Stack trace:
> #0
> /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(88):
> ArcanistDifferentialCommitMessage->pullDataFromConduit(Object(ConduitClient))
> #1
> /Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(368):
> ArcJIRAConfiguration->willRunDiffWorkflow()
> #2 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(264):
> ArcJIRAConfiguration->willRunWorkflow('diff', Object(ArcanistDiffWorkflow))
> #3 {main}
> thrown in
> /Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php
> on line 88
>
> Thanks.
>
> Carl
>
Re: Problems with Arc/Phabricator
Posted by Carl Steinbach <ca...@cloudera.com>.
Hi John,
> Regarding the test plans: Carl, could you be more specific about what
> is going wrong so I can attempt to reproduce the problem?
>
At some point Arc started requiring that the commit message contain a "Test
Plan" string, or maybe this has always been a requirement and it was just
automatically added before? Anyway, right now you have to manually add this
or you get the following error:
% git log -1
commit 2649ca167182bb02823b3fb00bbe7602f591717e
Author: Carl Steinbach <ca...@cloudera.com>
Date: Wed Apr 11 15:12:53 2012 -0700
HIVE-2947. Test Phabricator
% arc diff --trace --jira HIVE-2947
Loading phutil library 'arc_jira_lib' from
'/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>>> [0] <conduit> conduit.connect()
<<< [0] <conduit> 329,414 us
>>> [1] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
--show-cdup)
<<< [1] <exec> 16,731 us
>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git rev-parse
--verify HEAD^)
<<< [2] <exec> 20,879 us
>>> [3] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git log
--first-parent --format=medium 'HEAD^'..HEAD)
<<< [3] <exec> 17,852 us
>>> [4] <conduit> differential.parsecommitmessage()
<<< [4] <conduit> 558,248 us
Fatal error: Uncaught exception
'ArcanistDifferentialCommitMessageParserException' with message 'Invalid or
missing field 'Test Plan': You must provide a test plan.' in
/Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php:88
Stack trace:
#0
/Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(88):
ArcanistDifferentialCommitMessage->pullDataFromConduit(Object(ConduitClient))
#1
/Users/carl/Work/repos/hive-test/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php(368):
ArcJIRAConfiguration->willRunDiffWorkflow()
#2 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(264):
ArcJIRAConfiguration->willRunWorkflow('diff', Object(ArcanistDiffWorkflow))
#3 {main}
thrown in
/Users/carl/.local/pkg/arcanist/src/differential/commitmessage/ArcanistDifferentialCommitMessage.php
on line 88
Thanks.
Carl
Re: Problems with Arc/Phabricator
Posted by John Sichi <js...@gmail.com>.
I took a look at the 14.patch file in JIRA; the last hunk for
ivy/common-configurations.xml ends in "\ No newline at end of file",
and I think that's what is screwing it up (since that immediately
precedes ivysettings.xml). If I delete that line, the patch applies
(although it causes a reject for common-configurations.xml).
So perhaps there's a bug with arc's diff options used to produce the
patch file in the first place...seems like that should be something
easy to reproduce and track down (by editing the end of a file which
currently is missing a trailing newline).
JVS
On Wed, Apr 11, 2012 at 4:11 PM, Carl Steinbach <ca...@cloudera.com> wrote:
> Hi John,
>
>> For HIVE-2646: the diagnostics aren't great, but I think it's just
>> choking on a patch that needs to be rebased, since as Kevin says, if I
>> download the latest .patch from JIRA and apply that with patch -p0, I
>> get the correct failure message. So just ask the author to rebase
>> again?
>
>
> I updated my local arcanist and libphutil repos and then tried applying the
> patch for HIVE-2646 using the command 'arc patch --revision 2133'. This
> works.
>
> However, when I download the patch for HIVE-2646 and manually apply it, I
> get the following error:
>
> % wget
> https://issues.apache.org/jira/secure/attachment/12522177/HIVE-2646.D2133.14.patch
> % patch -p0 < HIVE-2646.D2133.14.patch
> patching file build-common.xml
> patching file build.properties
> patching file build.xml
> patching file builtins/build.xml
> patching file builtins/ivy.xml
> patching file cli/ivy.xml
> patching file common/ivy.xml
> patching file contrib/build.xml
> patching file contrib/ivy.xml
> patching file hbase-handler/build.xml
> patching file hbase-handler/ivy.xml
> patching file hwi/build.xml
> patching file hwi/ivy.xml
> patching file ivy/common-configurations.xml
> patch: **** malformed patch at line 622: Index: ivy/ivysettings.xml
>
> Other people have complained about problems encountered while manually
> applying Phabricator diffs, and the response has always been that the patch
> needs to be rebased. However, I think this example indicates that there's
> actually some other problem here.
>
> Thanks.
>
> Carl
Re: Problems with Arc/Phabricator
Posted by Carl Steinbach <ca...@cloudera.com>.
Hi John,
For HIVE-2646: the diagnostics aren't great, but I think it's just
> choking on a patch that needs to be rebased, since as Kevin says, if I
> download the latest .patch from JIRA and apply that with patch -p0, I
> get the correct failure message. So just ask the author to rebase
> again?
I updated my local arcanist and libphutil repos and then tried applying the
patch for HIVE-2646 using the command 'arc patch --revision 2133'. This
works.
However, when I download the patch for HIVE-2646 and manually apply it, I
get the following error:
% wget
https://issues.apache.org/jira/secure/attachment/12522177/HIVE-2646.D2133.14.patch
% patch -p0 < HIVE-2646.D2133.14.patch
patching file build-common.xml
patching file build.properties
patching file build.xml
patching file builtins/build.xml
patching file builtins/ivy.xml
patching file cli/ivy.xml
patching file common/ivy.xml
patching file contrib/build.xml
patching file contrib/ivy.xml
patching file hbase-handler/build.xml
patching file hbase-handler/ivy.xml
patching file hwi/build.xml
patching file hwi/ivy.xml
patching file ivy/common-configurations.xml
patch: **** malformed patch at line 622: Index: ivy/ivysettings.xml
Other people have complained about problems encountered while manually
applying Phabricator diffs, and the response has always been that the patch
needs to be rebased. However, I think this example indicates that there's
actually some other problem here.
Thanks.
Carl
Re: Problems with Arc/Phabricator
Posted by John Sichi <js...@gmail.com>.
For HIVE-2646: the diagnostics aren't great, but I think it's just
choking on a patch that needs to be rebased, since as Kevin says, if I
download the latest .patch from JIRA and apply that with patch -p0, I
get the correct failure message. So just ask the author to rebase
again?
Regarding the test plans: Carl, could you be more specific about what
is going wrong so I can attempt to reproduce the problem?
JVS
On Tue, Apr 10, 2012 at 6:27 PM, Kevin Wilfong <ke...@fb.com> wrote:
> +John Sichi as he did a lot of the work on getting Hive to use Phabricator.
>
> Is there anything preventing people from using Review Board for patches now,
> except maybe convention? As for applying patches, in either case, you can
> download the patch from the JIRA site.
>
> To be clear, I am not trying to aggressively force Phabricator on Hive,
> these are just suggestions.
>
> From: Carl Steinbach <ca...@cloudera.com>
> Date: Tue, 10 Apr 2012 18:10:44 -0700
> To: Microsoft Office User <ke...@fb.com>
> Cc: "dev@hive.apache.org" <de...@hive.apache.org>
> Subject: Re: Problems with Arc/Phabricator
>
> Ok, I'll submit an issue. But then what? Who is going to fix it? Perhaps in
> the meantime we should just switch back to using reviewboard while we wait
> for Arc and Phabricator to mature as open source projects.
>
>
> On Tue, Apr 10, 2012 at 5:58 PM, Kevin Wilfong <ke...@fb.com> wrote:
>>
>> There's a list of ways to report issues/get help on the side bar of this
>> site http://phabricator.org/
>>
>> It suggests #phabricator <irc://chat.freenode.net/phabricator> as the best
>> place to get help with issues.
>>
>> On 4/10/12 5:42 PM, "Carl Steinbach" <ca...@cloudera.com> wrote:
>>
>> >Arc won't let me apply the patch for HIVE-2646. I've also noticed some
>> >other problems (e.g. missing TEST PLAN in checkin comments), and was
>> >wondering how we can get these problems resolved? Since most of this work
>> >was done at Facebook, who is the designated point of contact for
>> >Arc/Phabricator issues going forward?
>> >
>> >
>> >Here's the error I get when applying HIVE-2646:
>> >
>> >% arc patch D2133 --trace
>> >Loading phutil library 'arc_jira_lib' from
>> >'/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>> >>>> [0] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>> >--show-cdup)
>> ><<< [0] <exec> 13,599 us
>> >>>> [1] <conduit> differential.getdiff()
>> ><<< [1] <conduit> 608,237 us
>> >>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git apply
>> >>>>--index
>> >--reject)
>> ><<< [2] <exec> 13,178 us
>> >
>> >Fatal error: Uncaught exception 'CommandException' with message 'Command
>> >'(cd '/Users/carl/Work/repos/hive-test/'; git apply --index --reject)'
>> >failed with error #128:
>> >stdout:
>> >
>> >stderr:
>> ><stdin>:10: trailing whitespace.
>> >
>> ><stdin>:111: trailing whitespace.
>> > <fileset dir="${build.ivy.lib.dir}/default" includes="*.jar"
>> >fatal: corrupt patch at line 609
>> >
>> >' in /Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php:346
>> >Stack trace:
>> >#0
>>
>> > >/Users/carl/.local/pkg/arcanist/src/workflow/patch/ArcanistPatchWorkflow.p
>> >hp(412):
>> >ExecFuture->resolvex()
>> >#1 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(266):
>> >ArcanistPatchWorkflow->run()
>> >#2 {main}
>> > thrown in
>> >/Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php
>> >on line 346
>> >
>> >
>> >Thanks.
>> >
>> >Carl
>>
>
Re: Problems with Arc/Phabricator
Posted by Enis Söztutar <en...@hortonworks.com>.
I think as an Apache project, using code review tools outside apache should
never be a "requirement". I agree that arc/phab are great tools, and they
help the patch/review process a lot. But I think what is essential for long
term sustainability as a project is to lower the entry barriers for
contributing. Not every developer who wants to contribute some code will be
willing to work with phab/rb.
What I would suggest is to always have the option to submit patches via
jira, and make rb / phab optional.
Just my 2 cents,
Enis
On Thu, Apr 19, 2012 at 4:35 PM, Ashutosh Chauhan <ha...@apache.org>wrote:
> Hit a new problem with arc today:
>
> Fatal error: Uncaught exception 'Exception' with message 'Host returned
> HTTP/200, but invalid JSON data in response to a Conduit method call:
> <br />
> <b>Warning</b>: Unknown: POST Content-Length of 9079953 bytes exceeds the
> limit of 8388608 bytes in <b>Unknown</b> on line <b>0</b><br />
>
> for(;;);{"result":null,"error_code":"ERR-INVALID-SESSION","error_info":"Session
> key is not present."}' in
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php:48
> Stack trace:
> #0
> /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(62):
> ConduitFuture->didReceiveResult(Array)
> #1
> /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(39):
> FutureProxy->getResult()
> #2
>
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitClient.php(52):
> FutureProxy->resolve()
> #3
>
> /Users/ashutosh/work/hive/arcanist/src/workflow/diff/ArcanistDiffWorkflow.php(341):
> ConduitClient->callMethodSynchronous('differential.cr...', Array)
> #4 /Users/ashutosh/work/hive/arcanist/scripts/arcanist.php(266):
> ArcanistDiffWo in
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php on
> line 48
>
>
> Any ideas how to solve this?
>
> Thanks,
> Ashutosh
>
> On Wed, Apr 11, 2012 at 18:37, Edward Capriolo <edlinuxguru@gmail.com
> >wrote:
>
> > I think the most practical solution is try and use arc/phab and then
> > if there is a problem fall back to Jira and do it the old way.
> >
> > Edward
> >
> > On Wed, Apr 11, 2012 at 7:17 PM, Carl Steinbach <ca...@cloudera.com>
> wrote:
> > > +1 to switching over to Git.
> > >
> > > As for the rest of the Phabricator/Gerrit/Reviewboard discussion, I
> think
> > > we should pick this up again at the contributor meeting on Wednesday.
> > >
> > > Thanks.
> > >
> > > Carl
> > >
> > > On Wed, Apr 11, 2012 at 12:19 PM, Ashutosh Chauhan <
> hashutosh@apache.org
> > >wrote:
> > >
> > >> +1 on moving away from arc/phabricator. It works great when it works,
> > but
> > >> most of the time it doesnt work.
> > >>
> > >> Ashutosh
> > >>
> > >> On Wed, Apr 11, 2012 at 11:57, Owen O'Malley <om...@apache.org>
> > wrote:
> > >>
> > >> > On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <
> > edlinuxguru@gmail.com
> > >> >
> > >> > wrote:
> > >> > > If we are going to switch from fabricator we just might as well go
> > >> > > back to not using anything. Review board was really clunky and
> > >> > > confusing.
> > >> >
> > >> > I'm mostly +1 to that. If no one is supporting phabricator, then it
> > >> > won't work for long. Personally, I'd love it if we could move Hive
> to
> > >> > git completely. Has anyone used gerrit? The videos of it make it
> look
> > >> > better than sliced bread.
> > >> >
> > >> > -- Owen
> > >> >
> > >>
> >
>
Re: Problems with Arc/Phabricator
Posted by Navis류승우 <na...@nexr.com>.
Me too.
arc diff --trace
......
PHP Fatal error: Uncaught exception 'HTTPFutureResponseStatusHTTP'
with message '[HTTP/500]' in
/home/navis/bin/libphutil/src/future/http/base/BaseHTTPFuture.php:299
Stack trace:
#0 /home/navis/bin/libphutil/src/future/http/https/HTTPSFuture.php(95):
BaseHTTPFuture->parseRawHTTPResponse('HTTP/1.1 100 Co...')
#1 /home/navis/bin/libphutil/src/future/proxy/FutureProxy.php(34):
HTTPSFuture->isReady()
#2 /home/navis/bin/libphutil/src/conduit/client/ConduitClient.php(131):
FutureProxy->isReady()
#3 /home/navis/bin/libphutil/src/conduit/client/ConduitClient.php(52):
ConduitClient->callMethod('differential.cr...', Array)
#4 /home/navis/bin/arcanist/src/workflow/diff/ArcanistDiffWorkflow.php(324):
ConduitClient->callMethodSynchronous('differential.cr...', Array)
#5 /home/navis/bin/arcanist/scripts/arcanist.php(266):
ArcanistDiffWorkflow->run()
#6 {main}
thrown in /home/navis/bin/libphutil/src/future/http/base/BaseHTTPFuture.php
on line 299
2012/5/9 Carl Steinbach <ca...@cloudera.com>:
> Has the phabricator site stopped working for anyone else? As of today I'm
> not longer able to view review requests. For example:
>
> https://reviews.facebook.net/D3075
>
> Produces the following output:
>
> <br />
> <b>Fatal error</b>: Undefined class constant 'COMMITTED' in
> <b>/var/www/reviews.facebook.net/phabricator/src/applications/differential/storage/revision/DifferentialRevision.php</b>
> on line <b>209</b><br />
>>>> UNRECOVERABLE FATAL ERROR <<<
>
> Undefined class constant 'COMMITTED'
>
> /var/www/reviews.facebook.net/phabricator/src/applications/differential/storage/revision/DifferentialRevision.php:209
>
>
> ┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻
>
>
> Any help would be much appreciated.
>
> Thanks.
>
> Carl
>
> On Tue, May 8, 2012 at 1:47 PM, Ashutosh Chauhan <ha...@apache.org>wrote:
>
>> Made some progress on using arc/phab on ubuntu. epriestley helped a ton
>> over at #phabricator irc channel. Thanks, Evan!
>> Now, able to make arc work on ubuntu, but seems like jira integration is
>> broken. Hit the following problem:
>>
>> $arc diff —jira HIVE-3008
>>
>> PHP Fatal error: Class 'ArcanistDifferentialRevisionRef' not found in
>> /home/ashutosh/workspace/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php on
>> line 201
>>
>> Fatal error: Class 'ArcanistDifferentialRevisionRef' not found in
>> /home/ashutosh/workspace/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php on
>> line 201
>>
>> Even with this error diff did get generated but it was not posted back on
>> jira. Evan is working on a patch to fix this.
>>
>> He is also discussing with Facebook folks on how to tackle these issues in
>> long term. Discussion is going on at https://secure.phabricator.com/T1206
>>
>> I will request people who are actively working on Hive to follow the
>> discussion on this ticket.
>>
>>
>> Thanks,
>>
>> Ashutosh
>>
>>
>>
>> On Thu, Apr 19, 2012 at 5:24 PM, Ashutosh Chauhan <hashutosh@apache.org
>> >wrote:
>>
>> > Problem while using arc on ubuntu
>> >
>> > $ arc patch D2871
>> > ARC: Cannot mix P and A
>> > UNIX: No such file or directory
>> >
>> > Any ideas whats up there.
>> >
>> > Thanks,
>> > Ashutosh
>> >
>> > On Thu, Apr 19, 2012 at 17:19, Edward Capriolo <edlinuxguru@gmail.com
>> >wrote:
>> >
>> >> Just throwing this out there. The phabricator IRC has more people and
>> >> is usually more active then Hive IRC.
>> >>
>> >> #JustSaying...
>> >>
>> >> On Thu, Apr 19, 2012 at 7:35 PM, Ashutosh Chauhan <hashutosh@apache.org
>> >
>> >> wrote:
>> >> > Hit a new problem with arc today:
>> >> >
>> >> > Fatal error: Uncaught exception 'Exception' with message 'Host
>> returned
>> >> > HTTP/200, but invalid JSON data in response to a Conduit method call:
>> >> > <br />
>> >> > <b>Warning</b>: Unknown: POST Content-Length of 9079953 bytes exceeds
>> >> the
>> >> > limit of 8388608 bytes in <b>Unknown</b> on line <b>0</b><br />
>> >> >
>> >>
>> for(;;);{"result":null,"error_code":"ERR-INVALID-SESSION","error_info":"Session
>> >> > key is not present."}' in
>> >> >
>> >>
>> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php:48
>> >> > Stack trace:
>> >> > #0
>> >> >
>> >>
>> /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(62):
>> >> > ConduitFuture->didReceiveResult(Array)
>> >> > #1
>> >> >
>> >>
>> /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(39):
>> >> > FutureProxy->getResult()
>> >> > #2
>> >> >
>> >>
>> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitClient.php(52):
>> >> > FutureProxy->resolve()
>> >> > #3
>> >> >
>> >>
>> /Users/ashutosh/work/hive/arcanist/src/workflow/diff/ArcanistDiffWorkflow.php(341):
>> >> > ConduitClient->callMethodSynchronous('differential.cr...', Array)
>> >> > #4 /Users/ashutosh/work/hive/arcanist/scripts/arcanist.php(266):
>> >> > ArcanistDiffWo in
>> >> >
>> >>
>> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php on
>> >> > line 48
>> >> >
>> >> >
>> >> > Any ideas how to solve this?
>> >> >
>> >> > Thanks,
>> >> > Ashutosh
>> >> >
>> >> > On Wed, Apr 11, 2012 at 18:37, Edward Capriolo <edlinuxguru@gmail.com
>> >> >wrote:
>> >> >
>> >> >> I think the most practical solution is try and use arc/phab and then
>> >> >> if there is a problem fall back to Jira and do it the old way.
>> >> >>
>> >> >> Edward
>> >> >>
>> >> >> On Wed, Apr 11, 2012 at 7:17 PM, Carl Steinbach <ca...@cloudera.com>
>> >> wrote:
>> >> >> > +1 to switching over to Git.
>> >> >> >
>> >> >> > As for the rest of the Phabricator/Gerrit/Reviewboard discussion, I
>> >> think
>> >> >> > we should pick this up again at the contributor meeting on
>> Wednesday.
>> >> >> >
>> >> >> > Thanks.
>> >> >> >
>> >> >> > Carl
>> >> >> >
>> >> >> > On Wed, Apr 11, 2012 at 12:19 PM, Ashutosh Chauhan <
>> >> hashutosh@apache.org
>> >> >> >wrote:
>> >> >> >
>> >> >> >> +1 on moving away from arc/phabricator. It works great when it
>> >> works,
>> >> >> but
>> >> >> >> most of the time it doesnt work.
>> >> >> >>
>> >> >> >> Ashutosh
>> >> >> >>
>> >> >> >> On Wed, Apr 11, 2012 at 11:57, Owen O'Malley <om...@apache.org>
>> >> >> wrote:
>> >> >> >>
>> >> >> >> > On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <
>> >> >> edlinuxguru@gmail.com
>> >> >> >> >
>> >> >> >> > wrote:
>> >> >> >> > > If we are going to switch from fabricator we just might as
>> well
>> >> go
>> >> >> >> > > back to not using anything. Review board was really clunky and
>> >> >> >> > > confusing.
>> >> >> >> >
>> >> >> >> > I'm mostly +1 to that. If no one is supporting phabricator, then
>> >> it
>> >> >> >> > won't work for long. Personally, I'd love it if we could move
>> >> Hive to
>> >> >> >> > git completely. Has anyone used gerrit? The videos of it make it
>> >> look
>> >> >> >> > better than sliced bread.
>> >> >> >> >
>> >> >> >> > -- Owen
>> >> >> >> >
>> >> >> >>
>> >> >>
>> >>
>> >
>> >
>>
Re: Problems with Arc/Phabricator
Posted by Carl Steinbach <ca...@cloudera.com>.
Has the phabricator site stopped working for anyone else? As of today I'm
not longer able to view review requests. For example:
https://reviews.facebook.net/D3075
Produces the following output:
<br />
<b>Fatal error</b>: Undefined class constant 'COMMITTED' in
<b>/var/www/reviews.facebook.net/phabricator/src/applications/differential/storage/revision/DifferentialRevision.php</b>
on line <b>209</b><br />
>>> UNRECOVERABLE FATAL ERROR <<<
Undefined class constant 'COMMITTED'
/var/www/reviews.facebook.net/phabricator/src/applications/differential/storage/revision/DifferentialRevision.php:209
┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻
Any help would be much appreciated.
Thanks.
Carl
On Tue, May 8, 2012 at 1:47 PM, Ashutosh Chauhan <ha...@apache.org>wrote:
> Made some progress on using arc/phab on ubuntu. epriestley helped a ton
> over at #phabricator irc channel. Thanks, Evan!
> Now, able to make arc work on ubuntu, but seems like jira integration is
> broken. Hit the following problem:
>
> $arc diff —jira HIVE-3008
>
> PHP Fatal error: Class 'ArcanistDifferentialRevisionRef' not found in
> /home/ashutosh/workspace/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php on
> line 201
>
> Fatal error: Class 'ArcanistDifferentialRevisionRef' not found in
> /home/ashutosh/workspace/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php on
> line 201
>
> Even with this error diff did get generated but it was not posted back on
> jira. Evan is working on a patch to fix this.
>
> He is also discussing with Facebook folks on how to tackle these issues in
> long term. Discussion is going on at https://secure.phabricator.com/T1206
>
> I will request people who are actively working on Hive to follow the
> discussion on this ticket.
>
>
> Thanks,
>
> Ashutosh
>
>
>
> On Thu, Apr 19, 2012 at 5:24 PM, Ashutosh Chauhan <hashutosh@apache.org
> >wrote:
>
> > Problem while using arc on ubuntu
> >
> > $ arc patch D2871
> > ARC: Cannot mix P and A
> > UNIX: No such file or directory
> >
> > Any ideas whats up there.
> >
> > Thanks,
> > Ashutosh
> >
> > On Thu, Apr 19, 2012 at 17:19, Edward Capriolo <edlinuxguru@gmail.com
> >wrote:
> >
> >> Just throwing this out there. The phabricator IRC has more people and
> >> is usually more active then Hive IRC.
> >>
> >> #JustSaying...
> >>
> >> On Thu, Apr 19, 2012 at 7:35 PM, Ashutosh Chauhan <hashutosh@apache.org
> >
> >> wrote:
> >> > Hit a new problem with arc today:
> >> >
> >> > Fatal error: Uncaught exception 'Exception' with message 'Host
> returned
> >> > HTTP/200, but invalid JSON data in response to a Conduit method call:
> >> > <br />
> >> > <b>Warning</b>: Unknown: POST Content-Length of 9079953 bytes exceeds
> >> the
> >> > limit of 8388608 bytes in <b>Unknown</b> on line <b>0</b><br />
> >> >
> >>
> for(;;);{"result":null,"error_code":"ERR-INVALID-SESSION","error_info":"Session
> >> > key is not present."}' in
> >> >
> >>
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php:48
> >> > Stack trace:
> >> > #0
> >> >
> >>
> /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(62):
> >> > ConduitFuture->didReceiveResult(Array)
> >> > #1
> >> >
> >>
> /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(39):
> >> > FutureProxy->getResult()
> >> > #2
> >> >
> >>
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitClient.php(52):
> >> > FutureProxy->resolve()
> >> > #3
> >> >
> >>
> /Users/ashutosh/work/hive/arcanist/src/workflow/diff/ArcanistDiffWorkflow.php(341):
> >> > ConduitClient->callMethodSynchronous('differential.cr...', Array)
> >> > #4 /Users/ashutosh/work/hive/arcanist/scripts/arcanist.php(266):
> >> > ArcanistDiffWo in
> >> >
> >>
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php on
> >> > line 48
> >> >
> >> >
> >> > Any ideas how to solve this?
> >> >
> >> > Thanks,
> >> > Ashutosh
> >> >
> >> > On Wed, Apr 11, 2012 at 18:37, Edward Capriolo <edlinuxguru@gmail.com
> >> >wrote:
> >> >
> >> >> I think the most practical solution is try and use arc/phab and then
> >> >> if there is a problem fall back to Jira and do it the old way.
> >> >>
> >> >> Edward
> >> >>
> >> >> On Wed, Apr 11, 2012 at 7:17 PM, Carl Steinbach <ca...@cloudera.com>
> >> wrote:
> >> >> > +1 to switching over to Git.
> >> >> >
> >> >> > As for the rest of the Phabricator/Gerrit/Reviewboard discussion, I
> >> think
> >> >> > we should pick this up again at the contributor meeting on
> Wednesday.
> >> >> >
> >> >> > Thanks.
> >> >> >
> >> >> > Carl
> >> >> >
> >> >> > On Wed, Apr 11, 2012 at 12:19 PM, Ashutosh Chauhan <
> >> hashutosh@apache.org
> >> >> >wrote:
> >> >> >
> >> >> >> +1 on moving away from arc/phabricator. It works great when it
> >> works,
> >> >> but
> >> >> >> most of the time it doesnt work.
> >> >> >>
> >> >> >> Ashutosh
> >> >> >>
> >> >> >> On Wed, Apr 11, 2012 at 11:57, Owen O'Malley <om...@apache.org>
> >> >> wrote:
> >> >> >>
> >> >> >> > On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <
> >> >> edlinuxguru@gmail.com
> >> >> >> >
> >> >> >> > wrote:
> >> >> >> > > If we are going to switch from fabricator we just might as
> well
> >> go
> >> >> >> > > back to not using anything. Review board was really clunky and
> >> >> >> > > confusing.
> >> >> >> >
> >> >> >> > I'm mostly +1 to that. If no one is supporting phabricator, then
> >> it
> >> >> >> > won't work for long. Personally, I'd love it if we could move
> >> Hive to
> >> >> >> > git completely. Has anyone used gerrit? The videos of it make it
> >> look
> >> >> >> > better than sliced bread.
> >> >> >> >
> >> >> >> > -- Owen
> >> >> >> >
> >> >> >>
> >> >>
> >>
> >
> >
>
Re: Problems with Arc/Phabricator
Posted by Ashutosh Chauhan <ha...@apache.org>.
Made some progress on using arc/phab on ubuntu. epriestley helped a ton
over at #phabricator irc channel. Thanks, Evan!
Now, able to make arc work on ubuntu, but seems like jira integration is
broken. Hit the following problem:
$arc diff —jira HIVE-3008
PHP Fatal error: Class 'ArcanistDifferentialRevisionRef' not found in
/home/ashutosh/workspace/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php on
line 201
Fatal error: Class 'ArcanistDifferentialRevisionRef' not found in
/home/ashutosh/workspace/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php on
line 201
Even with this error diff did get generated but it was not posted back on
jira. Evan is working on a patch to fix this.
He is also discussing with Facebook folks on how to tackle these issues in
long term. Discussion is going on at https://secure.phabricator.com/T1206
I will request people who are actively working on Hive to follow the
discussion on this ticket.
Thanks,
Ashutosh
On Thu, Apr 19, 2012 at 5:24 PM, Ashutosh Chauhan <ha...@apache.org>wrote:
> Problem while using arc on ubuntu
>
> $ arc patch D2871
> ARC: Cannot mix P and A
> UNIX: No such file or directory
>
> Any ideas whats up there.
>
> Thanks,
> Ashutosh
>
> On Thu, Apr 19, 2012 at 17:19, Edward Capriolo <ed...@gmail.com>wrote:
>
>> Just throwing this out there. The phabricator IRC has more people and
>> is usually more active then Hive IRC.
>>
>> #JustSaying...
>>
>> On Thu, Apr 19, 2012 at 7:35 PM, Ashutosh Chauhan <ha...@apache.org>
>> wrote:
>> > Hit a new problem with arc today:
>> >
>> > Fatal error: Uncaught exception 'Exception' with message 'Host returned
>> > HTTP/200, but invalid JSON data in response to a Conduit method call:
>> > <br />
>> > <b>Warning</b>: Unknown: POST Content-Length of 9079953 bytes exceeds
>> the
>> > limit of 8388608 bytes in <b>Unknown</b> on line <b>0</b><br />
>> >
>> for(;;);{"result":null,"error_code":"ERR-INVALID-SESSION","error_info":"Session
>> > key is not present."}' in
>> >
>> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php:48
>> > Stack trace:
>> > #0
>> >
>> /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(62):
>> > ConduitFuture->didReceiveResult(Array)
>> > #1
>> >
>> /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(39):
>> > FutureProxy->getResult()
>> > #2
>> >
>> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitClient.php(52):
>> > FutureProxy->resolve()
>> > #3
>> >
>> /Users/ashutosh/work/hive/arcanist/src/workflow/diff/ArcanistDiffWorkflow.php(341):
>> > ConduitClient->callMethodSynchronous('differential.cr...', Array)
>> > #4 /Users/ashutosh/work/hive/arcanist/scripts/arcanist.php(266):
>> > ArcanistDiffWo in
>> >
>> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php on
>> > line 48
>> >
>> >
>> > Any ideas how to solve this?
>> >
>> > Thanks,
>> > Ashutosh
>> >
>> > On Wed, Apr 11, 2012 at 18:37, Edward Capriolo <edlinuxguru@gmail.com
>> >wrote:
>> >
>> >> I think the most practical solution is try and use arc/phab and then
>> >> if there is a problem fall back to Jira and do it the old way.
>> >>
>> >> Edward
>> >>
>> >> On Wed, Apr 11, 2012 at 7:17 PM, Carl Steinbach <ca...@cloudera.com>
>> wrote:
>> >> > +1 to switching over to Git.
>> >> >
>> >> > As for the rest of the Phabricator/Gerrit/Reviewboard discussion, I
>> think
>> >> > we should pick this up again at the contributor meeting on Wednesday.
>> >> >
>> >> > Thanks.
>> >> >
>> >> > Carl
>> >> >
>> >> > On Wed, Apr 11, 2012 at 12:19 PM, Ashutosh Chauhan <
>> hashutosh@apache.org
>> >> >wrote:
>> >> >
>> >> >> +1 on moving away from arc/phabricator. It works great when it
>> works,
>> >> but
>> >> >> most of the time it doesnt work.
>> >> >>
>> >> >> Ashutosh
>> >> >>
>> >> >> On Wed, Apr 11, 2012 at 11:57, Owen O'Malley <om...@apache.org>
>> >> wrote:
>> >> >>
>> >> >> > On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <
>> >> edlinuxguru@gmail.com
>> >> >> >
>> >> >> > wrote:
>> >> >> > > If we are going to switch from fabricator we just might as well
>> go
>> >> >> > > back to not using anything. Review board was really clunky and
>> >> >> > > confusing.
>> >> >> >
>> >> >> > I'm mostly +1 to that. If no one is supporting phabricator, then
>> it
>> >> >> > won't work for long. Personally, I'd love it if we could move
>> Hive to
>> >> >> > git completely. Has anyone used gerrit? The videos of it make it
>> look
>> >> >> > better than sliced bread.
>> >> >> >
>> >> >> > -- Owen
>> >> >> >
>> >> >>
>> >>
>>
>
>
Re: Problems with Arc/Phabricator
Posted by Ashutosh Chauhan <ha...@apache.org>.
Problem while using arc on ubuntu
$ arc patch D2871
ARC: Cannot mix P and A
UNIX: No such file or directory
Any ideas whats up there.
Thanks,
Ashutosh
On Thu, Apr 19, 2012 at 17:19, Edward Capriolo <ed...@gmail.com>wrote:
> Just throwing this out there. The phabricator IRC has more people and
> is usually more active then Hive IRC.
>
> #JustSaying...
>
> On Thu, Apr 19, 2012 at 7:35 PM, Ashutosh Chauhan <ha...@apache.org>
> wrote:
> > Hit a new problem with arc today:
> >
> > Fatal error: Uncaught exception 'Exception' with message 'Host returned
> > HTTP/200, but invalid JSON data in response to a Conduit method call:
> > <br />
> > <b>Warning</b>: Unknown: POST Content-Length of 9079953 bytes exceeds
> the
> > limit of 8388608 bytes in <b>Unknown</b> on line <b>0</b><br />
> >
> for(;;);{"result":null,"error_code":"ERR-INVALID-SESSION","error_info":"Session
> > key is not present."}' in
> >
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php:48
> > Stack trace:
> > #0
> > /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(62):
> > ConduitFuture->didReceiveResult(Array)
> > #1
> > /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(39):
> > FutureProxy->getResult()
> > #2
> >
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitClient.php(52):
> > FutureProxy->resolve()
> > #3
> >
> /Users/ashutosh/work/hive/arcanist/src/workflow/diff/ArcanistDiffWorkflow.php(341):
> > ConduitClient->callMethodSynchronous('differential.cr...', Array)
> > #4 /Users/ashutosh/work/hive/arcanist/scripts/arcanist.php(266):
> > ArcanistDiffWo in
> > /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php
> on
> > line 48
> >
> >
> > Any ideas how to solve this?
> >
> > Thanks,
> > Ashutosh
> >
> > On Wed, Apr 11, 2012 at 18:37, Edward Capriolo <edlinuxguru@gmail.com
> >wrote:
> >
> >> I think the most practical solution is try and use arc/phab and then
> >> if there is a problem fall back to Jira and do it the old way.
> >>
> >> Edward
> >>
> >> On Wed, Apr 11, 2012 at 7:17 PM, Carl Steinbach <ca...@cloudera.com>
> wrote:
> >> > +1 to switching over to Git.
> >> >
> >> > As for the rest of the Phabricator/Gerrit/Reviewboard discussion, I
> think
> >> > we should pick this up again at the contributor meeting on Wednesday.
> >> >
> >> > Thanks.
> >> >
> >> > Carl
> >> >
> >> > On Wed, Apr 11, 2012 at 12:19 PM, Ashutosh Chauhan <
> hashutosh@apache.org
> >> >wrote:
> >> >
> >> >> +1 on moving away from arc/phabricator. It works great when it works,
> >> but
> >> >> most of the time it doesnt work.
> >> >>
> >> >> Ashutosh
> >> >>
> >> >> On Wed, Apr 11, 2012 at 11:57, Owen O'Malley <om...@apache.org>
> >> wrote:
> >> >>
> >> >> > On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <
> >> edlinuxguru@gmail.com
> >> >> >
> >> >> > wrote:
> >> >> > > If we are going to switch from fabricator we just might as well
> go
> >> >> > > back to not using anything. Review board was really clunky and
> >> >> > > confusing.
> >> >> >
> >> >> > I'm mostly +1 to that. If no one is supporting phabricator, then it
> >> >> > won't work for long. Personally, I'd love it if we could move Hive
> to
> >> >> > git completely. Has anyone used gerrit? The videos of it make it
> look
> >> >> > better than sliced bread.
> >> >> >
> >> >> > -- Owen
> >> >> >
> >> >>
> >>
>
Re: Problems with Arc/Phabricator
Posted by Edward Capriolo <ed...@gmail.com>.
Just throwing this out there. The phabricator IRC has more people and
is usually more active then Hive IRC.
#JustSaying...
On Thu, Apr 19, 2012 at 7:35 PM, Ashutosh Chauhan <ha...@apache.org> wrote:
> Hit a new problem with arc today:
>
> Fatal error: Uncaught exception 'Exception' with message 'Host returned
> HTTP/200, but invalid JSON data in response to a Conduit method call:
> <br />
> <b>Warning</b>: Unknown: POST Content-Length of 9079953 bytes exceeds the
> limit of 8388608 bytes in <b>Unknown</b> on line <b>0</b><br />
> for(;;);{"result":null,"error_code":"ERR-INVALID-SESSION","error_info":"Session
> key is not present."}' in
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php:48
> Stack trace:
> #0
> /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(62):
> ConduitFuture->didReceiveResult(Array)
> #1
> /Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(39):
> FutureProxy->getResult()
> #2
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitClient.php(52):
> FutureProxy->resolve()
> #3
> /Users/ashutosh/work/hive/arcanist/src/workflow/diff/ArcanistDiffWorkflow.php(341):
> ConduitClient->callMethodSynchronous('differential.cr...', Array)
> #4 /Users/ashutosh/work/hive/arcanist/scripts/arcanist.php(266):
> ArcanistDiffWo in
> /Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php on
> line 48
>
>
> Any ideas how to solve this?
>
> Thanks,
> Ashutosh
>
> On Wed, Apr 11, 2012 at 18:37, Edward Capriolo <ed...@gmail.com>wrote:
>
>> I think the most practical solution is try and use arc/phab and then
>> if there is a problem fall back to Jira and do it the old way.
>>
>> Edward
>>
>> On Wed, Apr 11, 2012 at 7:17 PM, Carl Steinbach <ca...@cloudera.com> wrote:
>> > +1 to switching over to Git.
>> >
>> > As for the rest of the Phabricator/Gerrit/Reviewboard discussion, I think
>> > we should pick this up again at the contributor meeting on Wednesday.
>> >
>> > Thanks.
>> >
>> > Carl
>> >
>> > On Wed, Apr 11, 2012 at 12:19 PM, Ashutosh Chauhan <hashutosh@apache.org
>> >wrote:
>> >
>> >> +1 on moving away from arc/phabricator. It works great when it works,
>> but
>> >> most of the time it doesnt work.
>> >>
>> >> Ashutosh
>> >>
>> >> On Wed, Apr 11, 2012 at 11:57, Owen O'Malley <om...@apache.org>
>> wrote:
>> >>
>> >> > On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <
>> edlinuxguru@gmail.com
>> >> >
>> >> > wrote:
>> >> > > If we are going to switch from fabricator we just might as well go
>> >> > > back to not using anything. Review board was really clunky and
>> >> > > confusing.
>> >> >
>> >> > I'm mostly +1 to that. If no one is supporting phabricator, then it
>> >> > won't work for long. Personally, I'd love it if we could move Hive to
>> >> > git completely. Has anyone used gerrit? The videos of it make it look
>> >> > better than sliced bread.
>> >> >
>> >> > -- Owen
>> >> >
>> >>
>>
Re: Problems with Arc/Phabricator
Posted by Ashutosh Chauhan <ha...@apache.org>.
Hit a new problem with arc today:
Fatal error: Uncaught exception 'Exception' with message 'Host returned
HTTP/200, but invalid JSON data in response to a Conduit method call:
<br />
<b>Warning</b>: Unknown: POST Content-Length of 9079953 bytes exceeds the
limit of 8388608 bytes in <b>Unknown</b> on line <b>0</b><br />
for(;;);{"result":null,"error_code":"ERR-INVALID-SESSION","error_info":"Session
key is not present."}' in
/Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php:48
Stack trace:
#0
/Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(62):
ConduitFuture->didReceiveResult(Array)
#1
/Users/ashutosh/work/hive/libphutil/src/future/proxy/FutureProxy.php(39):
FutureProxy->getResult()
#2
/Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitClient.php(52):
FutureProxy->resolve()
#3
/Users/ashutosh/work/hive/arcanist/src/workflow/diff/ArcanistDiffWorkflow.php(341):
ConduitClient->callMethodSynchronous('differential.cr...', Array)
#4 /Users/ashutosh/work/hive/arcanist/scripts/arcanist.php(266):
ArcanistDiffWo in
/Users/ashutosh/work/hive/libphutil/src/conduit/client/ConduitFuture.php on
line 48
Any ideas how to solve this?
Thanks,
Ashutosh
On Wed, Apr 11, 2012 at 18:37, Edward Capriolo <ed...@gmail.com>wrote:
> I think the most practical solution is try and use arc/phab and then
> if there is a problem fall back to Jira and do it the old way.
>
> Edward
>
> On Wed, Apr 11, 2012 at 7:17 PM, Carl Steinbach <ca...@cloudera.com> wrote:
> > +1 to switching over to Git.
> >
> > As for the rest of the Phabricator/Gerrit/Reviewboard discussion, I think
> > we should pick this up again at the contributor meeting on Wednesday.
> >
> > Thanks.
> >
> > Carl
> >
> > On Wed, Apr 11, 2012 at 12:19 PM, Ashutosh Chauhan <hashutosh@apache.org
> >wrote:
> >
> >> +1 on moving away from arc/phabricator. It works great when it works,
> but
> >> most of the time it doesnt work.
> >>
> >> Ashutosh
> >>
> >> On Wed, Apr 11, 2012 at 11:57, Owen O'Malley <om...@apache.org>
> wrote:
> >>
> >> > On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <
> edlinuxguru@gmail.com
> >> >
> >> > wrote:
> >> > > If we are going to switch from fabricator we just might as well go
> >> > > back to not using anything. Review board was really clunky and
> >> > > confusing.
> >> >
> >> > I'm mostly +1 to that. If no one is supporting phabricator, then it
> >> > won't work for long. Personally, I'd love it if we could move Hive to
> >> > git completely. Has anyone used gerrit? The videos of it make it look
> >> > better than sliced bread.
> >> >
> >> > -- Owen
> >> >
> >>
>
Re: Problems with Arc/Phabricator
Posted by Edward Capriolo <ed...@gmail.com>.
I think the most practical solution is try and use arc/phab and then
if there is a problem fall back to Jira and do it the old way.
Edward
On Wed, Apr 11, 2012 at 7:17 PM, Carl Steinbach <ca...@cloudera.com> wrote:
> +1 to switching over to Git.
>
> As for the rest of the Phabricator/Gerrit/Reviewboard discussion, I think
> we should pick this up again at the contributor meeting on Wednesday.
>
> Thanks.
>
> Carl
>
> On Wed, Apr 11, 2012 at 12:19 PM, Ashutosh Chauhan <ha...@apache.org>wrote:
>
>> +1 on moving away from arc/phabricator. It works great when it works, but
>> most of the time it doesnt work.
>>
>> Ashutosh
>>
>> On Wed, Apr 11, 2012 at 11:57, Owen O'Malley <om...@apache.org> wrote:
>>
>> > On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <edlinuxguru@gmail.com
>> >
>> > wrote:
>> > > If we are going to switch from fabricator we just might as well go
>> > > back to not using anything. Review board was really clunky and
>> > > confusing.
>> >
>> > I'm mostly +1 to that. If no one is supporting phabricator, then it
>> > won't work for long. Personally, I'd love it if we could move Hive to
>> > git completely. Has anyone used gerrit? The videos of it make it look
>> > better than sliced bread.
>> >
>> > -- Owen
>> >
>>
Re: Problems with Arc/Phabricator
Posted by Carl Steinbach <ca...@cloudera.com>.
+1 to switching over to Git.
As for the rest of the Phabricator/Gerrit/Reviewboard discussion, I think
we should pick this up again at the contributor meeting on Wednesday.
Thanks.
Carl
On Wed, Apr 11, 2012 at 12:19 PM, Ashutosh Chauhan <ha...@apache.org>wrote:
> +1 on moving away from arc/phabricator. It works great when it works, but
> most of the time it doesnt work.
>
> Ashutosh
>
> On Wed, Apr 11, 2012 at 11:57, Owen O'Malley <om...@apache.org> wrote:
>
> > On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <edlinuxguru@gmail.com
> >
> > wrote:
> > > If we are going to switch from fabricator we just might as well go
> > > back to not using anything. Review board was really clunky and
> > > confusing.
> >
> > I'm mostly +1 to that. If no one is supporting phabricator, then it
> > won't work for long. Personally, I'd love it if we could move Hive to
> > git completely. Has anyone used gerrit? The videos of it make it look
> > better than sliced bread.
> >
> > -- Owen
> >
>
Re: Problems with Arc/Phabricator
Posted by Ashutosh Chauhan <ha...@apache.org>.
+1 on moving away from arc/phabricator. It works great when it works, but
most of the time it doesnt work.
Ashutosh
On Wed, Apr 11, 2012 at 11:57, Owen O'Malley <om...@apache.org> wrote:
> On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <ed...@gmail.com>
> wrote:
> > If we are going to switch from fabricator we just might as well go
> > back to not using anything. Review board was really clunky and
> > confusing.
>
> I'm mostly +1 to that. If no one is supporting phabricator, then it
> won't work for long. Personally, I'd love it if we could move Hive to
> git completely. Has anyone used gerrit? The videos of it make it look
> better than sliced bread.
>
> -- Owen
>
Re: Problems with Arc/Phabricator
Posted by Owen O'Malley <om...@apache.org>.
On Wed, Apr 11, 2012 at 11:48 AM, Edward Capriolo <ed...@gmail.com> wrote:
> If we are going to switch from fabricator we just might as well go
> back to not using anything. Review board was really clunky and
> confusing.
I'm mostly +1 to that. If no one is supporting phabricator, then it
won't work for long. Personally, I'd love it if we could move Hive to
git completely. Has anyone used gerrit? The videos of it make it look
better than sliced bread.
-- Owen
Re: Problems with Arc/Phabricator
Posted by Edward Capriolo <ed...@gmail.com>.
If we are going to switch from fabricator we just might as well go
back to not using anything. Review board was really clunky and
confusing.
Edward
On Tue, Apr 10, 2012 at 9:27 PM, Kevin Wilfong <ke...@fb.com> wrote:
> +John Sichi as he did a lot of the work on getting Hive to use Phabricator.
>
> Is there anything preventing people from using Review Board for patches now, except maybe convention? As for applying patches, in either case, you can download the patch from the JIRA site.
>
> To be clear, I am not trying to aggressively force Phabricator on Hive, these are just suggestions.
>
> From: Carl Steinbach <ca...@cloudera.com>>
> Date: Tue, 10 Apr 2012 18:10:44 -0700
> To: Microsoft Office User <ke...@fb.com>>
> Cc: "dev@hive.apache.org<ma...@hive.apache.org>" <de...@hive.apache.org>>
> Subject: Re: Problems with Arc/Phabricator
>
> Ok, I'll submit an issue. But then what? Who is going to fix it? Perhaps in the meantime we should just switch back to using reviewboard while we wait for Arc and Phabricator to mature as open source projects.
>
>
> On Tue, Apr 10, 2012 at 5:58 PM, Kevin Wilfong <ke...@fb.com>> wrote:
> There's a list of ways to report issues/get help on the side bar of this
> site http://phabricator.org/
>
> It suggests #phabricator <irc://chat.freenode.net/phabricator<http://chat.freenode.net/phabricator>> as the best
> place to get help with issues.
>
> On 4/10/12 5:42 PM, "Carl Steinbach" <ca...@cloudera.com>> wrote:
>
>>Arc won't let me apply the patch for HIVE-2646. I've also noticed some
>>other problems (e.g. missing TEST PLAN in checkin comments), and was
>>wondering how we can get these problems resolved? Since most of this work
>>was done at Facebook, who is the designated point of contact for
>>Arc/Phabricator issues going forward?
>>
>>
>>Here's the error I get when applying HIVE-2646:
>>
>>% arc patch D2133 --trace
>>Loading phutil library 'arc_jira_lib' from
>>'/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>>>>> [0] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>>--show-cdup)
>><<< [0] <exec> 13,599 us
>>>>> [1] <conduit> differential.getdiff()
>><<< [1] <conduit> 608,237 us
>>>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git apply
>>>>>--index
>>--reject)
>><<< [2] <exec> 13,178 us
>>
>>Fatal error: Uncaught exception 'CommandException' with message 'Command
>>'(cd '/Users/carl/Work/repos/hive-test/'; git apply --index --reject)'
>>failed with error #128:
>>stdout:
>>
>>stderr:
>><stdin>:10: trailing whitespace.
>>
>><stdin>:111: trailing whitespace.
>> <fileset dir="${build.ivy.lib.dir}/default" includes="*.jar"
>>fatal: corrupt patch at line 609
>>
>>' in /Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php:346
>>Stack trace:
>>#0
>>/Users/carl/.local/pkg/arcanist/src/workflow/patch/ArcanistPatchWorkflow.p
>>hp(412):
>>ExecFuture->resolvex()
>>#1 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(266):
>>ArcanistPatchWorkflow->run()
>>#2 {main}
>> thrown in
>>/Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php
>>on line 346
>>
>>
>>Thanks.
>>
>>Carl
>
>
Re: Problems with Arc/Phabricator
Posted by Kevin Wilfong <ke...@fb.com>.
+John Sichi as he did a lot of the work on getting Hive to use Phabricator.
Is there anything preventing people from using Review Board for patches now, except maybe convention? As for applying patches, in either case, you can download the patch from the JIRA site.
To be clear, I am not trying to aggressively force Phabricator on Hive, these are just suggestions.
From: Carl Steinbach <ca...@cloudera.com>>
Date: Tue, 10 Apr 2012 18:10:44 -0700
To: Microsoft Office User <ke...@fb.com>>
Cc: "dev@hive.apache.org<ma...@hive.apache.org>" <de...@hive.apache.org>>
Subject: Re: Problems with Arc/Phabricator
Ok, I'll submit an issue. But then what? Who is going to fix it? Perhaps in the meantime we should just switch back to using reviewboard while we wait for Arc and Phabricator to mature as open source projects.
On Tue, Apr 10, 2012 at 5:58 PM, Kevin Wilfong <ke...@fb.com>> wrote:
There's a list of ways to report issues/get help on the side bar of this
site http://phabricator.org/
It suggests #phabricator <irc://chat.freenode.net/phabricator<http://chat.freenode.net/phabricator>> as the best
place to get help with issues.
On 4/10/12 5:42 PM, "Carl Steinbach" <ca...@cloudera.com>> wrote:
>Arc won't let me apply the patch for HIVE-2646. I've also noticed some
>other problems (e.g. missing TEST PLAN in checkin comments), and was
>wondering how we can get these problems resolved? Since most of this work
>was done at Facebook, who is the designated point of contact for
>Arc/Phabricator issues going forward?
>
>
>Here's the error I get when applying HIVE-2646:
>
>% arc patch D2133 --trace
>Loading phutil library 'arc_jira_lib' from
>'/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>>>> [0] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>--show-cdup)
><<< [0] <exec> 13,599 us
>>>> [1] <conduit> differential.getdiff()
><<< [1] <conduit> 608,237 us
>>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git apply
>>>>--index
>--reject)
><<< [2] <exec> 13,178 us
>
>Fatal error: Uncaught exception 'CommandException' with message 'Command
>'(cd '/Users/carl/Work/repos/hive-test/'; git apply --index --reject)'
>failed with error #128:
>stdout:
>
>stderr:
><stdin>:10: trailing whitespace.
>
><stdin>:111: trailing whitespace.
> <fileset dir="${build.ivy.lib.dir}/default" includes="*.jar"
>fatal: corrupt patch at line 609
>
>' in /Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php:346
>Stack trace:
>#0
>/Users/carl/.local/pkg/arcanist/src/workflow/patch/ArcanistPatchWorkflow.p
>hp(412):
>ExecFuture->resolvex()
>#1 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(266):
>ArcanistPatchWorkflow->run()
>#2 {main}
> thrown in
>/Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php
>on line 346
>
>
>Thanks.
>
>Carl
Re: Problems with Arc/Phabricator
Posted by Carl Steinbach <ca...@cloudera.com>.
Ok, I'll submit an issue. But then what? Who is going to fix it? Perhaps in
the meantime we should just switch back to using reviewboard while we wait
for Arc and Phabricator to mature as open source projects.
On Tue, Apr 10, 2012 at 5:58 PM, Kevin Wilfong <ke...@fb.com> wrote:
> There's a list of ways to report issues/get help on the side bar of this
> site http://phabricator.org/
>
> It suggests #phabricator <irc://chat.freenode.net/phabricator> as the best
> place to get help with issues.
>
> On 4/10/12 5:42 PM, "Carl Steinbach" <ca...@cloudera.com> wrote:
>
> >Arc won't let me apply the patch for HIVE-2646. I've also noticed some
> >other problems (e.g. missing TEST PLAN in checkin comments), and was
> >wondering how we can get these problems resolved? Since most of this work
> >was done at Facebook, who is the designated point of contact for
> >Arc/Phabricator issues going forward?
> >
> >
> >Here's the error I get when applying HIVE-2646:
> >
> >% arc patch D2133 --trace
> >Loading phutil library 'arc_jira_lib' from
> >'/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
> >>>> [0] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
> >--show-cdup)
> ><<< [0] <exec> 13,599 us
> >>>> [1] <conduit> differential.getdiff()
> ><<< [1] <conduit> 608,237 us
> >>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git apply
> >>>>--index
> >--reject)
> ><<< [2] <exec> 13,178 us
> >
> >Fatal error: Uncaught exception 'CommandException' with message 'Command
> >'(cd '/Users/carl/Work/repos/hive-test/'; git apply --index --reject)'
> >failed with error #128:
> >stdout:
> >
> >stderr:
> ><stdin>:10: trailing whitespace.
> >
> ><stdin>:111: trailing whitespace.
> > <fileset dir="${build.ivy.lib.dir}/default" includes="*.jar"
> >fatal: corrupt patch at line 609
> >
> >' in /Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php:346
> >Stack trace:
> >#0
> >/Users/carl/.local/pkg/arcanist/src/workflow/patch/ArcanistPatchWorkflow.p
> >hp(412):
> >ExecFuture->resolvex()
> >#1 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(266):
> >ArcanistPatchWorkflow->run()
> >#2 {main}
> > thrown in
> >/Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php
> >on line 346
> >
> >
> >Thanks.
> >
> >Carl
>
>
Re: Problems with Arc/Phabricator
Posted by Kevin Wilfong <ke...@fb.com>.
There's a list of ways to report issues/get help on the side bar of this
site http://phabricator.org/
It suggests #phabricator <irc://chat.freenode.net/phabricator> as the best
place to get help with issues.
On 4/10/12 5:42 PM, "Carl Steinbach" <ca...@cloudera.com> wrote:
>Arc won't let me apply the patch for HIVE-2646. I've also noticed some
>other problems (e.g. missing TEST PLAN in checkin comments), and was
>wondering how we can get these problems resolved? Since most of this work
>was done at Facebook, who is the designated point of contact for
>Arc/Phabricator issues going forward?
>
>
>Here's the error I get when applying HIVE-2646:
>
>% arc patch D2133 --trace
>Loading phutil library 'arc_jira_lib' from
>'/Users/carl/Work/repos/hive-test/.arc_jira_lib'...
>>>> [0] <exec> $ (cd '/Users/carl/Work/repos/hive-test'; git rev-parse
>--show-cdup)
><<< [0] <exec> 13,599 us
>>>> [1] <conduit> differential.getdiff()
><<< [1] <conduit> 608,237 us
>>>> [2] <exec> $ (cd '/Users/carl/Work/repos/hive-test/'; git apply
>>>>--index
>--reject)
><<< [2] <exec> 13,178 us
>
>Fatal error: Uncaught exception 'CommandException' with message 'Command
>'(cd '/Users/carl/Work/repos/hive-test/'; git apply --index --reject)'
>failed with error #128:
>stdout:
>
>stderr:
><stdin>:10: trailing whitespace.
>
><stdin>:111: trailing whitespace.
> <fileset dir="${build.ivy.lib.dir}/default" includes="*.jar"
>fatal: corrupt patch at line 609
>
>' in /Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php:346
>Stack trace:
>#0
>/Users/carl/.local/pkg/arcanist/src/workflow/patch/ArcanistPatchWorkflow.p
>hp(412):
>ExecFuture->resolvex()
>#1 /Users/carl/.local/pkg/arcanist/scripts/arcanist.php(266):
>ArcanistPatchWorkflow->run()
>#2 {main}
> thrown in
>/Users/carl/.local/pkg/libphutil/src/future/exec/ExecFuture.php
>on line 346
>
>
>Thanks.
>
>Carl