You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/04/21 08:59:33 UTC

[GitHub] [doris] jackwener opened a new pull request, #18902: [fix](Nereids): dead loop in FillUpMissingSlots

jackwener opened a new pull request, #18902:
URL: https://github.com/apache/doris/pull/18902

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   FillUpMissingSlots don't handle some cornel case, sometime we don't need fillup, we should return null
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morrySnow merged pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #18902:
URL: https://github.com/apache/doris/pull/18902


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1521091483

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1517513654

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1521091687

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1517696787

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1517943285

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1517943414

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1519060725

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1518946160

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1518947638

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1522698065

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1519444271

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1517882368

   run buildp0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1521481736

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jackwener commented on pull request #18902: [fix](Nereids): dead loop in FillUpMissingSlots

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #18902:
URL: https://github.com/apache/doris/pull/18902#issuecomment-1521812073

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org