[jira] [Comment Edited] (HIVE-17743) Add InterfaceAudience and InterfaceStability annotations for Thrift generated APIs

["Alan Gates (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-17743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197752#comment-16197752 ] 

Alan Gates edited comment on HIVE-17743 at 10/10/17 12:20 AM:
--------------------------------------------------------------

Ok, I misunderstood.  I think the standalone-metastore part of this patch looks good then.

I don't have an opinion on the right thing to do for service-rpc, whether it should depend on a separate module or hive-common.


was (Author: alangates):
Ok, misunderstood.  I think the standalone-metastore part of this patch looks good then.

I don't have an opinion on the right thing to do for service-rpc, whether it should depend on a separate module or hive-common.

> Add InterfaceAudience and InterfaceStability annotations for Thrift generated APIs
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-17743
>                 URL: https://issues.apache.org/jira/browse/HIVE-17743
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Thrift API
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>         Attachments: HIVE-17743.1.patch
>
>
> The Thrift generated files don't have {{InterfaceAudience}} or {{InterfaceStability}} annotations on them, mainly because all the files are auto-generated.
> We should add some code that auto-tags all the Java Thrift generated files with these annotations. This way even when they are re-generated, they still contain the annotations.
> We should be able to do this using the {{com.google.code.maven-replacer-plugin}} similar to what we do in {{standalone-metastore/pom.xml}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)