You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "zhaojinchao95 (via GitHub)" <gi...@apache.org> on 2023/06/29 15:03:35 UTC

[GitHub] [shardingsphere] zhaojinchao95 opened a new issue, #26704: Add unit test for MaskRuleChangedEventCreator

zhaojinchao95 opened a new issue, #26704:
URL: https://github.com/apache/shardingsphere/issues/26704

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] SwapnilPatil07 commented on issue #26704: Add unit test for MaskRuleChangedEventCreator

Posted by "SwapnilPatil07 (via GitHub)" <gi...@apache.org>.
SwapnilPatil07 commented on issue #26704:
URL: https://github.com/apache/shardingsphere/issues/26704#issuecomment-1631722945

   Thanks @yx9o ! 
   I am not able to find class `MaskRuleChangedEventCreator` in codebase.  It was removed in PR [26820](https://github.com/apache/shardingsphere/pull/26820/). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on issue #26704: Add unit test for MaskRuleChangedEventCreator

Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on issue #26704:
URL: https://github.com/apache/shardingsphere/issues/26704#issuecomment-1632651692

   Hi @SwapnilPatil07 , you are right, I noticed it was refactored, you can try adding unit tests for `NamedRuleItemChangedEventCreator` and `UniqueRuleItemChangedEventCreator`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on issue #26704: Add unit test for MaskRuleChangedEventCreator

Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on issue #26704:
URL: https://github.com/apache/shardingsphere/issues/26704#issuecomment-1631683638

   @SwapnilPatil07 Welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu closed issue #26704: Add unit test for MaskRuleChangedEventCreator

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #26704: Add unit test for MaskRuleChangedEventCreator
URL: https://github.com/apache/shardingsphere/issues/26704


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] SwapnilPatil07 commented on issue #26704: Add unit test for MaskRuleChangedEventCreator

Posted by "SwapnilPatil07 (via GitHub)" <gi...@apache.org>.
SwapnilPatil07 commented on issue #26704:
URL: https://github.com/apache/shardingsphere/issues/26704#issuecomment-1617455858

   I can work on this issue. Please assign it to me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org