[GitHub] [nifi] AxelSync commented on a change in pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

[GitBox <gi...@apache.org>]

AxelSync commented on a change in pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS
URL: https://github.com/apache/nifi/pull/3607#discussion_r307803671
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestMergeRecord.java
 ##########
 @@ -486,4 +486,52 @@ public void testDefragmentExpiredBinFailsOnTimeout() throws InterruptedException
         runner.assertTransferCount(MergeRecord.REL_ORIGINAL, 0);
         runner.assertTransferCount(MergeRecord.REL_FAILURE, 1);
     }
+
+    @Test
+    public void testMergeWithMinRecordsFromVariableRegistry() {
 
 Review comment:
   I created two because I found it more readable, what do you think? It's not a problem on creating one for both cases if you see it messy with two separate tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services