You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/10 16:52:26 UTC
[GitHub] [superset] ktmud opened a new issue #16173: [Chart] Less-blocking creating new chart flow
ktmud opened a new issue #16173:
URL: https://github.com/apache/superset/issues/16173
**Is your feature request related to a problem? Please describe.**
Currently "Create new chart" is disabled if users do not select a dataset, but the Dataset input is not very obvious given how much information there exists on the Chart Gallery page.
New users may not know how to proceed or feel frustrated when they did realize they need to select a dataset first.
**Describe the solution you'd like**
We could either:
1. Create two step screens for this flow, or
2. Add a tooltip on the disabled "Create new chart" button directing users to select a dataset, or
3. Adjust the visual structure of the Dataset select to make it more noticeable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-896328374
> We tried the two steps flow, but 1st step looks quite empty.
It won't be too empty if the datasets are rendered as tables similar to "Change datasets" modal on the Explore page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-898590184
@michael-s-molina This looks cool! I like how you give feedbacks on finished steps.
We should ask for some designer's eyes on this, but one small change I would probably make is to nudge the step number labels a tad smaller and/or adjust the spacing a little so it's more visually balanced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-896262536
> Related to #16008
>
> hmm maybe highlighting the dropdown is not enough.
> We tried the two steps flow, but 1st step looks quite empty. option 2 you mean adding tooltip when user hover on the CREATE NEW CHART?
> Can we keep the select highlight as long as no dataset is selected, instead of just the initial state? @michael-s-molina
We can't keep the dataset highlighted because we shouldn't mess with the focus behavior. If the user clicks on another area or presses the tab, the focus should change.
I'll try some ideas and post here some videos so we can decide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-897206389
If we go with Idea 2, can we maybe change the copy to "Please select both a Dataset and a Chart type to proceed"?
Idea 3 can maybe also help a little. E.g. add step numbers without splitting the flow into multiple screens:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-898590184
@michael-s-molina This looks cool! I like how you give feedbacks on finished steps.
We should ask for some designer's eyes on this, but one one small change I would probably make is to nudge the step number labels a tad smaller and/or adjust the spacing a little so it's more visually balanced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-896328374
> We tried the two steps flow, but 1st step looks quite empty.
It won't be too empty if the datasets are renders as tables similar to "Change datasets" modal on the Explore page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-897100580
@ktmud @junlincc I tested a few scenarios:
#### Only show the visualizations after selecting a dataset
The screen appeared empty and we had a flicking effect. Even if the user selects a dataset, the button will still be greyed out and the user may not know why. It's because he also needs to select a viz type.
#### Treat the screen as a form and validate the fields
Validating the dataset field and the viz type (showing red borders) looked weird because this screen is not similar to a form but more like a selector.
#### Applying @ktmud idea number 2 - Add a tooltip on the disabled "Create new chart" button directing users to select a dataset
This one seems to be the best approach. At the same time, we can inform the user of BOTH required fields in a non-intrusive way. It also fits well with the design of the page.
https://user-images.githubusercontent.com/70410625/129091423-1c241da2-89a7-43cd-89d1-96b07a62c139.mov
> It won't be too empty if the datasets are rendered as tables similar to "Change datasets" modal on the Explore page.
Currently, we are using the new select component to display the datasets. This gives us some nice features such as searching, lazy loading, and paginated fetch. Personally, I prefer the select over the table because it seems the more appropriate component for the type of selection that we are doing.
What do you think? Can we agree on @ktmud idea number 2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed issue #16173:
URL: https://github.com/apache/superset/issues/16173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-897900052
@ktmud @junlincc Just polishing the code now. I'll probably submit a PR tomorrow 🤩
https://user-images.githubusercontent.com/70410625/129254823-f1021072-1f28-43eb-8489-fa9d7a9855f2.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-897561225
> If we go with Idea 2, can we maybe change the copy to "Please select both a Dataset and a Chart type to proceed"?
Will do.
> Idea 3 can maybe also help a little. E.g. add step numbers without splitting
I really liked the idea. It's simple and helps to define the workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-896259653
Related to https://github.com/apache/superset/issues/16008
hmm maybe highlighting the dropdown is not enough.
We tried the two steps flow, but 1st step looks quite empty. option 2 you mean adding tooltip when user hover on the CREATE NEW CHART?
Can we keep the select highlight as long as no dataset is selected, instead of just the initial state? @michael-s-molina
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #16173: [Gallery] Less-blocking creating new chart flow
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #16173:
URL: https://github.com/apache/superset/issues/16173#issuecomment-897206389
If we go with Idea 2, can we maybe change the copy to "Please select both a Dataset and a Chart type to proceed"?
Idea 3 can maybe also help a little. E.g. add step numbers without splitting it to multiple screens:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org