You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/03/10 13:51:25 UTC
[GitHub] [lucene] donnerpeter opened a new pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration
donnerpeter opened a new pull request #3:
URL: https://github.com/apache/lucene/pull/3
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Word length could be checked before more materializing the whole word
# Solution
Use the spare bits in the hash table `int` and collision `byte` to encode word length, if it's short enough (almost always).
# Tests
No new tests, 10-15% speedup in `TestPerformance.de_suggest`.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] donnerpeter commented on a change in pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #3:
URL: https://github.com/apache/lucene/pull/3#discussion_r591534034
##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordStorage.java
##########
@@ -63,17 +75,14 @@
* <li>VINT: a delta pointer to the entry for the same word without the last character.
* Precisely, it's the difference of this entry's start and the prefix's entry start. 0 for
* single-character entries
- * <li>Optional, for non-leaf entries only:
+ * <li>(Optional, for hash-colliding entries only)
Review comment:
I've moved collision pointers before the `forms` data to avoid skipping over vInts on mismatches
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] donnerpeter commented on pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on pull request #3:
URL: https://github.com/apache/lucene/pull/3#issuecomment-795440529
Solr references probably should be removed from the checklist above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] donnerpeter commented on a change in pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #3:
URL: https://github.com/apache/lucene/pull/3#discussion_r591532603
##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##########
@@ -65,6 +65,7 @@
TrigramAutomaton automaton = new TrigramAutomaton(word);
dictionary.words.processAllWords(
+ Math.max(1, word.length() - 4),
Review comment:
We now pass minLength in addition to maxLength
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration
Posted by GitBox <gi...@apache.org>.
rmuir merged pull request #3:
URL: https://github.com/apache/lucene/pull/3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] donnerpeter commented on a change in pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #3:
URL: https://github.com/apache/lucene/pull/3#discussion_r591534034
##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordStorage.java
##########
@@ -63,17 +75,14 @@
* <li>VINT: a delta pointer to the entry for the same word without the last character.
* Precisely, it's the difference of this entry's start and the prefix's entry start. 0 for
* single-character entries
- * <li>Optional, for non-leaf entries only:
+ * <li>(Optional, for hash-colliding entries only)
Review comment:
I've moved this before the `forms` data to avoid skipping over vInts on mismatches
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] donnerpeter commented on a change in pull request #3: LUCENE-9830: Hunspell: store word length for faster dictionary lookup/enumeration
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #3:
URL: https://github.com/apache/lucene/pull/3#discussion_r591534034
##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordStorage.java
##########
@@ -63,17 +75,14 @@
* <li>VINT: a delta pointer to the entry for the same word without the last character.
* Precisely, it's the difference of this entry's start and the prefix's entry start. 0 for
* single-character entries
- * <li>Optional, for non-leaf entries only:
+ * <li>(Optional, for hash-colliding entries only)
Review comment:
I've moved collision info before the `forms` data to avoid skipping over vInts on mismatches
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org