You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/03/31 22:44:51 UTC
[kudu-CR](branch-1.17.x) [server] add 'slow scans' metric for tablet server
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19674
to review the following change.
Change subject: [server] add 'slow_scans' metric for tablet server
......................................................................
[server] add 'slow_scans' metric for tablet server
As a supplement to the slow scan display, I added
a new metric 'slow_scans' to facilitate our monitoring.
At the same time, I added test to ensure that the
new metric will take effect.
Change-Id: I51e64bc4602f0e1dd99207f7d4cf8883085eca9a
Reviewed-on: http://gerrit.cloudera.org:8080/19545
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
(cherry picked from commit 7133b894e87c705353753c25e83c56b683e6d805)
---
M src/kudu/tserver/scanners.cc
M src/kudu/tserver/scanners.h
M src/kudu/tserver/tablet_server-test.cc
3 files changed, 87 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/19674/1
--
To view, visit http://gerrit.cloudera.org:8080/19674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51e64bc4602f0e1dd99207f7d4cf8883085eca9a
Gerrit-Change-Number: 19674
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [server] add 'slow scans' metric for tablet server
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19674 )
Change subject: [server] add 'slow_scans' metric for tablet server
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I51e64bc4602f0e1dd99207f7d4cf8883085eca9a
Gerrit-Change-Number: 19674
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 01 Apr 2023 07:12:17 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [server] add 'slow scans' metric for tablet server
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19674 )
Change subject: [server] add 'slow_scans' metric for tablet server
......................................................................
[server] add 'slow_scans' metric for tablet server
As a supplement to the slow scan display, I added
a new metric 'slow_scans' to facilitate our monitoring.
At the same time, I added test to ensure that the
new metric will take effect.
Change-Id: I51e64bc4602f0e1dd99207f7d4cf8883085eca9a
Reviewed-on: http://gerrit.cloudera.org:8080/19545
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
(cherry picked from commit 7133b894e87c705353753c25e83c56b683e6d805)
Reviewed-on: http://gerrit.cloudera.org:8080/19674
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/tserver/scanners.cc
M src/kudu/tserver/scanners.h
M src/kudu/tserver/tablet_server-test.cc
3 files changed, 87 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yifan Zhang: Looks good to me, approved
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I51e64bc4602f0e1dd99207f7d4cf8883085eca9a
Gerrit-Change-Number: 19674
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [server] add 'slow scans' metric for tablet server
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19674 )
Change subject: [server] add 'slow_scans' metric for tablet server
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I51e64bc4602f0e1dd99207f7d4cf8883085eca9a
Gerrit-Change-Number: 19674
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 01 Apr 2023 02:34:28 +0000
Gerrit-HasComments: No