You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/14 02:07:17 UTC

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1169: Premerge for the distributed version

jt2594838 commented on a change in pull request #1169:
URL: https://github.com/apache/incubator-iotdb/pull/1169#discussion_r424830418



##########
File path: jdbc/src/main/java/org/apache/iotdb/jdbc/Config.java
##########
@@ -52,6 +52,6 @@ private Config(){}
 
   public static final String JDBC_DRIVER_NAME = "org.apache.iotdb.jdbc.IoTDBDriver";
 
-  public static boolean rpcThriftCompressionEnable = false;
+  public static boolean rpcThriftCompressionEnable = true;

Review comment:
       It is said in thrift that when the thrift structures are large and sent frequently, it will be overall better to enable compression, so I made the default compression true.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org