[jira] [Commented] (COLLECTIONS-458) AbstractUntypedCollectionDecorator - is collection allowed to be null?

["Thomas Neidhart (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COLLECTIONS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645270#comment-13645270 ] 

Thomas Neidhart commented on COLLECTIONS-458:
---------------------------------------------

I added the ctor with argument, but in fact we should delete the class as it is not used at all.
                
> AbstractUntypedCollectionDecorator<E, D> - is collection allowed to be null?
> ----------------------------------------------------------------------------
>
>                 Key: COLLECTIONS-458
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-458
>             Project: Commons Collections
>          Issue Type: Bug
>            Reporter: Sebb
>
> The public ctor for AbstractUntypedCollectionDecorator<E, D> takes no argument and so collection = null; however the protected ctor checks for collection parameter != null.
> The decorated() method says that all access to collection goes through it, and there is no setter.
> At present the only way to recover from calling the public ctor is for the sub-class to set collection directly.
> This is inconsistent.
> The class is abstract and there appear to be no concrete subclasses. Looks like the class might be superfluous, but if it is required, it should ideally have a private final collection field.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira