You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2025/05/09 07:20:56 UTC
Change in asterixdb[master]: [ASTERIXDB-3606][COMP]: Refactor plan representation: split PlanNode,...
From <pr...@apache.org>:
Attention is currently required from: preetham02@apache.org.
Hello Jenkins, Anon. E. Moose #1000171,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19604
to look at the new patch set (#22).
Change subject: [ASTERIXDB-3606][COMP]: Refactor plan representation: split PlanNode, use DatasetRegistry, replace index-based tracking
......................................................................
[ASTERIXDB-3606][COMP]: Refactor plan representation: split PlanNode, use DatasetRegistry, replace index-based tracking
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Replaces some integer array index variables with Java object references to enhance readability and reduce indexing errors.
- Introduces an abstract PlanNode class with concrete subclasses ScanPlanNode and JoinPlanNode, instead of using a single generic PlanNode for all node types.
- Implements a centralized DatasetRegistry to manage datasets, eliminating the need to track subsets using integers in various locations.
- Standardizes all LeafInput instances as RealLeafInput, removing the need to separately track LogicalOperators as leaf inputs.
Ext-ref: MB-66641
Change-Id: I5c5a670fb66b5d525af31a3e8eca1e0c429e7adc
---
D asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/PlanNode.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java
A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/DummyPlanNode.java
A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinPlanNode.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinCondition.java
A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/RealLeafInput.java
A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/ScanPlanNode.java
A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/AbstractPlanNode.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/PlanRegistry.java
A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/UnnestLeafInput.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/AbstractLeafInput.java
A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/DatasetRegistry.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java
15 files changed, 1,120 insertions(+), 771 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/04/19604/22
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19604
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I5c5a670fb66b5d525af31a3e8eca1e0c429e7adc
Gerrit-Change-Number: 19604
Gerrit-PatchSet: 22
Gerrit-Owner: preetham02@apache.org
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Attention: preetham02@apache.org
Gerrit-MessageType: newpatchset