[jira] [Commented] (SLING-10477) Review usage of UserEntryHandler in RecollectorVaultPackageScanner

["Angela Schreiber (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360860#comment-17360860 ] 

Angela Schreiber commented on SLING-10477:
------------------------------------------

[~kpauls] and myself were able to create a test that illustrates why the user-entry-handler in {{RecollectorVaultPackageScanner}} is required namely collection information about users/groups/system-users that allow to determine during the second phase if a given access control entry needs to be move to repo init (system user) or moved back to the package (users/groups). we additionally decided to add the group-entry-handler to make sure all principals defined in the content package(s) are identified during the first pass.

> Review usage of UserEntryHandler in RecollectorVaultPackageScanner
> ------------------------------------------------------------------
>
>                 Key: SLING-10477
>                 URL: https://issues.apache.org/jira/browse/SLING-10477
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content-Package to Feature Model Converter
>            Reporter: Angela Schreiber
>            Priority: Major
>
> during testing of SLING-10468 we noticed that {{UserEntryHandler}} has been added to the {{RecollectorVaultPackageScanner}} when SLING-8573 got fixed. it required an extra check for assembler being null in {{AbstractUserEntryHandler}}.
> [~kpauls], lets review if that is really needed and add dedicated tests for the original problem (in case they don't exist).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)