You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2016/03/12 01:23:36 UTC

Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44556/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Bugs: AMBARI-15360
    https://issues.apache.org/jira/browse/AMBARI-15360


Repository: ambari


Description
-------

- HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa 
  ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 59c717b 
  ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py c94d956 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 3a90164 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 9084c87 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d0924b9 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 459845b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json fa1ef22 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json b1cc572 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 66f103b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json d2f5a05 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 4648ffc 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 4d58ded 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json c772a0e 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 9c5dae3 
  ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py daee726 
  ambari-server/src/test/python/stacks/2.1/configs/default.json de5eee9 
  ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json 26b0559 
  ambari-server/src/test/python/stacks/2.1/configs/secured.json 6ddab70 
  ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 9122a69 

Diff: https://reviews.apache.org/r/44556/diff/


Testing
-------

- Yes. Installation of hive-server2-hive2 and tez_hive2 goes fine with HDp 2.6.0.0-110 build.
- Python UT passes.
- "mvn clean test" -> In progress, will update the results.


Thanks,

Swapan Shridhar


Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.

Posted by Swapan Shridhar <ss...@hortonworks.com>.

> On March 15, 2016, 5:52 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 71
> > <https://reviews.apache.org/r/44556/diff/3/?file=1299368#file1299368line71>
> >
> >     This logic may have changed on trunk.

Still the same in other places. I'll update Jayush on it.


> On March 15, 2016, 5:52 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml, line 127
> > <https://reviews.apache.org/r/44556/diff/3/?file=1299371#file1299371line127>
> >
> >     Are we supporting amazon2015?

I do see refernce in other places. So, seems like we support.


- Swapan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44556/#review123704
-----------------------------------------------------------


On March 15, 2016, 7:01 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44556/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 7:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15360
>     https://issues.apache.org/jira/browse/AMBARI-15360
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 59c717b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py c94d956 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 3a90164 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py c5e61e6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d0924b9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 459845b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 7b87d40 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json b1cc572 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 66f103b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json d2f5a05 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 4648ffc 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 4d58ded 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 289d6b2 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 9c5dae3 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py daee726 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json de5eee9 
>   ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json 26b0559 
>   ambari-server/src/test/python/stacks/2.1/configs/secured.json 6ddab70 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 9122a69 
> 
> Diff: https://reviews.apache.org/r/44556/diff/
> 
> 
> Testing
> -------
> 
> - Yes. Installation tested on :
>     HDP 2.6 : Hive batch (existing) and hive-server2-hive2 and tez_hive2 installation goes fine with HDP 2.6.0.0-110 build.
>     HDP 2.6 : Hive batch (existing) and NOT (hive-server2-hive2 and tez_hive2) installation goes fine with HDP 2.6.0.0-110 build. 
>     HDP 2.3 : Hive batch (existing) installation goes fine with HDP 2.3 latest build.
>     
>     
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>


Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44556/#review123704
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 65)
<https://reviews.apache.org/r/44556/#comment185947>

    This logic may have changed on trunk.



ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml (line 127)
<https://reviews.apache.org/r/44556/#comment185948>

    Are we supporting amazon2015?


- Alejandro Fernandez


On March 15, 2016, 7:01 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44556/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 7:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15360
>     https://issues.apache.org/jira/browse/AMBARI-15360
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 59c717b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py c94d956 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 3a90164 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py c5e61e6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d0924b9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 459845b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 7b87d40 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json b1cc572 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 66f103b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json d2f5a05 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 4648ffc 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 4d58ded 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 289d6b2 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 9c5dae3 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py daee726 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json de5eee9 
>   ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json 26b0559 
>   ambari-server/src/test/python/stacks/2.1/configs/secured.json 6ddab70 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 9122a69 
> 
> Diff: https://reviews.apache.org/r/44556/diff/
> 
> 
> Testing
> -------
> 
> - Yes. Installation tested on :
>     HDP 2.6 : Hive batch (existing) and hive-server2-hive2 and tez_hive2 installation goes fine with HDP 2.6.0.0-110 build.
>     HDP 2.6 : Hive batch (existing) and NOT (hive-server2-hive2 and tez_hive2) installation goes fine with HDP 2.6.0.0-110 build. 
>     HDP 2.3 : Hive batch (existing) installation goes fine with HDP 2.3 latest build.
>     
>     
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>


Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.

Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44556/
-----------------------------------------------------------

(Updated March 15, 2016, 7:01 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Changes
-------

Suggestions incorporated.
Tested the behavior.


Bugs: AMBARI-15360
    https://issues.apache.org/jira/browse/AMBARI-15360


Repository: ambari


Description
-------

- HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa 
  ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 59c717b 
  ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py c94d956 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 3a90164 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py c5e61e6 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d0924b9 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 459845b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 7b87d40 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json b1cc572 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 66f103b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json d2f5a05 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 4648ffc 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 4d58ded 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 289d6b2 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 9c5dae3 
  ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py daee726 
  ambari-server/src/test/python/stacks/2.1/configs/default.json de5eee9 
  ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json 26b0559 
  ambari-server/src/test/python/stacks/2.1/configs/secured.json 6ddab70 
  ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 9122a69 

Diff: https://reviews.apache.org/r/44556/diff/


Testing
-------

- Yes. Installation tested on :
    HDP 2.6 : Hive batch (existing) and hive-server2-hive2 and tez_hive2 installation goes fine with HDP 2.6.0.0-110 build.
    HDP 2.6 : Hive batch (existing) and NOT (hive-server2-hive2 and tez_hive2) installation goes fine with HDP 2.6.0.0-110 build. 
    HDP 2.3 : Hive batch (existing) installation goes fine with HDP 2.3 latest build.
    
    
- Python UT passes.


Thanks,

Swapan Shridhar


Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.

Posted by Swapan Shridhar <ss...@hortonworks.com>.

> On March 15, 2016, 1:20 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py, line 111
> > <https://reviews.apache.org/r/44556/diff/2/?file=1298978#file1298978line111>
> >
> >     HIVE_SERVER_INTERACTIVE has a different config dir. I do not think we need to set this value if the role is HSI

Keeping it the way it is.


> On March 15, 2016, 1:20 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, line 176
> > <https://reviews.apache.org/r/44556/diff/2/?file=1298977#file1298977line176>
> >
> >     is this var needed?

Required for later checkins. Will remove now. Will add it when I am using it.


> On March 15, 2016, 1:20 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, line 412
> > <https://reviews.apache.org/r/44556/diff/2/?file=1298977#file1298977line412>
> >
> >     I know that UI adds it but lets not assume it to be there. Lets check if hive_interactive is deployed

Fixed the issue.


- Swapan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44556/#review123558
-----------------------------------------------------------


On March 15, 2016, 12:35 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44556/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15360
>     https://issues.apache.org/jira/browse/AMBARI-15360
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 59c717b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py c94d956 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 3a90164 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py c5e61e6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d0924b9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 459845b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 7b87d40 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json b1cc572 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 66f103b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json d2f5a05 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 4648ffc 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 4d58ded 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 289d6b2 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 9c5dae3 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py daee726 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json de5eee9 
>   ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json 26b0559 
>   ambari-server/src/test/python/stacks/2.1/configs/secured.json 6ddab70 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 9122a69 
> 
> Diff: https://reviews.apache.org/r/44556/diff/
> 
> 
> Testing
> -------
> 
> - Yes. Installation tested on :
>     HDP 2.6 : Hive batch (existing) and hive-server2-hive2 and tez_hive2 installation goes fine with HDP 2.6.0.0-110 build.
>     HDP 2.6 : Hive batch (existing) and NOT (hive-server2-hive2 and tez_hive2) installation goes fine with HDP 2.6.0.0-110 build. 
>     HDP 2.3 : Hive batch (existing) installation goes fine with HDP 2.3 latest build.
>     
>     
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>


Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44556/#review123558
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py (line 176)
<https://reviews.apache.org/r/44556/#comment185790>

    is this var needed?



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py (line 412)
<https://reviews.apache.org/r/44556/#comment185791>

    I know that UI adds it but lets not assume it to be there. Lets check if hive_interactive is deployed



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py (line 111)
<https://reviews.apache.org/r/44556/#comment185792>

    HIVE_SERVER_INTERACTIVE has a different config dir. I do not think we need to set this value if the role is HSI


- Sumit Mohanty


On March 15, 2016, 12:35 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44556/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15360
>     https://issues.apache.org/jira/browse/AMBARI-15360
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 59c717b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py c94d956 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 3a90164 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py c5e61e6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d0924b9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 459845b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 7b87d40 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json b1cc572 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 66f103b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json d2f5a05 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 4648ffc 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 4d58ded 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 289d6b2 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 9c5dae3 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py daee726 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json de5eee9 
>   ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json 26b0559 
>   ambari-server/src/test/python/stacks/2.1/configs/secured.json 6ddab70 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 9122a69 
> 
> Diff: https://reviews.apache.org/r/44556/diff/
> 
> 
> Testing
> -------
> 
> - Yes. Installation tested on :
>     HDP 2.6 : Hive batch (existing) and hive-server2-hive2 and tez_hive2 installation goes fine with HDP 2.6.0.0-110 build.
>     HDP 2.6 : Hive batch (existing) and NOT (hive-server2-hive2 and tez_hive2) installation goes fine with HDP 2.6.0.0-110 build. 
>     HDP 2.3 : Hive batch (existing) installation goes fine with HDP 2.3 latest build.
>     
>     
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>


Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.

Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44556/
-----------------------------------------------------------

(Updated March 15, 2016, 12:35 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Changes
-------

Fix the issues created during Hive install in HDP prior to 2.6.


Bugs: AMBARI-15360
    https://issues.apache.org/jira/browse/AMBARI-15360


Repository: ambari


Description
-------

- HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa 
  ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 59c717b 
  ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py c94d956 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 3a90164 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py c5e61e6 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d0924b9 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 459845b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 7b87d40 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json b1cc572 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 66f103b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json d2f5a05 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 4648ffc 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 4d58ded 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 289d6b2 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 9c5dae3 
  ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py daee726 
  ambari-server/src/test/python/stacks/2.1/configs/default.json de5eee9 
  ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json 26b0559 
  ambari-server/src/test/python/stacks/2.1/configs/secured.json 6ddab70 
  ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 9122a69 

Diff: https://reviews.apache.org/r/44556/diff/


Testing (updated)
-------

- Yes. Installation tested on :
    HDP 2.6 : Hive batch (existing) and hive-server2-hive2 and tez_hive2 installation goes fine with HDP 2.6.0.0-110 build.
    HDP 2.6 : Hive batch (existing) and NOT (hive-server2-hive2 and tez_hive2) installation goes fine with HDP 2.6.0.0-110 build. 
    HDP 2.3 : Hive batch (existing) installation goes fine with HDP 2.3 latest build.
    
    
- Python UT passes.


Thanks,

Swapan Shridhar


Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44556/#review123245
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On March 12, 2016, 12:23 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44556/
> -----------------------------------------------------------
> 
> (Updated March 12, 2016, 12:23 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15360
>     https://issues.apache.org/jira/browse/AMBARI-15360
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hive Server Interactive'.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 59c717b 
>   ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py c94d956 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 3a90164 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 9084c87 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d0924b9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 459845b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json fa1ef22 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json b1cc572 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json 66f103b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json d2f5a05 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 4648ffc 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 4d58ded 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json c772a0e 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 9c5dae3 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py daee726 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json de5eee9 
>   ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json 26b0559 
>   ambari-server/src/test/python/stacks/2.1/configs/secured.json 6ddab70 
>   ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 9122a69 
> 
> Diff: https://reviews.apache.org/r/44556/diff/
> 
> 
> Testing
> -------
> 
> - Yes. Installation of hive-server2-hive2 and tez_hive2 goes fine with HDp 2.6.0.0-110 build.
> - Python UT passes.
> - "mvn clean test" -> In progress, will update the results.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>