You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2020/03/22 22:43:02 UTC

[logging-log4j2] 03/03: Remove redundant instanceof

This is an automated email from the ASF dual-hosted git repository.

mattsicker pushed a commit to branch mean-bean-machine
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit 20f23a71ccb510c5e58065a82a0ba6e08140b7b2
Author: Matt Sicker <bo...@gmail.com>
AuthorDate: Sun Mar 22 17:35:40 2020 -0500

    Remove redundant instanceof
    
    Signed-off-by: Matt Sicker <bo...@gmail.com>
---
 .../logging/log4j/plugins/defaults/bean/DefaultInjectionTarget.java      | 1 -
 1 file changed, 1 deletion(-)

diff --git a/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/defaults/bean/DefaultInjectionTarget.java b/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/defaults/bean/DefaultInjectionTarget.java
index 85ccd14..a9052b8 100644
--- a/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/defaults/bean/DefaultInjectionTarget.java
+++ b/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/defaults/bean/DefaultInjectionTarget.java
@@ -87,7 +87,6 @@ class DefaultInjectionTarget<T> implements InjectionTarget<T> {
         final Set<MetaMember<?>> injectedMethods = new HashSet<>();
         for (final InjectionPoint point : injectionPoints) {
             if (point.getMember() instanceof MetaMethod<?, ?> &&
-                    point.getMember().getDeclaringClass().getJavaClass().isInstance(instance) &&
                     !injectedMethods.contains(point.getMember()) &&
                     !point.getElement().isAnnotationPresent(Produces.class) &&
                     !point.getElement().isAnnotationPresent(Disposes.class)) {